From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 3/3] arm64: dts: apq8016-sbc: Set up LDO2, LDO6 and LDO17 regulator voltage ranges Date: Thu, 1 Sep 2016 20:47:31 -0700 Message-ID: References: <1472640730-24326-1-git-send-email-architt@codeaurora.org> <1472640730-24326-4-git-send-email-architt@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-it0-f52.google.com ([209.85.214.52]:35676 "EHLO mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751497AbcIBDrc (ORCPT ); Thu, 1 Sep 2016 23:47:32 -0400 Received: by mail-it0-f52.google.com with SMTP id e124so16683819ith.0 for ; Thu, 01 Sep 2016 20:47:32 -0700 (PDT) In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stephen Boyd Cc: Archit Taneja , Andy Gross , Rob Herring , linux-arm-msm On Wed, Aug 31, 2016 at 1:54 PM, Stephen Boyd wrote: > On 08/31/2016 03:52 AM, Archit Taneja wrote: >> On the APQ8016 SBC, the LDO2 PM8916 regulator feeds 1.2V to the following: >> >> - VDDA_1P2_MIPI_DSI and VDDA_MIPI_CSI pins on APQ8016. >> - VCCCAD pins on the LPDDR3 chip. >> - VDDPX_1 pins on APQ8016. >> >> The LDO6 regulator feeds 1.8V to: >> - VDAA_MIPI_DSI0_PLL pin on APQ8016. >> - QFPROM_BLOW_VDD pin on PM8916. >> - The AVDD, A2VDD and DVDD pins on ADV7533 bridge. >> >> The LDO17 regulator feeds 3.3V to: >> - The V3P3 pin on ADV7533 bridge. >> >> Currently, the regulator min/max voltages for all the LDOs are set to the >> range of what the PMIC supports. Set the ranges for L2, L6 and L17 to what >> we need, i.e. 1.2V, 1.8V and 3.3V respectively. > > Why doesn't the consuming driver request a particular voltage on these > LDOs? It doesn't seem correct to modify board constraints to satisfy a > consumer (even if that consumer is on the board). > The devicetree should accurately describe the voltage constraints for each regulator on this board, rather than the constraints of the PMIC. As such the board designer will have to provide a single value for supplies of single-voltage consumers. This then saves us the trouble of only sometimes being allowed to "change voltage", depending on the supply being a LDO, LVS or just some fixed voltage source. Regards, Bjorn