[PATCH v4] staging: octeon: remove multiple blank lines

[PATCH v4] staging: octeon: remove multiple blank lines

[Gargi Sharma]

Fixes the checkpatch issue Please don't use multiple blank lines.
---
Changes in v4
	-Make the commit message follow protocol by putting v3 commit
	 subject before v2.

Changes in v3
        - Make the commit message more clearer. Also, fixed the subject
	  mistake in v2.

Changes in v2
	- Change the commit subject to :Correcting the commit
	  message. Fixes the checkpatch issue Please don't use multiple
	  blank lines.

Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
 drivers/staging/octeon/ethernet.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 0bd5c18..ec8e424 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-
 	cvm_oct_configure_common_hw();
 
 	cvmx_helper_initialize_packet_io_global();
@@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
 		}
 	}
 
-
 	cvmx_pko_shutdown();
 
 	cvmx_ipd_free_ptr();
-- 
2.9.2

base-commit: 45e35b5041a07a4cdf122ba8280e61cdba4f1092

Re: [PATCH v4] staging: octeon: remove multiple blank lines

[Greg KH]

On Thu, Sep 15, 2016 at 12:28:01AM +0530, Gargi Sharma wrote:
> Fixes the checkpatch issue Please don't use multiple blank lines.
> ---
> Changes in v4
> 	-Make the commit message follow protocol by putting v3 commit
> 	 subject before v2.
> 
> Changes in v3
>         - Make the commit message more clearer. Also, fixed the subject
> 	  mistake in v2.
> 
> Changes in v2
> 	- Change the commit subject to :Correcting the commit
> 	  message. Fixes the checkpatch issue Please don't use multiple
> 	  blank lines.
> 
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---

The Signed-off-by: has to go above the --- line :(

thanks,

greg k-h

Re: [PATCH v4] staging: octeon: remove multiple blank lines

[Gargi Sharma]

[-- Attachment #1: Type: text/plain, Size: 863 bytes --]

On Thu, Sep 15, 2016 at 11:02 PM, Greg KH <gregkh@linuxfoundation.org>
wrote:
>
> On Thu, Sep 15, 2016 at 12:28:01AM +0530, Gargi Sharma wrote:
> > Fixes the checkpatch issue Please don't use multiple blank lines.
> > ---
> > Changes in v4
> >       -Make the commit message follow protocol by putting v3 commit
> >        subject before v2.
> >
> > Changes in v3
> >         - Make the commit message more clearer. Also, fixed the subject
> >         mistake in v2.
> >
> > Changes in v2
> >       - Change the commit subject to :Correcting the commit
> >         message. Fixes the checkpatch issue Please don't use multiple
> >         blank lines.
> >
> > Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> > ---
>
> The Signed-off-by: has to go above the --- line :(

Ah, so sorry! Sending a revision correcting the mistake.

gargi

>
> thanks,
>
> greg k-h

[-- Attachment #2: Type: text/html, Size: 1275 bytes --]