Hi

On Tue, Sep 13, 2016 at 9:27 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>
> On Tue, 13 Sep 2016, Gargi Sharma wrote:
>
> > Fixes the checkpatch issue Logical continuations should be on the
> > previous line.
> >
> > Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> > ---
> >  drivers/staging/xgifb/vb_setmode.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
> > index 50c8ea4..ac27b2c 100644
> > --- a/drivers/staging/xgifb/vb_setmode.c
> > +++ b/drivers/staging/xgifb/vb_setmode.c
> > @@ -1741,8 +1741,8 @@ static void XGI_SetCRT2ECLK(unsigned short
ModeIdIndex,
> >       for (i = 0; i < 4; i++) {
> >               xgifb_reg_and_or(pVBInfo->P3d4, 0x31, ~0x30,
> >                               (unsigned short) (0x10 * i));
> > -             if ((!(pVBInfo->VBInfo & XGI_SetCRT2ToLCDA))
> > -                             && (!(pVBInfo->VBInfo & SetInSlaveMode)))
{
> > +             if ((!(pVBInfo->VBInfo & XGI_SetCRT2ToLCDA)) &&
> > +                             (!(pVBInfo->VBInfo & SetInSlaveMode))) {
>
> It's another issue, but all of those parentheses are rather tiring to look
> at.  The ones outside the ! are not needed.  The indentation is also a bit
> much.  There is no need for the argument of && to be aligned with the
> third argument of xgifb_reg_and_or.  At least drop one tab, or even align
> the two ! expressions.
>The space is also not needed after (unsigned
> short) in the line above.

This check is generated by the checkpatch, and will send another patch
addressing this issue.

>This should be done in a series, with one patch
> per change.

So should I send a patch-set or separate patches per change?

gargi

>
> julia
>
> >                       xgifb_reg_set(pVBInfo->P3c4, 0x2e, di_0);
> >                       xgifb_reg_set(pVBInfo->P3c4, 0x2f, di_1);
> >               } else {
> > --
> > 2.9.2
> >
> > --
> > You received this message because you are subscribed to the Google
Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/ms
gid/outreachy-kernel/20160913155037.12206-1-gs051095%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >