From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75057C5DF60 for ; Thu, 7 Nov 2019 17:40:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FB3C218AE for ; Thu, 7 Nov 2019 17:40:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dik/qDtZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728847AbfKGRkl (ORCPT ); Thu, 7 Nov 2019 12:40:41 -0500 Received: from mail-il1-f195.google.com ([209.85.166.195]:43192 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727132AbfKGRkl (ORCPT ); Thu, 7 Nov 2019 12:40:41 -0500 Received: by mail-il1-f195.google.com with SMTP id r9so2557450ilq.10; Thu, 07 Nov 2019 09:40:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yOo0PDlDopuEcfVjLmbeQrHkAsp6K2BWDtJG0uxJS8o=; b=Dik/qDtZvYOqAPnaXltVe5lMrg/AJQuBQ5jkmaEa5UAW6OKXLXxniHZt2cbfEPmbZe UxE7ocz1UAkvlITt5B4ivXVR8GUeb+CfpRb2Ix23jJw9C/XJpo1dj3YC5bNi4zzCpFbt QTqKlhZ6xGiqZlCav+TlabSn0DwHdOlB55ERXe3hAJNsnvgR7bOK/XG8D6eg/wqXU+Sg Bnsu9drtxFEfEHer3O4ASZReuaEVFDaUFmDXSiorCEHnFR1MY5pkXIFTucToWqTjx2l/ /hU/KDhN6x1CRm2sUfvDBmzTEpC6hVezf/jJ6cd121F9zn4cT9E20jTuPbfXOTlN32CQ i4yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yOo0PDlDopuEcfVjLmbeQrHkAsp6K2BWDtJG0uxJS8o=; b=aCJdCAo38Wnmd/HZ6LmejgGxIMRs3QHuKpk2t++xjtcjbXqiS3YwH598Od7BWEtnt1 5msOe/QiJoBhagEEaXH7slnA2PQTc+AvkU+hyiZthzPPVezvbwJFLpl+jUR6Ppc0ehDa WhvPydR9bbszdJ7izlt17twSF0LvgZpIloofDHcxx4bhIhsgWDFMZBmHOt7dyciPfo+I Zy4kqOohpvQch3uO827sJr+ODE0wCF3Z1QwsszipIzGEIakVDq+0GGrme9O1fa92ynpC Tbd2Ict/vvdyjFa6aeIUP1rAiMiXnM8qHScTFfPISrN+ASEKfyXIKlug6uxL+0QcQpmn +ptg== X-Gm-Message-State: APjAAAXFabXl98Rd8EWcK6AGIRi+0v4Ra1bAjnCFEOtSaybweYXPt6Sv Lg2e5GREO0NdTwHgB0OEw0tbGMtGIM6bKNfe+8c= X-Google-Smtp-Source: APXvYqykagGCSdu1ecPWSK+7WUrDmTy8tNUSaESVTaqLyccAdN0CMpfzsRbj+/KQR7pNFVXjELh3Yio7zN2bGhWgw7w= X-Received: by 2002:a92:831d:: with SMTP id f29mr6048008ild.263.1573148440248; Thu, 07 Nov 2019 09:40:40 -0800 (PST) MIME-Version: 1.0 References: <20191105000129.GA6536@onstation.org> <20191105100804.GA9492@onstation.org> <20191106091335.GA16729@onstation.org> <20191107111019.GA24028@onstation.org> In-Reply-To: From: Jeffrey Hugo Date: Thu, 7 Nov 2019 10:40:28 -0700 Message-ID: Subject: Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes To: Rob Clark Cc: Brian Masney , Rob Clark , freedreno , Linux Kernel Mailing List , dri-devel , linux-arm-msm , Sean Paul Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Nov 7, 2019 at 9:17 AM Rob Clark wrote: > > On Thu, Nov 7, 2019 at 3:10 AM Brian Masney wrote: > > > > On Wed, Nov 06, 2019 at 08:58:59AM -0800, Rob Clark wrote: > > > On Wed, Nov 6, 2019 at 8:47 AM Jeffrey Hugo wrote: > > > > > > > > On Wed, Nov 6, 2019 at 9:30 AM Rob Clark wrote: > > > > > > > > > > On Wed, Nov 6, 2019 at 1:13 AM Brian Masney wrote: > > > > > > > > > > > > On Tue, Nov 05, 2019 at 08:23:27AM -0800, Rob Clark wrote: > > > > > > > On Tue, Nov 5, 2019 at 2:08 AM Brian Masney wrote: > > > > > > > > The 'pp done time out' errors go away if I revert the following three > > > > > > > > commits: > > > > > > > > > > > > > > > > cd6d923167b1 ("drm/msm/dpu: async commit support") > > > > > > > > d934a712c5e6 ("drm/msm: add atomic traces") > > > > > > > > 2d99ced787e3 ("drm/msm: async commit support") > > > > > > > > > > > > > > > > I reverted the first one to fix a compiler error, and the second one so > > > > > > > > that the last patch can be reverted without any merge conflicts. > > > > > > > > > > > > > > > > I see that crtc_flush() calls mdp5_ctl_commit(). I tried to use > > > > > > > > crtc_flush_all() in mdp5_flush_commit() and the contents of the frame > > > > > > > > buffer dance around the screen like its out of sync. I renamed > > > > > > > > crtc_flush_all() to mdp5_crtc_flush_all() and removed the static > > > > > > > > declaration. Here's the relevant part of what I tried: > > > > > > > > > > > > > > > > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > > > > > > > > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > > > > > > > > @@ -171,7 +171,15 @@ static void mdp5_prepare_commit(struct msm_kms *kms, struct drm_atomic_state *st > > > > > > > > > > > > > > > > static void mdp5_flush_commit(struct msm_kms *kms, unsigned crtc_mask) > > > > > > > > { > > > > > > > > - /* TODO */ > > > > > > > > + struct mdp5_kms *mdp5_kms = to_mdp5_kms(to_mdp_kms(kms)); > > > > > > > > + struct drm_crtc *crtc; > > > > > > > > + > > > > > > > > + for_each_crtc_mask(mdp5_kms->dev, crtc, crtc_mask) { > > > > > > > > + if (!crtc->state->active) > > > > > > > > + continue; > > > > > > > > + > > > > > > > > + mdp5_crtc_flush_all(crtc); > > > > > > > > + } > > > > > > > > } > > > > > > > > > > > > > > > > Any tips would be appreciated. > > > > > > > > > > > > > > > > > > > > > I think this is along the lines of what we need to enable async commit > > > > > > > for mdp5 (but also removing the flush from the atomic-commit path).. > > > > > > > the principle behind the async commit is to do all the atomic state > > > > > > > commit normally, but defer writing the flush bits. This way, if you > > > > > > > get another async update before the next vblank, you just apply it > > > > > > > immediately instead of waiting for vblank. > > > > > > > > > > > > > > But I guess you are on a command mode panel, if I remember? Which is > > > > > > > a case I didn't have a way to test. And I'm not entirely about how > > > > > > > kms_funcs->vsync_time() should be implemented for cmd mode panels. > > > > > > > > > > > > Yes, this is a command-mode panel and there's no hardware frame counter > > > > > > available. The key to getting the display working on this phone was this > > > > > > patch: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2bab52af6fe68c43b327a57e5ce5fc10eefdfadf > > > > > > > > > > > > > That all said, I think we should first fix what is broken, before > > > > > > > worrying about extending async commit support to mdp5.. which > > > > > > > shouldn't hit the async==true path, due to not implementing > > > > > > > kms_funcs->vsync_time(). > > > > > > > > > > > > > > What I think is going on is that, in the cmd mode case, > > > > > > > mdp5_wait_flush() (indirectly) calls mdp5_crtc_wait_for_pp_done(), > > > > > > > which waits for a pp-done irq regardless of whether there is a flush > > > > > > > in progress. Since there is no flush pending, the irq never comes. > > > > > > > But the expectation is that kms_funcs->wait_flush() returns > > > > > > > immediately if there is nothing to wait for. > > > > > > > > > > > > I don't think that's happening in this case. I added some pr_info() > > > > > > statements to request_pp_done_pending() and mdp5_crtc_pp_done_irq(). > > > > > > Here's the first two sets of messages that appear in dmesg: > > > > > > > > > > > > [ 14.018907] msm fd900000.mdss: pp done time out, lm=0 > > > > > > [ 14.018993] request_pp_done_pending: HERE > > > > > > [ 14.074208] mdp5_crtc_pp_done_irq: HERE > > > > > > [ 14.074368] Console: switching to colour frame buffer device 135x120 > > > > > > [ 14.138938] msm fd900000.mdss: pp done time out, lm=0 > > > > > > [ 14.139021] request_pp_done_pending: HERE > > > > > > [ 14.158097] mdp5_crtc_pp_done_irq: HERE > > > > > > > > > > > > The messages go on like this with the same pattern. > > > > > > > > > > > > I tried two different changes: > > > > > > > > > > > > 1) I moved the request_pp_done_pending() and corresponding if statement > > > > > > from mdp5_crtc_atomic_flush() and into mdp5_crtc_atomic_begin(). > > > > > > > > > > > > 2) I increased the timeout in wait_for_completion_timeout() by several > > > > > > increments; all the way to 5 seconds. > > > > > > > > > > increasing the timeout won't help, because the pp-done irq has already > > > > > come at the point where we wait for it.. > > > > > > > > > > maybe the easy thing is just add mdp5_crtc->needs_pp, set to true > > > > > before requesting, and false when we get the irq.. and then > > > > > mdp5_crtc_wait_for_pp_done() just returns if needs_pp==false.. > > > > > > > > On the otherhand, what about trying to make command mode panels > > > > resemble video mode panels slightly? Video mode panels have a vsync > > > > counter in hardware, which is missing from command mode - however it > > > > seems like the driver/drm framework would prefer such a counter. > > > > Would it be a reasonable idea to make a software counter, and just > > > > increment it every time the pp_done irq is triggered? > > > > > > > > I'm just thinking that we'll avoid issues long term by trying to make > > > > the code common, rather than diverging it for the two modes. > > > > > > > > > > *possibly*, but I think we want to account somehow periods where > > > display is not updated. > > > > > > fwiw, it isn't that uncommon for userspace to use vblanks to "keep > > > time" (drive animations for desktop switch, window > > > maximize/unmaximize, etc).. it could be a surprise when "vblank" is > > > not periodic. > > > > What do you think about using some variation of the current value of > > jiffies in the kernel + the number of pp_done IRQs as the software > > counter for command-mode panels? > > > > jiffies is probably too coarse.. but we could use monotonic clock, I guess. > > But I suppose even a cmd mode panel has a "vblank", it is just > internal the panel. Do we get the TE interrupt at regular intervals? > AFAIU this would be tied to the panel's internal vblank. The TE interrupt was first implemented in MDP 1.7.0 (msm8996). 8974 predates that. You can get it from the WR_PTR interrupt, but you have to understand details about your panel to configure that correctly. > > BR, > -R From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E1AEFA372C for ; Fri, 8 Nov 2019 08:14:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC96221D7B for ; Fri, 8 Nov 2019 08:14:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC96221D7B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 884A56F887; Fri, 8 Nov 2019 08:12:58 +0000 (UTC) Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by gabe.freedesktop.org (Postfix) with ESMTPS id 090E36F768; Thu, 7 Nov 2019 17:40:41 +0000 (UTC) Received: by mail-il1-x144.google.com with SMTP id p6so2589522ilp.1; Thu, 07 Nov 2019 09:40:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yOo0PDlDopuEcfVjLmbeQrHkAsp6K2BWDtJG0uxJS8o=; b=TOAkIKQI+Z4qkXyiLOBpz/D72DJ1xjkRQDUMyEvHGgNWtFUugxCVbR7/vGaL35Mnmi UjvSfT4gMSOER4MWBIqI17hQGLarwoNRP2J8WshSfPhjVbjuO2M3CIuIpfnpM4oDwCvG ZiDo4A6x8xn68fuqJNxxpDQ2mutFlYfqBySHWwELUC8UMWuyb8+itbZHwJQGGzorgwOC YB8edJpwLjTbPA5qEA5ePMMN07Xyl5pyQGCM3Gu7oLhm5kQN3VOaJuWJ3LwJqE7UWV3k xqXaIow72zkBpApAC6qohGRRLSxrlNsAK7gukEJfoVCcAD2F8Gi5oQGhaYe4AiY/wsJB +XUA== X-Gm-Message-State: APjAAAWdDacId8+5gl4zw4MkSfYVSNpuslBgkcKh2XTMlctJ84HT2owc kQyEagHXBGExHYnIMKlffDAVzKcRhBRyqiOX9sg= X-Google-Smtp-Source: APXvYqykagGCSdu1ecPWSK+7WUrDmTy8tNUSaESVTaqLyccAdN0CMpfzsRbj+/KQR7pNFVXjELh3Yio7zN2bGhWgw7w= X-Received: by 2002:a92:831d:: with SMTP id f29mr6048008ild.263.1573148440248; Thu, 07 Nov 2019 09:40:40 -0800 (PST) MIME-Version: 1.0 References: <20191105000129.GA6536@onstation.org> <20191105100804.GA9492@onstation.org> <20191106091335.GA16729@onstation.org> <20191107111019.GA24028@onstation.org> In-Reply-To: From: Jeffrey Hugo Date: Thu, 7 Nov 2019 10:40:28 -0700 Message-ID: Subject: Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes To: Rob Clark X-Mailman-Approved-At: Fri, 08 Nov 2019 08:12:31 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yOo0PDlDopuEcfVjLmbeQrHkAsp6K2BWDtJG0uxJS8o=; b=Dik/qDtZvYOqAPnaXltVe5lMrg/AJQuBQ5jkmaEa5UAW6OKXLXxniHZt2cbfEPmbZe UxE7ocz1UAkvlITt5B4ivXVR8GUeb+CfpRb2Ix23jJw9C/XJpo1dj3YC5bNi4zzCpFbt QTqKlhZ6xGiqZlCav+TlabSn0DwHdOlB55ERXe3hAJNsnvgR7bOK/XG8D6eg/wqXU+Sg Bnsu9drtxFEfEHer3O4ASZReuaEVFDaUFmDXSiorCEHnFR1MY5pkXIFTucToWqTjx2l/ /hU/KDhN6x1CRm2sUfvDBmzTEpC6hVezf/jJ6cd121F9zn4cT9E20jTuPbfXOTlN32CQ i4yA== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , linux-arm-msm , Linux Kernel Mailing List , dri-devel , Sean Paul , freedreno , Brian Masney Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191107174028.n-YWL_lPVmdHhUUNI179hFRdGs0nmJKtD1XfVweigas@z> T24gVGh1LCBOb3YgNywgMjAxOSBhdCA5OjE3IEFNIFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWls LmNvbT4gd3JvdGU6Cj4KPiBPbiBUaHUsIE5vdiA3LCAyMDE5IGF0IDM6MTAgQU0gQnJpYW4gTWFz bmV5IDxtYXNuZXliQG9uc3RhdGlvbi5vcmc+IHdyb3RlOgo+ID4KPiA+IE9uIFdlZCwgTm92IDA2 LCAyMDE5IGF0IDA4OjU4OjU5QU0gLTA4MDAsIFJvYiBDbGFyayB3cm90ZToKPiA+ID4gT24gV2Vk LCBOb3YgNiwgMjAxOSBhdCA4OjQ3IEFNIEplZmZyZXkgSHVnbyA8amVmZnJleS5sLmh1Z29AZ21h aWwuY29tPiB3cm90ZToKPiA+ID4gPgo+ID4gPiA+IE9uIFdlZCwgTm92IDYsIDIwMTkgYXQgOToz MCBBTSBSb2IgQ2xhcmsgPHJvYmRjbGFya0BnbWFpbC5jb20+IHdyb3RlOgo+ID4gPiA+ID4KPiA+ ID4gPiA+IE9uIFdlZCwgTm92IDYsIDIwMTkgYXQgMToxMyBBTSBCcmlhbiBNYXNuZXkgPG1hc25l eWJAb25zdGF0aW9uLm9yZz4gd3JvdGU6Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IE9uIFR1ZSwg Tm92IDA1LCAyMDE5IGF0IDA4OjIzOjI3QU0gLTA4MDAsIFJvYiBDbGFyayB3cm90ZToKPiA+ID4g PiA+ID4gPiBPbiBUdWUsIE5vdiA1LCAyMDE5IGF0IDI6MDggQU0gQnJpYW4gTWFzbmV5IDxtYXNu ZXliQG9uc3RhdGlvbi5vcmc+IHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4gVGhlICdwcCBkb25lIHRp bWUgb3V0JyBlcnJvcnMgZ28gYXdheSBpZiBJIHJldmVydCB0aGUgZm9sbG93aW5nIHRocmVlCj4g PiA+ID4gPiA+ID4gPiBjb21taXRzOgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiA+IGNk NmQ5MjMxNjdiMSAoImRybS9tc20vZHB1OiBhc3luYyBjb21taXQgc3VwcG9ydCIpCj4gPiA+ID4g PiA+ID4gPiBkOTM0YTcxMmM1ZTYgKCJkcm0vbXNtOiBhZGQgYXRvbWljIHRyYWNlcyIpCj4gPiA+ ID4gPiA+ID4gPiAyZDk5Y2VkNzg3ZTMgKCJkcm0vbXNtOiBhc3luYyBjb21taXQgc3VwcG9ydCIp Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gSSByZXZlcnRlZCB0aGUgZmlyc3Qgb25l IHRvIGZpeCBhIGNvbXBpbGVyIGVycm9yLCBhbmQgdGhlIHNlY29uZCBvbmUgc28KPiA+ID4gPiA+ ID4gPiA+IHRoYXQgdGhlIGxhc3QgcGF0Y2ggY2FuIGJlIHJldmVydGVkIHdpdGhvdXQgYW55IG1l cmdlIGNvbmZsaWN0cy4KPiA+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gPiBJIHNlZSB0aGF0 IGNydGNfZmx1c2goKSBjYWxscyBtZHA1X2N0bF9jb21taXQoKS4gSSB0cmllZCB0byB1c2UKPiA+ ID4gPiA+ID4gPiA+IGNydGNfZmx1c2hfYWxsKCkgaW4gbWRwNV9mbHVzaF9jb21taXQoKSBhbmQg dGhlIGNvbnRlbnRzIG9mIHRoZSBmcmFtZQo+ID4gPiA+ID4gPiA+ID4gYnVmZmVyIGRhbmNlIGFy b3VuZCB0aGUgc2NyZWVuIGxpa2UgaXRzIG91dCBvZiBzeW5jLiBJIHJlbmFtZWQKPiA+ID4gPiA+ ID4gPiA+IGNydGNfZmx1c2hfYWxsKCkgdG8gbWRwNV9jcnRjX2ZsdXNoX2FsbCgpIGFuZCByZW1v dmVkIHRoZSBzdGF0aWMKPiA+ID4gPiA+ID4gPiA+IGRlY2xhcmF0aW9uLiBIZXJlJ3MgdGhlIHJl bGV2YW50IHBhcnQgb2Ygd2hhdCBJIHRyaWVkOgo+ID4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4g PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9tZHA1L21kcDVfa21zLmMKPiA+ID4g PiA+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9tZHA1L21kcDVfa21zLmMK PiA+ID4gPiA+ID4gPiA+IEBAIC0xNzEsNyArMTcxLDE1IEBAIHN0YXRpYyB2b2lkIG1kcDVfcHJl cGFyZV9jb21taXQoc3RydWN0IG1zbV9rbXMgKmttcywgc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0Cj4gPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+ID4gIHN0YXRpYyB2b2lkIG1kcDVfZmx1 c2hfY29tbWl0KHN0cnVjdCBtc21fa21zICprbXMsIHVuc2lnbmVkIGNydGNfbWFzaykKPiA+ID4g PiA+ID4gPiA+ICB7Cj4gPiA+ID4gPiA+ID4gPiAtICAgICAgIC8qIFRPRE8gKi8KPiA+ID4gPiA+ ID4gPiA+ICsgICAgICAgc3RydWN0IG1kcDVfa21zICptZHA1X2ttcyA9IHRvX21kcDVfa21zKHRv X21kcF9rbXMoa21zKSk7Cj4gPiA+ID4gPiA+ID4gPiArICAgICAgIHN0cnVjdCBkcm1fY3J0YyAq Y3J0YzsKPiA+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4gPiA+ICsgICAgICAgZm9yX2VhY2hf Y3J0Y19tYXNrKG1kcDVfa21zLT5kZXYsIGNydGMsIGNydGNfbWFzaykgewo+ID4gPiA+ID4gPiA+ ID4gKyAgICAgICAgICAgICAgIGlmICghY3J0Yy0+c3RhdGUtPmFjdGl2ZSkKPiA+ID4gPiA+ID4g PiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+ID4gPiA+ID4gPiA+ID4gKwo+ ID4gPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgIG1kcDVfY3J0Y19mbHVzaF9hbGwoY3J0Yyk7 Cj4gPiA+ID4gPiA+ID4gPiArICAgICAgIH0KPiA+ID4gPiA+ID4gPiA+ICB9Cj4gPiA+ID4gPiA+ ID4gPgo+ID4gPiA+ID4gPiA+ID4gQW55IHRpcHMgd291bGQgYmUgYXBwcmVjaWF0ZWQuCj4gPiA+ ID4gPiA+ID4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IEkgdGhpbmsgdGhpcyBpcyBhbG9u ZyB0aGUgbGluZXMgb2Ygd2hhdCB3ZSBuZWVkIHRvIGVuYWJsZSBhc3luYyBjb21taXQKPiA+ID4g PiA+ID4gPiBmb3IgbWRwNSAoYnV0IGFsc28gcmVtb3ZpbmcgdGhlIGZsdXNoIGZyb20gdGhlIGF0 b21pYy1jb21taXQgcGF0aCkuLgo+ID4gPiA+ID4gPiA+IHRoZSBwcmluY2lwbGUgYmVoaW5kIHRo ZSBhc3luYyBjb21taXQgaXMgdG8gZG8gYWxsIHRoZSBhdG9taWMgc3RhdGUKPiA+ID4gPiA+ID4g PiBjb21taXQgbm9ybWFsbHksIGJ1dCBkZWZlciB3cml0aW5nIHRoZSBmbHVzaCBiaXRzLiAgVGhp cyB3YXksIGlmIHlvdQo+ID4gPiA+ID4gPiA+IGdldCBhbm90aGVyIGFzeW5jIHVwZGF0ZSBiZWZv cmUgdGhlIG5leHQgdmJsYW5rLCB5b3UganVzdCBhcHBseSBpdAo+ID4gPiA+ID4gPiA+IGltbWVk aWF0ZWx5IGluc3RlYWQgb2Ygd2FpdGluZyBmb3IgdmJsYW5rLgo+ID4gPiA+ID4gPiA+Cj4gPiA+ ID4gPiA+ID4gQnV0IEkgZ3Vlc3MgeW91IGFyZSBvbiBhIGNvbW1hbmQgbW9kZSBwYW5lbCwgaWYg SSByZW1lbWJlcj8gIFdoaWNoIGlzCj4gPiA+ID4gPiA+ID4gYSBjYXNlIEkgZGlkbid0IGhhdmUg YSB3YXkgdG8gdGVzdC4gIEFuZCBJJ20gbm90IGVudGlyZWx5IGFib3V0IGhvdwo+ID4gPiA+ID4g PiA+IGttc19mdW5jcy0+dnN5bmNfdGltZSgpIHNob3VsZCBiZSBpbXBsZW1lbnRlZCBmb3IgY21k IG1vZGUgcGFuZWxzLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBZZXMsIHRoaXMgaXMgYSBjb21t YW5kLW1vZGUgcGFuZWwgYW5kIHRoZXJlJ3Mgbm8gaGFyZHdhcmUgZnJhbWUgY291bnRlcgo+ID4g PiA+ID4gPiBhdmFpbGFibGUuIFRoZSBrZXkgdG8gZ2V0dGluZyB0aGUgZGlzcGxheSB3b3JraW5n IG9uIHRoaXMgcGhvbmUgd2FzIHRoaXMKPiA+ID4gPiA+ID4gcGF0Y2g6Cj4gPiA+ID4gPiA+IGh0 dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xp bnV4LmdpdC9jb21taXQvP2lkPTJiYWI1MmFmNmZlNjhjNDNiMzI3YTU3ZTVjZTVmYzEwZWVmZGZh ZGYKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBUaGF0IGFsbCBzYWlkLCBJIHRoaW5rIHdlIHNo b3VsZCBmaXJzdCBmaXggd2hhdCBpcyBicm9rZW4sIGJlZm9yZQo+ID4gPiA+ID4gPiA+IHdvcnJ5 aW5nIGFib3V0IGV4dGVuZGluZyBhc3luYyBjb21taXQgc3VwcG9ydCB0byBtZHA1Li4gd2hpY2gK PiA+ID4gPiA+ID4gPiBzaG91bGRuJ3QgaGl0IHRoZSBhc3luYz09dHJ1ZSBwYXRoLCBkdWUgdG8g bm90IGltcGxlbWVudGluZwo+ID4gPiA+ID4gPiA+IGttc19mdW5jcy0+dnN5bmNfdGltZSgpLgo+ ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gV2hhdCBJIHRoaW5rIGlzIGdvaW5nIG9uIGlzIHRo YXQsIGluIHRoZSBjbWQgbW9kZSBjYXNlLAo+ID4gPiA+ID4gPiA+IG1kcDVfd2FpdF9mbHVzaCgp IChpbmRpcmVjdGx5KSBjYWxscyBtZHA1X2NydGNfd2FpdF9mb3JfcHBfZG9uZSgpLAo+ID4gPiA+ ID4gPiA+IHdoaWNoIHdhaXRzIGZvciBhIHBwLWRvbmUgaXJxIHJlZ2FyZGxlc3Mgb2Ygd2hldGhl ciB0aGVyZSBpcyBhIGZsdXNoCj4gPiA+ID4gPiA+ID4gaW4gcHJvZ3Jlc3MuICBTaW5jZSB0aGVy ZSBpcyBubyBmbHVzaCBwZW5kaW5nLCB0aGUgaXJxIG5ldmVyIGNvbWVzLgo+ID4gPiA+ID4gPiA+ IEJ1dCB0aGUgZXhwZWN0YXRpb24gaXMgdGhhdCBrbXNfZnVuY3MtPndhaXRfZmx1c2goKSByZXR1 cm5zCj4gPiA+ID4gPiA+ID4gaW1tZWRpYXRlbHkgaWYgdGhlcmUgaXMgbm90aGluZyB0byB3YWl0 IGZvci4KPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gSSBkb24ndCB0aGluayB0aGF0J3MgaGFwcGVu aW5nIGluIHRoaXMgY2FzZS4gSSBhZGRlZCBzb21lIHByX2luZm8oKQo+ID4gPiA+ID4gPiBzdGF0 ZW1lbnRzIHRvIHJlcXVlc3RfcHBfZG9uZV9wZW5kaW5nKCkgYW5kIG1kcDVfY3J0Y19wcF9kb25l X2lycSgpLgo+ID4gPiA+ID4gPiBIZXJlJ3MgdGhlIGZpcnN0IHR3byBzZXRzIG9mIG1lc3NhZ2Vz IHRoYXQgYXBwZWFyIGluIGRtZXNnOgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBbICAgMTQuMDE4 OTA3XSBtc20gZmQ5MDAwMDAubWRzczogcHAgZG9uZSB0aW1lIG91dCwgbG09MAo+ID4gPiA+ID4g PiBbICAgMTQuMDE4OTkzXSByZXF1ZXN0X3BwX2RvbmVfcGVuZGluZzogSEVSRQo+ID4gPiA+ID4g PiBbICAgMTQuMDc0MjA4XSBtZHA1X2NydGNfcHBfZG9uZV9pcnE6IEhFUkUKPiA+ID4gPiA+ID4g WyAgIDE0LjA3NDM2OF0gQ29uc29sZTogc3dpdGNoaW5nIHRvIGNvbG91ciBmcmFtZSBidWZmZXIg ZGV2aWNlIDEzNXgxMjAKPiA+ID4gPiA+ID4gWyAgIDE0LjEzODkzOF0gbXNtIGZkOTAwMDAwLm1k c3M6IHBwIGRvbmUgdGltZSBvdXQsIGxtPTAKPiA+ID4gPiA+ID4gWyAgIDE0LjEzOTAyMV0gcmVx dWVzdF9wcF9kb25lX3BlbmRpbmc6IEhFUkUKPiA+ID4gPiA+ID4gWyAgIDE0LjE1ODA5N10gbWRw NV9jcnRjX3BwX2RvbmVfaXJxOiBIRVJFCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFRoZSBtZXNz YWdlcyBnbyBvbiBsaWtlIHRoaXMgd2l0aCB0aGUgc2FtZSBwYXR0ZXJuLgo+ID4gPiA+ID4gPgo+ ID4gPiA+ID4gPiBJIHRyaWVkIHR3byBkaWZmZXJlbnQgY2hhbmdlczoKPiA+ID4gPiA+ID4KPiA+ ID4gPiA+ID4gMSkgSSBtb3ZlZCB0aGUgcmVxdWVzdF9wcF9kb25lX3BlbmRpbmcoKSBhbmQgY29y cmVzcG9uZGluZyBpZiBzdGF0ZW1lbnQKPiA+ID4gPiA+ID4gICAgZnJvbSBtZHA1X2NydGNfYXRv bWljX2ZsdXNoKCkgYW5kIGludG8gbWRwNV9jcnRjX2F0b21pY19iZWdpbigpLgo+ID4gPiA+ID4g Pgo+ID4gPiA+ID4gPiAyKSBJIGluY3JlYXNlZCB0aGUgdGltZW91dCBpbiB3YWl0X2Zvcl9jb21w bGV0aW9uX3RpbWVvdXQoKSBieSBzZXZlcmFsCj4gPiA+ID4gPiA+ICAgIGluY3JlbWVudHM7IGFs bCB0aGUgd2F5IHRvIDUgc2Vjb25kcy4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBpbmNyZWFzaW5nIHRo ZSB0aW1lb3V0IHdvbid0IGhlbHAsIGJlY2F1c2UgdGhlIHBwLWRvbmUgaXJxIGhhcyBhbHJlYWR5 Cj4gPiA+ID4gPiBjb21lIGF0IHRoZSBwb2ludCB3aGVyZSB3ZSB3YWl0IGZvciBpdC4uCj4gPiA+ ID4gPgo+ID4gPiA+ID4gbWF5YmUgdGhlIGVhc3kgdGhpbmcgaXMganVzdCBhZGQgbWRwNV9jcnRj LT5uZWVkc19wcCwgc2V0IHRvIHRydWUKPiA+ID4gPiA+IGJlZm9yZSByZXF1ZXN0aW5nLCBhbmQg ZmFsc2Ugd2hlbiB3ZSBnZXQgdGhlIGlycS4uIGFuZCB0aGVuCj4gPiA+ID4gPiBtZHA1X2NydGNf d2FpdF9mb3JfcHBfZG9uZSgpIGp1c3QgcmV0dXJucyBpZiBuZWVkc19wcD09ZmFsc2UuLgo+ID4g PiA+Cj4gPiA+ID4gT24gdGhlIG90aGVyaGFuZCwgd2hhdCBhYm91dCB0cnlpbmcgdG8gbWFrZSBj b21tYW5kIG1vZGUgcGFuZWxzCj4gPiA+ID4gcmVzZW1ibGUgdmlkZW8gbW9kZSBwYW5lbHMgc2xp Z2h0bHk/ICBWaWRlbyBtb2RlIHBhbmVscyBoYXZlIGEgdnN5bmMKPiA+ID4gPiBjb3VudGVyIGlu IGhhcmR3YXJlLCB3aGljaCBpcyBtaXNzaW5nIGZyb20gY29tbWFuZCBtb2RlIC0gaG93ZXZlciBp dAo+ID4gPiA+IHNlZW1zIGxpa2UgdGhlIGRyaXZlci9kcm0gZnJhbWV3b3JrIHdvdWxkIHByZWZl ciBzdWNoIGEgY291bnRlci4KPiA+ID4gPiBXb3VsZCBpdCBiZSBhIHJlYXNvbmFibGUgaWRlYSB0 byBtYWtlIGEgc29mdHdhcmUgY291bnRlciwgYW5kIGp1c3QKPiA+ID4gPiBpbmNyZW1lbnQgaXQg ZXZlcnkgdGltZSB0aGUgcHBfZG9uZSBpcnEgaXMgdHJpZ2dlcmVkPwo+ID4gPiA+Cj4gPiA+ID4g SSdtIGp1c3QgdGhpbmtpbmcgdGhhdCB3ZSdsbCBhdm9pZCBpc3N1ZXMgbG9uZyB0ZXJtIGJ5IHRy eWluZyB0byBtYWtlCj4gPiA+ID4gdGhlIGNvZGUgY29tbW9uLCByYXRoZXIgdGhhbiBkaXZlcmdp bmcgaXQgZm9yIHRoZSB0d28gbW9kZXMuCj4gPiA+ID4KPiA+ID4KPiA+ID4gKnBvc3NpYmx5Kiwg YnV0IEkgdGhpbmsgd2Ugd2FudCB0byBhY2NvdW50IHNvbWVob3cgcGVyaW9kcyB3aGVyZQo+ID4g PiBkaXNwbGF5IGlzIG5vdCB1cGRhdGVkLgo+ID4gPgo+ID4gPiBmd2l3LCBpdCBpc24ndCB0aGF0 IHVuY29tbW9uIGZvciB1c2Vyc3BhY2UgdG8gdXNlIHZibGFua3MgdG8gImtlZXAKPiA+ID4gdGlt ZSIgKGRyaXZlIGFuaW1hdGlvbnMgZm9yIGRlc2t0b3Agc3dpdGNoLCB3aW5kb3cKPiA+ID4gbWF4 aW1pemUvdW5tYXhpbWl6ZSwgZXRjKS4uIGl0IGNvdWxkIGJlIGEgc3VycHJpc2Ugd2hlbiAidmJs YW5rIiBpcwo+ID4gPiBub3QgcGVyaW9kaWMuCj4gPgo+ID4gV2hhdCBkbyB5b3UgdGhpbmsgYWJv dXQgdXNpbmcgc29tZSB2YXJpYXRpb24gb2YgdGhlIGN1cnJlbnQgdmFsdWUgb2YKPiA+IGppZmZp ZXMgaW4gdGhlIGtlcm5lbCArIHRoZSBudW1iZXIgb2YgcHBfZG9uZSBJUlFzIGFzIHRoZSBzb2Z0 d2FyZQo+ID4gY291bnRlciBmb3IgY29tbWFuZC1tb2RlIHBhbmVscz8KPiA+Cj4KPiBqaWZmaWVz IGlzIHByb2JhYmx5IHRvbyBjb2Fyc2UuLiBidXQgd2UgY291bGQgdXNlIG1vbm90b25pYyBjbG9j aywgSSBndWVzcy4KPgo+IEJ1dCBJIHN1cHBvc2UgZXZlbiBhIGNtZCBtb2RlIHBhbmVsIGhhcyBh ICJ2YmxhbmsiLCBpdCBpcyBqdXN0Cj4gaW50ZXJuYWwgdGhlIHBhbmVsLiAgRG8gd2UgZ2V0IHRo ZSBURSBpbnRlcnJ1cHQgYXQgcmVndWxhciBpbnRlcnZhbHM/Cj4gQUZBSVUgdGhpcyB3b3VsZCBi ZSB0aWVkIHRvIHRoZSBwYW5lbCdzIGludGVybmFsIHZibGFuay4KClRoZSBURSBpbnRlcnJ1cHQg d2FzIGZpcnN0IGltcGxlbWVudGVkIGluIE1EUCAxLjcuMCAobXNtODk5NikuICA4OTc0CnByZWRh dGVzIHRoYXQuCllvdSBjYW4gZ2V0IGl0IGZyb20gdGhlIFdSX1BUUiBpbnRlcnJ1cHQsIGJ1dCB5 b3UgaGF2ZSB0byB1bmRlcnN0YW5kCmRldGFpbHMgYWJvdXQgeW91ciBwYW5lbCB0byBjb25maWd1 cmUgdGhhdCBjb3JyZWN0bHkuCgo+Cj4gQlIsCj4gLVIKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVs