From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=3.0 tests=DATE_IN_PAST_03_06,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A8FBC5B57D for ; Wed, 3 Jul 2019 00:34:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1062320673 for ; Wed, 3 Jul 2019 00:34:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cHbuCUvN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727080AbfGCAeg (ORCPT ); Tue, 2 Jul 2019 20:34:36 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:40599 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726736AbfGCAeg (ORCPT ); Tue, 2 Jul 2019 20:34:36 -0400 Received: by mail-io1-f67.google.com with SMTP id n5so676221ioc.7; Tue, 02 Jul 2019 17:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I1EqOkAJ16JrzJYbRJsKM2M5z/cziA7sysWiFBw1wCQ=; b=cHbuCUvN+s8Lxw2Gyg3gi4DFYo+F4B8Y2Kkpc1I2sZAekDpolXvsjxL2vCLw+zBEqh XqJBFdv4ZmCJk7ExnlSoa231CpUFJrcpmHzSb6QDviDzMXT80sTIefoueo7dajOTdTbi aSPGfyYr4g1yfJTGDte3QRKpLEKt1aqtYlMj+ltHYK9bVYthpd6JxS8HV8gAdXOBjeLa uTskqhloZdHDc8VdGHBGGTqQcEBxsoj4u5Nv/wU43dV0lo6VBVMpKiI5X6sDz/w7Ybgg oCN/1Oo3aDlnsbAFjFi5ldNCfMPtrnA2qTcQ7ew+gfk4C/znPwGU2nex1jNx62tD5fmB J9iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I1EqOkAJ16JrzJYbRJsKM2M5z/cziA7sysWiFBw1wCQ=; b=SU6OceEQM4IhouTK4HKhjslxEWRHAF1qrvr9w3/5SGMIxSnF2UgxRlu3d8lj6qq8dB OgyiuRS+k11Poq7aDnyVCoQm9OkdvVfVWfgJOGXlbXjUiChdxbrBgikkIMOU/Qu029aJ a9ACX3jr46sS/sGYlZWE+YNNzJ5e7+yqQGbgc34Urk7tftd8GziorjFH3ESdyeuX14M4 +d8D2C5hPW5kc+0/ZT6/aNp+4O+pDcv8ifxFcmke/Td6GFS87518EUHBidWHHoA+JHDN Z3LDnEhMsy+wpl9/bldazeM9790vfNcfsRDGqo5vmnQYZ6xcokboCoYzn6tileD7QyNc RGPA== X-Gm-Message-State: APjAAAVn2NugxIQlKqr6V4ApAi4P5+DMqebtDhd+HEDV2pQcbOzOlHtG CCL2D9D0iHNMMnYOQZOLM2p/al1yJimGaC4vnNEPyA== X-Google-Smtp-Source: APXvYqz2ea1Co87gENT0Z1FYNhMJZ2SZm3RqcDFrMzN+sTpYjy5Oh6gRJ+UNd2Qx/1ivh+Y0WvJG4xn2CxoR0RmeRwA= X-Received: by 2002:a02:ac09:: with SMTP id a9mr39228087jao.48.1562102997246; Tue, 02 Jul 2019 14:29:57 -0700 (PDT) MIME-Version: 1.0 References: <20190630131445.25712-1-robdclark@gmail.com> <20190630131445.25712-4-robdclark@gmail.com> In-Reply-To: From: Jeffrey Hugo Date: Tue, 2 Jul 2019 15:29:47 -0600 Message-ID: Subject: Re: [Freedreno] [PATCH 3/3] drm/msm/dsi: make sure we have panel or bridge earlier To: Rob Clark Cc: "open list:DRM PANEL DRIVERS" , Rob Clark , David Airlie , MSM , Jordan Crouse , Abhinav Kumar , lkml , Sean Paul , Sibi Sankar , Daniel Vetter , freedreno , Chandan Uddaraju Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jul 2, 2019 at 2:30 PM Jeffrey Hugo wrote: > > On Sun, Jun 30, 2019 at 7:16 AM Rob Clark wrote: > > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > > @@ -1824,6 +1824,20 @@ int msm_dsi_host_init(struct msm_dsi *msm_dsi) > > goto fail; > > } > > > > + /* > > + * Make sure we have panel or bridge early, before we start > > + * touching the hw. If bootloader enabled the display, we > > + * want to be sure to keep it running until the bridge/panel > > + * is probed and we are all ready to go. Otherwise we'll > > + * kill the display and then -EPROBE_DEFER > > + */ > > + if (IS_ERR(of_drm_find_panel(msm_host->device_node)) && > > + !of_drm_find_bridge(msm_host->device_node)) { > > + pr_err("%s: no panel or bridge yet\n", __func__); > > pr_err() doesn't seem right for a probe defer condition. pr_dbg? > > > + return -EPROBE_DEFER; > > + } > > + > > + > > Tested-by: Jeffrey Hugo > Reviewed-by: Jeffrey Hugo Actually, I'm sorry, I'm now NACKing this. Turns out this prevents the panel/bridge from ever probing if its a child node of the dsi device, since mipi_dsi_host_register() is never called. This probably works for you on the c630 because the bridge hangs off the i2c bus. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeffrey Hugo Subject: Re: [PATCH 3/3] drm/msm/dsi: make sure we have panel or bridge earlier Date: Tue, 2 Jul 2019 15:29:47 -0600 Message-ID: References: <20190630131445.25712-1-robdclark@gmail.com> <20190630131445.25712-4-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Rob Clark Cc: Rob Clark , freedreno , David Airlie , MSM , lkml , Abhinav Kumar , Jordan Crouse , "open list:DRM PANEL DRIVERS" , Daniel Vetter , Sean Paul , Chandan Uddaraju , Sibi Sankar List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdWwgMiwgMjAxOSBhdCAyOjMwIFBNIEplZmZyZXkgSHVnbyA8amVmZnJleS5sLmh1 Z29AZ21haWwuY29tPiB3cm90ZToKPgo+IE9uIFN1biwgSnVuIDMwLCAyMDE5IGF0IDc6MTYgQU0g Um9iIENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29tPiB3cm90ZToKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9tc20vZHNpL2RzaV9ob3N0LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20v ZHNpL2RzaV9ob3N0LmMKPiA+IEBAIC0xODI0LDYgKzE4MjQsMjAgQEAgaW50IG1zbV9kc2lfaG9z dF9pbml0KHN0cnVjdCBtc21fZHNpICptc21fZHNpKQo+ID4gICAgICAgICAgICAgICAgIGdvdG8g ZmFpbDsKPiA+ICAgICAgICAgfQo+ID4KPiA+ICsgICAgICAgLyoKPiA+ICsgICAgICAgICogTWFr ZSBzdXJlIHdlIGhhdmUgcGFuZWwgb3IgYnJpZGdlIGVhcmx5LCBiZWZvcmUgd2Ugc3RhcnQKPiA+ ICsgICAgICAgICogdG91Y2hpbmcgdGhlIGh3LiAgSWYgYm9vdGxvYWRlciBlbmFibGVkIHRoZSBk aXNwbGF5LCB3ZQo+ID4gKyAgICAgICAgKiB3YW50IHRvIGJlIHN1cmUgdG8ga2VlcCBpdCBydW5u aW5nIHVudGlsIHRoZSBicmlkZ2UvcGFuZWwKPiA+ICsgICAgICAgICogaXMgcHJvYmVkIGFuZCB3 ZSBhcmUgYWxsIHJlYWR5IHRvIGdvLiAgT3RoZXJ3aXNlIHdlJ2xsCj4gPiArICAgICAgICAqIGtp bGwgdGhlIGRpc3BsYXkgYW5kIHRoZW4gLUVQUk9CRV9ERUZFUgo+ID4gKyAgICAgICAgKi8KPiA+ ICsgICAgICAgaWYgKElTX0VSUihvZl9kcm1fZmluZF9wYW5lbChtc21faG9zdC0+ZGV2aWNlX25v ZGUpKSAmJgo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgIW9mX2RybV9maW5kX2JyaWRnZSht c21faG9zdC0+ZGV2aWNlX25vZGUpKSB7Cj4gPiArICAgICAgICAgICAgICAgcHJfZXJyKCIlczog bm8gcGFuZWwgb3IgYnJpZGdlIHlldFxuIiwgX19mdW5jX18pOwo+Cj4gcHJfZXJyKCkgZG9lc24n dCBzZWVtIHJpZ2h0IGZvciBhIHByb2JlIGRlZmVyIGNvbmRpdGlvbi4gIHByX2RiZz8KPgo+ID4g KyAgICAgICAgICAgICAgIHJldHVybiAtRVBST0JFX0RFRkVSOwo+ID4gKyAgICAgICB9Cj4gPiAr Cj4gPiArCj4KPiBUZXN0ZWQtYnk6IEplZmZyZXkgSHVnbyA8amVmZnJleS5sLmh1Z29AZ21haWwu Y29tPgo+IFJldmlld2VkLWJ5OiBKZWZmcmV5IEh1Z28gPGplZmZyZXkubC5odWdvQGdtYWlsLmNv bT4KCkFjdHVhbGx5LCBJJ20gc29ycnksIEknbSBub3cgTkFDS2luZyB0aGlzLgoKVHVybnMgb3V0 IHRoaXMgcHJldmVudHMgdGhlIHBhbmVsL2JyaWRnZSBmcm9tIGV2ZXIgcHJvYmluZyBpZiBpdHMg YQpjaGlsZCBub2RlIG9mIHRoZSBkc2kgZGV2aWNlLCBzaW5jZSBtaXBpX2RzaV9ob3N0X3JlZ2lz dGVyKCkgaXMgbmV2ZXIKY2FsbGVkLgoKVGhpcyBwcm9iYWJseSB3b3JrcyBmb3IgeW91IG9uIHRo ZSBjNjMwIGJlY2F1c2UgdGhlIGJyaWRnZSBoYW5ncyBvZmYKdGhlIGkyYyBidXMuCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkZyZWVkcmVubyBtYWlsaW5n IGxpc3QKRnJlZWRyZW5vQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVubw==