From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932738AbbLHFTt (ORCPT ); Tue, 8 Dec 2015 00:19:49 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38369 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175AbbLHFTr (ORCPT ); Tue, 8 Dec 2015 00:19:47 -0500 MIME-Version: 1.0 In-Reply-To: References: <1449107584-3192-1-git-send-email-jwerner@chromium.org> <5664E1CF.8030406@rock-chips.com> <5664F837.607@rock-chips.com> Date: Mon, 7 Dec 2015 21:19:46 -0800 X-Google-Sender-Auth: -RHsaH1d71Lx91X5WpSKkEqXj6c Message-ID: Subject: Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st From: Julius Werner To: Julius Werner Cc: Doug Anderson , Chris Zhong , Andrew Morton , Alessandro Zummo , Sonny Rao , Heiko Stuebner , "linux-kernel@vger.kernel.org" , rtc-linux@googlegroups.com, Alexandre Belloni Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Still, you're right that adding the GET_TIME check wouldn't hurt... at > worst it just does nothing. I'll try it out. Hmm... so it basically works (when you hack the RTC read out of the firmware), but only on reboot for some reason (which makes it way less useful). After a full power off I'm reading only zeroes out until I transition GET_TIME again. My guess would be that these shadow registers are not in the RTC power well... I've talked to Alex and he said that we disable the RK808's main power source in S5, but that devices without an EC (e.g. phones) would likely leave it on. So I guess it's still a good extra workaround to keep in the code, but it will never help on Chromebooks (and there's no point in hacking up our firmware for it). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com. [2a00:1450:400c:c09::22b]) by gmr-mx.google.com with ESMTPS id i77si46753wmf.1.2015.12.07.21.19.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Dec 2015 21:19:46 -0800 (PST) Received: by mail-wm0-x22b.google.com with SMTP id v187so197208405wmv.1 for ; Mon, 07 Dec 2015 21:19:46 -0800 (PST) MIME-Version: 1.0 Sender: rtc-linux@googlegroups.com In-Reply-To: References: <1449107584-3192-1-git-send-email-jwerner@chromium.org> <5664E1CF.8030406@rock-chips.com> <5664F837.607@rock-chips.com> Date: Mon, 7 Dec 2015 21:19:46 -0800 Message-ID: Subject: [rtc-linux] Re: [PATCH] RTC: RK808: Work around hardware bug on November 31st From: Julius Werner To: Julius Werner Cc: Doug Anderson , Chris Zhong , Andrew Morton , Alessandro Zummo , Sonny Rao , Heiko Stuebner , "linux-kernel@vger.kernel.org" , rtc-linux@googlegroups.com, Alexandre Belloni Content-Type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , > Still, you're right that adding the GET_TIME check wouldn't hurt... at > worst it just does nothing. I'll try it out. Hmm... so it basically works (when you hack the RTC read out of the firmware), but only on reboot for some reason (which makes it way less useful). After a full power off I'm reading only zeroes out until I transition GET_TIME again. My guess would be that these shadow registers are not in the RTC power well... I've talked to Alex and he said that we disable the RK808's main power source in S5, but that devices without an EC (e.g. phones) would likely leave it on. So I guess it's still a good extra workaround to keep in the code, but it will never help on Chromebooks (and there's no point in hacking up our firmware for it). -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.