From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Stratiienko Date: Mon, 20 May 2019 17:12:58 +0300 Subject: [U-Boot] [PATCH v3 1/7] cmd: part: Add 'number' sub-command In-Reply-To: References: <1550506917-25547-1-git-send-email-igor.opaniuk@linaro.org> <1550506917-25547-2-git-send-email-igor.opaniuk@linaro.org> <20190310224154.GA25918@x230> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de Are there any updates of this patch? We need this functionality to retrieve UUID of the partition using it's nam= e. But there are lot of commands that supports only partition index as an argument, so I assume it could be very useful there. This command can be also used alone can be used to find root partition, e.g= .: gpt index mmc 0 system system_index setenv bootargs=3D"... root=3D/dev/mmcblk0p$system_index" On Mon, May 20, 2019 at 4:27 PM Igor Opaniuk wrote: > > + Roman > > > On Thu, Mar 21, 2019 at 5:42 PM Igor Opaniuk wro= te: > > > > Hi Eugeniu, > > > > > > On Mon, Mar 11, 2019 at 12:42 AM Eugeniu Rosca = wrote: > > > > > > > > > Hi Igor, > > > > > > On Mon, Feb 18, 2019 at 06:21:51PM +0200, Igor Opaniuk wrote: > > > > From: Ruslan Trofymenko > > > > > > > > This sub-command serves for getting the partition index from > > > > partition name. > > > > > > [..] > > > > > > > CMD_PART_INFO_SIZE, > > > > + CMD_PART_INFO_NUMBER > > > > > > IMHO 's/number/index/' (when referring to the id of a partition) would > > > make code and documentation more clear since 'number' can be confused > > > with 'count' while 'index' is unequivocal. > > > > > > Feel free to ignore it though, as the terms seem to be intermixed in > > > various places of Linux/U-Boot (my opinion still stands). > > > > Agree, will be fixed in v4. > > > > > The review comment also applies to other patches from this series: > > > - https://patchwork.ozlabs.org/patch/1044153/ ("[U-Boot,v3,2/7] disk: > > > part: Extend API to get partition info") > > > - https://patchwork.ozlabs.org/patch/1044162/ ("[U-Boot,v3,6/7] doc: > > > android: Add simple guide for A/B updates") > > > - https://patchwork.ozlabs.org/patch/1044160/ ("[U-Boot,v3,7/7] env: > > > am57xx: Implement A/B boot process") > > > > > > Best regards, > > > Eugeniu. > > > _______________________________________________ > > > U-Boot mailing list > > > U-Boot at lists.denx.de > > > https://lists.denx.de/listinfo/u-boot > > > > -- > Best regards - Freundliche Gr=C3=BCsse - Meilleures salutations > > Igor Opaniuk > > mailto: igor.opaniuk at gmail.com > skype: igor.opanyuk > +380 (93) 836 40 67 > http://ua.linkedin.com/in/iopaniuk --=20 Best regards, Roman Stratiienko Global Logic ADIT Team