From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15208C433B4 for ; Tue, 11 May 2021 08:34:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE24A61184 for ; Tue, 11 May 2021 08:34:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230464AbhEKIfX (ORCPT ); Tue, 11 May 2021 04:35:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230316AbhEKIfU (ORCPT ); Tue, 11 May 2021 04:35:20 -0400 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 696F9C061574 for ; Tue, 11 May 2021 01:34:12 -0700 (PDT) Received: by mail-ot1-x336.google.com with SMTP id u25-20020a0568302319b02902ac3d54c25eso16887739ote.1 for ; Tue, 11 May 2021 01:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wgdPV/AcewZdrV8IdLTwGyLrFumxsFWQvFFQfDf0wVQ=; b=0ZapcwACbS75HaNUVIMJA2nF3TdzK7yHK93AEsDFWQj8EPz+9cmwgw80lvA1lgAEcQ uz/w0p69/JLKKlrFul/W9WeNdp8+jOwBZg2fofcQkFW61UPtzJvJ6gvbq69u/kBAquis kkgdUMlLxWCwi3BvPFR7IUQn9zq0xmg0bVmILplyvwK/wfPbwPqlmjJeWI9Eko1doGGi FQWXi7kHsmCKdsmfuA+BBVIHnQXevwiPUdnh+rcK2HqBBC387AtQ519eZkHJ0SsnceXB Yd3siNFoRrVgjmFLca5F43CEhd/Qe8uE1M9/C1PkehqGJTLCCUm2OQX0W3w6auokH3Nm CFxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wgdPV/AcewZdrV8IdLTwGyLrFumxsFWQvFFQfDf0wVQ=; b=RfvMUGBYaJ6VYyzf9cQEs9BXXORPyn+5vKzzSdPHNd/pC5nlAzbH3DazhDv54eN1Y5 f1OlcUmOZ45IbTa6bfwNpM5q4rQg1WArIQpomESWEBX4hGC/Jy2cgFYpSujZoQY5IFf4 vA1pZxNF4jpJViSWJ0RsQrXhxYKmh894+hGjS5VX9VqzyfKztQhKIbNQ19F7D9CPKJLL 2/x9CXaW/9phTRualQ3n2VH1IskIBJzxe5tZxWgW2McRZdSVvCZwjaXAwxvhajLG/OeD TEzwn5f1o+XcVzt3Qezf0z0WAWZUVmG/5Ebsn0u5ijsUK73pX50+Z5q+BPXe/f+heN+P +veQ== X-Gm-Message-State: AOAM533XfyZsFBl8ZAyu3iDohzI8M5tygHu0rfV+jj7dXD/g5w9EZqZX zmbSNO+P+8OAz+8cFJVs/tG0S9rU6veqi/Fev+Uujw== X-Google-Smtp-Source: ABdhPJzVt5nVC9XjXq5gIom64lU88TpjNEqpB89DApWc6nOZvte02Xy9S4mlekR3eFeF5u5HlWWwHuHrS+XxZjZHixU= X-Received: by 2002:a05:6830:4103:: with SMTP id w3mr20719290ott.27.1620722051869; Tue, 11 May 2021 01:34:11 -0700 (PDT) MIME-Version: 1.0 References: <20210511044253.469034-1-yuri.benditovich@daynix.com> <20210511044253.469034-5-yuri.benditovich@daynix.com> In-Reply-To: From: Yuri Benditovich Date: Tue, 11 May 2021 11:33:59 +0300 Message-ID: Subject: Re: [PATCH 4/4] tun: indicate support for USO feature To: Jason Wang Cc: "David S. Miller" , Jakub Kicinski , "Michael S . Tsirkin" , Network Development , LKML , virtualization@lists.linux-foundation.org, Yan Vugenfirer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11, 2021 at 9:50 AM Jason Wang wrote: > > > =E5=9C=A8 2021/5/11 =E4=B8=8B=E5=8D=8812:42, Yuri Benditovich =E5=86=99= =E9=81=93: > > Signed-off-by: Yuri Benditovich > > --- > > drivers/net/tun.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > > index 84f832806313..a35054f9d941 100644 > > --- a/drivers/net/tun.c > > +++ b/drivers/net/tun.c > > @@ -2812,7 +2812,7 @@ static int set_offload(struct tun_struct *tun, un= signed long arg) > > arg &=3D ~(TUN_F_TSO4|TUN_F_TSO6); > > } > > > > - arg &=3D ~TUN_F_UFO; > > + arg &=3D ~(TUN_F_UFO|TUN_F_USO); > > > It looks to me kernel doesn't use "USO", so TUN_F_UDP_GSO_L4 is a better > name for this No problem, I can change it in v2 and I guess we should toggle NETIF_F_UDP_GSO_l4 here? No, we do not, because this indicates only the fact that the guest can send large UDP packets and have them splitted to UDP segments. > > And how about macvtap? We will check how to do that for macvtap. We will send a separate patch for macvtap or ask for advice. > > Thanks > > > > } > > > > /* This gives the user a way to test for new features in future b= y > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2837FC433B4 for ; Tue, 11 May 2021 08:34:21 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BA55613AF for ; Tue, 11 May 2021 08:34:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BA55613AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 28E944040D; Tue, 11 May 2021 08:34:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nhOHVcyUqa7N; Tue, 11 May 2021 08:34:19 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTP id 7F77040389; Tue, 11 May 2021 08:34:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 57C8FC000D; Tue, 11 May 2021 08:34:18 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id CEBDDC0001 for ; Tue, 11 May 2021 08:34:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BC6124038C for ; Tue, 11 May 2021 08:34:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JBgtmCp-ocnS for ; Tue, 11 May 2021 08:34:13 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by smtp4.osuosl.org (Postfix) with ESMTPS id D937A40389 for ; Tue, 11 May 2021 08:34:12 +0000 (UTC) Received: by mail-ot1-x330.google.com with SMTP id n32-20020a9d1ea30000b02902a53d6ad4bdso16847502otn.3 for ; Tue, 11 May 2021 01:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=wgdPV/AcewZdrV8IdLTwGyLrFumxsFWQvFFQfDf0wVQ=; b=0ZapcwACbS75HaNUVIMJA2nF3TdzK7yHK93AEsDFWQj8EPz+9cmwgw80lvA1lgAEcQ uz/w0p69/JLKKlrFul/W9WeNdp8+jOwBZg2fofcQkFW61UPtzJvJ6gvbq69u/kBAquis kkgdUMlLxWCwi3BvPFR7IUQn9zq0xmg0bVmILplyvwK/wfPbwPqlmjJeWI9Eko1doGGi FQWXi7kHsmCKdsmfuA+BBVIHnQXevwiPUdnh+rcK2HqBBC387AtQ519eZkHJ0SsnceXB Yd3siNFoRrVgjmFLca5F43CEhd/Qe8uE1M9/C1PkehqGJTLCCUm2OQX0W3w6auokH3Nm CFxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wgdPV/AcewZdrV8IdLTwGyLrFumxsFWQvFFQfDf0wVQ=; b=fDXBONVK3ILW1tte7uVR0PKGZz+TlOnFMfMhlSmIeKtJUCErcogXyykotPs+cTTHbL vokPksSMNMsMAPRZ6a7UW38UOQ8unvrmK4DBr61UnLERB7DQZfkeuEnMeFUss9Y2qr56 uUpQK1qVi+fkaj5yswobiE5fdAD17b2uP6J7/S2w9mlVFqtGaGKpVEqrURDFcIJrM4tJ Iu9wSAHvH70BVtDdsjt3FwRwKV/J0nwVfDxU3rWZnM0VZW0xcYDK2q7xKsawH3eU6oMa MLpZ9+8AwQGJNauAWMR8HhW7CbmblhlTKt0lz8CLp9tWgESvrXaytua97Cq5E+IRtk08 iNdA== X-Gm-Message-State: AOAM5331CsxVe6+Z1leyMSxcJX6hWQtpMZefPuwytIAWDMn1DT15jCuH arsiuww7j6qSd3ESzS1VbMoSIJqb6Pz6XBpuBJyL0Q== X-Google-Smtp-Source: ABdhPJzVt5nVC9XjXq5gIom64lU88TpjNEqpB89DApWc6nOZvte02Xy9S4mlekR3eFeF5u5HlWWwHuHrS+XxZjZHixU= X-Received: by 2002:a05:6830:4103:: with SMTP id w3mr20719290ott.27.1620722051869; Tue, 11 May 2021 01:34:11 -0700 (PDT) MIME-Version: 1.0 References: <20210511044253.469034-1-yuri.benditovich@daynix.com> <20210511044253.469034-5-yuri.benditovich@daynix.com> In-Reply-To: From: Yuri Benditovich Date: Tue, 11 May 2021 11:33:59 +0300 Message-ID: Subject: Re: [PATCH 4/4] tun: indicate support for USO feature To: Jason Wang Cc: "Michael S . Tsirkin" , Network Development , LKML , virtualization@lists.linux-foundation.org, Yan Vugenfirer , Jakub Kicinski , "David S. Miller" X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gVHVlLCBNYXkgMTEsIDIwMjEgYXQgOTo1MCBBTSBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRo YXQuY29tPiB3cm90ZToKPgo+Cj4g5ZyoIDIwMjEvNS8xMSDkuIvljYgxMjo0MiwgWXVyaSBCZW5k aXRvdmljaCDlhpnpgZM6Cj4gPiBTaWduZWQtb2ZmLWJ5OiBZdXJpIEJlbmRpdG92aWNoIDx5dXJp LmJlbmRpdG92aWNoQGRheW5peC5jb20+Cj4gPiAtLS0KPiA+ICAgZHJpdmVycy9uZXQvdHVuLmMg fCAyICstCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt KQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC90dW4uYyBiL2RyaXZlcnMvbmV0L3R1 bi5jCj4gPiBpbmRleCA4NGY4MzI4MDYzMTMuLmEzNTA1NGY5ZDk0MSAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvbmV0L3R1bi5jCj4gPiArKysgYi9kcml2ZXJzL25ldC90dW4uYwo+ID4gQEAgLTI4 MTIsNyArMjgxMiw3IEBAIHN0YXRpYyBpbnQgc2V0X29mZmxvYWQoc3RydWN0IHR1bl9zdHJ1Y3Qg KnR1biwgdW5zaWduZWQgbG9uZyBhcmcpCj4gPiAgICAgICAgICAgICAgICAgICAgICAgYXJnICY9 IH4oVFVOX0ZfVFNPNHxUVU5fRl9UU082KTsKPiA+ICAgICAgICAgICAgICAgfQo+ID4KPiA+IC0g ICAgICAgICAgICAgYXJnICY9IH5UVU5fRl9VRk87Cj4gPiArICAgICAgICAgICAgIGFyZyAmPSB+ KFRVTl9GX1VGT3xUVU5fRl9VU08pOwo+Cj4KPiBJdCBsb29rcyB0byBtZSBrZXJuZWwgZG9lc24n dCB1c2UgIlVTTyIsIHNvIFRVTl9GX1VEUF9HU09fTDQgaXMgYSBiZXR0ZXIKPiBuYW1lIGZvciB0 aGlzCgpObyBwcm9ibGVtLCBJIGNhbiBjaGFuZ2UgaXQgaW4gdjIKCiBhbmQgSSBndWVzcyB3ZSBz aG91bGQgdG9nZ2xlIE5FVElGX0ZfVURQX0dTT19sNCBoZXJlPwoKTm8sIHdlIGRvIG5vdCwgYmVj YXVzZSB0aGlzIGluZGljYXRlcyBvbmx5IHRoZSBmYWN0IHRoYXQgdGhlIGd1ZXN0IGNhbgpzZW5k IGxhcmdlIFVEUCBwYWNrZXRzIGFuZCBoYXZlIHRoZW0gc3BsaXR0ZWQgdG8gVURQIHNlZ21lbnRz LgoKPgo+IEFuZCBob3cgYWJvdXQgbWFjdnRhcD8KCldlIHdpbGwgY2hlY2sgaG93IHRvIGRvIHRo YXQgZm9yIG1hY3Z0YXAuIFdlIHdpbGwgc2VuZCBhIHNlcGFyYXRlCnBhdGNoIGZvciBtYWN2dGFw IG9yIGFzayBmb3IgYWR2aWNlLgoKPgo+IFRoYW5rcwo+Cj4KPiA+ICAgICAgIH0KPiA+Cj4gPiAg ICAgICAvKiBUaGlzIGdpdmVzIHRoZSB1c2VyIGEgd2F5IHRvIHRlc3QgZm9yIG5ldyBmZWF0dXJl cyBpbiBmdXR1cmUgYnkKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMu bGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21h aWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24=