From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F3A1C433ED for ; Thu, 29 Apr 2021 16:02:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3E626143E for ; Thu, 29 Apr 2021 16:02:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3E626143E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jlekstrand.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 27BB68970E; Thu, 29 Apr 2021 16:02:42 +0000 (UTC) Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by gabe.freedesktop.org (Postfix) with ESMTPS id CA69489624 for ; Thu, 29 Apr 2021 16:02:40 +0000 (UTC) Received: by mail-ej1-x62d.google.com with SMTP id l4so100615295ejc.10 for ; Thu, 29 Apr 2021 09:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jlekstrand-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SduHEnNrhcuXlfiuazV/waX2yz5XQePHJm5fB0OI2FY=; b=O6h2V0uQhs/Fj5ZO3S2aD6JEbP3/G0HRmK2qVjlKVHomhJEA4nlmHKDMLYVqCsxDuM 7zhhQw45QXCUoODcSgCkeD0PH27zBOKvNOkTMgq5uU4OnBCOXSqljgBypNMQYpJVjcn2 FHKMUVZnWd9BAhqliPHy5L46BAaAbQgIG/o+VV5DOyidkebWZRk1c7Edqlningqf2ZtJ uTrJp49M1ry1pwGMbQmWgGox3LdNR027iqe6CdmDZgQVpRHHYN8CM4GhhJdrt0qOUvMT UsRR0DY+E0EtIowHDXR+X7h+VkWw5UBQwZj+8UliV91QgPXagR8rcBL70D8C1CWWMmnw dhUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SduHEnNrhcuXlfiuazV/waX2yz5XQePHJm5fB0OI2FY=; b=QqtEFFaF7cJNxr81ad2SbBukUXiIKqeFTvJW14fwlvIye3FYx3exVDH9J+sVOvt1nr vctmxn/ViOmDnpCETdMKvudWS6WLkOor0QcTZTGRCvz0ONPG+4u7k3R8NHKC6SXXqYAM 9FcUeIoHuwPTQmO5N6Kx0TH/pfSHrkKtkyyD9N86iw+vAfdGqrFueIxGmncYnOUPd+qw tJbKOlEwWzZrZdu/paB0r2w8U3TQjW2+sUljijQWxKmWKoGmCEnq0mSRtnIJ+37b0kTB lgPkVZkvFGdyhZ2BkltEOvqygWC1ZawJ3NkY20C4FDysAetszYzkI/mbECusewO13oqK 1IIg== X-Gm-Message-State: AOAM532Si/eHNIK5pxqOxuGMOdLOnUEMLPKpU8ZkUbJVqVlks5m6/9WR cz187RbiVL789UIM2uqsLGB4LHx8EtL5Sfs0jbVevg== X-Google-Smtp-Source: ABdhPJxZyPluV9CMk+j6pqHaFtLXw3iZC58yThmoUxW9gP3FoRI3BM1zLztkxgUmg+xg1D5SlL85QJ0XnKqvDuiBH7Q= X-Received: by 2002:a17:906:f1cf:: with SMTP id gx15mr536137ejb.435.1619712159373; Thu, 29 Apr 2021 09:02:39 -0700 (PDT) MIME-Version: 1.0 References: <20210423223131.879208-1-jason@jlekstrand.net> <20210423223131.879208-9-jason@jlekstrand.net> In-Reply-To: From: Jason Ekstrand Date: Thu, 29 Apr 2021 11:02:27 -0500 Message-ID: Subject: Re: [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines To: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Brost , Intel GFX , Maling list - DRI developers Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Apr 29, 2021 at 7:16 AM Daniel Vetter wrote: > > On Wed, Apr 28, 2021 at 01:58:17PM -0500, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 12:18 PM Jason Ekstrand wrote: > > > > > > On Wed, Apr 28, 2021 at 5:13 AM Daniel Vetter wrote: > > > > > > > > On Tue, Apr 27, 2021 at 08:51:08AM -0500, Jason Ekstrand wrote: > > > > > I sent a v2 of this patch because it turns out I deleted a bit too > > > > > much code. This function in particular, has to stay, unfortunately. > > > > > When a batch is submitted with a SUBMIT_FENCE, this is used to push > > > > > the work onto a different engine than than the one it's supposed to > > > > > run in parallel with. This means we can't dead-code this function or > > > > > the bond_execution function pointer and related stuff. > > > > > > > > Uh that's disappointing, since if I understand your point correctly, the > > > > sibling engines should all be singletons, not load balancing virtual ones. > > > > So there really should not be any need to pick the right one at execution > > > > time. > > > > > > The media driver itself seems to work fine if I delete all the code. > > > It's just an IGT testcase that blows up. I'll do more digging to see > > > if I can better isolate why. > > > > I did more digging and I figured out why this test hangs. The test > > looks at an engine class where there's more than one of that class > > (currently only vcs) and creates a context where engine[0] is all of > > the engines of that class bonded together and engine[1-N] is each of > > those engines individually. It then tests that you can submit a batch > > to one of the individual engines and then submit with > > EXEC_FENCE_SUBMIT to the balanced engine and the kernel will sort it > > out. This doesn't seem like a use-case we care about. > > > > If we cared about anything, I would expect it to be submitting to two > > balanced contexts and expecting "pick any two" behavior. But that's > > not what the test is testing for. > > Yeah ditch it. > > Instead make sure that the bonded setparam/ctx validation makes sure that > 1) no virtual engines are used > 2) no engine used twice > 3) anything else stupid you can come up with that we should make sure is > blocked. I've re-introduced the deletion and I'll add nuking that test to my IGT series. I did it as a separate patch as the FENCE_SUBMIT logic and the bonding are somewhat separate concerns. As far as validation goes, I don't think we need any more for this case. You used FENCE_SUBMIT and didn't properly isolate things such that the two run on different engines. Not our problem. --Jason _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B27FC433B4 for ; Thu, 29 Apr 2021 16:02:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F16C61446 for ; Thu, 29 Apr 2021 16:02:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F16C61446 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jlekstrand.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E672489624; Thu, 29 Apr 2021 16:02:41 +0000 (UTC) Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB57989739 for ; Thu, 29 Apr 2021 16:02:40 +0000 (UTC) Received: by mail-ej1-x62a.google.com with SMTP id t4so17368523ejo.0 for ; Thu, 29 Apr 2021 09:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jlekstrand-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SduHEnNrhcuXlfiuazV/waX2yz5XQePHJm5fB0OI2FY=; b=O6h2V0uQhs/Fj5ZO3S2aD6JEbP3/G0HRmK2qVjlKVHomhJEA4nlmHKDMLYVqCsxDuM 7zhhQw45QXCUoODcSgCkeD0PH27zBOKvNOkTMgq5uU4OnBCOXSqljgBypNMQYpJVjcn2 FHKMUVZnWd9BAhqliPHy5L46BAaAbQgIG/o+VV5DOyidkebWZRk1c7Edqlningqf2ZtJ uTrJp49M1ry1pwGMbQmWgGox3LdNR027iqe6CdmDZgQVpRHHYN8CM4GhhJdrt0qOUvMT UsRR0DY+E0EtIowHDXR+X7h+VkWw5UBQwZj+8UliV91QgPXagR8rcBL70D8C1CWWMmnw dhUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SduHEnNrhcuXlfiuazV/waX2yz5XQePHJm5fB0OI2FY=; b=MYL0K2RIOBtyGpSeamPAkROyou6oR9ueNF9jIvfbo5X94F0KF/Z4HiNJ5pkQ8qDoZ/ 18vWCKOMZOY4DCw8RBqDhMvxA7HQxjAn8HrnjcC9fgtJ15mmHrYYQMKewcI6FONG2GuB YYG9fe1vuX2Mo4FKIOfAV3KJY8q0LZcjOuoGZrnie+hOcElEXZtOtFZx04NCR2uqYCyk 6Cz8Tkvq7nsSi9CeQJchh+1F05uMDnD7zCoFbPs/sbeyrvtbfznKVrVaY7tfOnNrNmL0 wouh+c0FFrmdIjLQ2uL5QLwXexpkRcfZua5eDY3VbkExI9h7Bx2dSUDiYnsYhK9szLx6 /G6Q== X-Gm-Message-State: AOAM532YO240Z407vvs7g37dF5gWu6JIYn+oyYR8imCzVH4kh76mi2Dn 6WWdFqDDE8MfYo6Qnzp3gU7fam88m+T5/6KtDJ7ogduejVs= X-Google-Smtp-Source: ABdhPJxZyPluV9CMk+j6pqHaFtLXw3iZC58yThmoUxW9gP3FoRI3BM1zLztkxgUmg+xg1D5SlL85QJ0XnKqvDuiBH7Q= X-Received: by 2002:a17:906:f1cf:: with SMTP id gx15mr536137ejb.435.1619712159373; Thu, 29 Apr 2021 09:02:39 -0700 (PDT) MIME-Version: 1.0 References: <20210423223131.879208-1-jason@jlekstrand.net> <20210423223131.879208-9-jason@jlekstrand.net> In-Reply-To: From: Jason Ekstrand Date: Thu, 29 Apr 2021 11:02:27 -0500 Message-ID: To: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel GFX , Maling list - DRI developers Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Apr 29, 2021 at 7:16 AM Daniel Vetter wrote: > > On Wed, Apr 28, 2021 at 01:58:17PM -0500, Jason Ekstrand wrote: > > On Wed, Apr 28, 2021 at 12:18 PM Jason Ekstrand wrote: > > > > > > On Wed, Apr 28, 2021 at 5:13 AM Daniel Vetter wrote: > > > > > > > > On Tue, Apr 27, 2021 at 08:51:08AM -0500, Jason Ekstrand wrote: > > > > > I sent a v2 of this patch because it turns out I deleted a bit too > > > > > much code. This function in particular, has to stay, unfortunately. > > > > > When a batch is submitted with a SUBMIT_FENCE, this is used to push > > > > > the work onto a different engine than than the one it's supposed to > > > > > run in parallel with. This means we can't dead-code this function or > > > > > the bond_execution function pointer and related stuff. > > > > > > > > Uh that's disappointing, since if I understand your point correctly, the > > > > sibling engines should all be singletons, not load balancing virtual ones. > > > > So there really should not be any need to pick the right one at execution > > > > time. > > > > > > The media driver itself seems to work fine if I delete all the code. > > > It's just an IGT testcase that blows up. I'll do more digging to see > > > if I can better isolate why. > > > > I did more digging and I figured out why this test hangs. The test > > looks at an engine class where there's more than one of that class > > (currently only vcs) and creates a context where engine[0] is all of > > the engines of that class bonded together and engine[1-N] is each of > > those engines individually. It then tests that you can submit a batch > > to one of the individual engines and then submit with > > EXEC_FENCE_SUBMIT to the balanced engine and the kernel will sort it > > out. This doesn't seem like a use-case we care about. > > > > If we cared about anything, I would expect it to be submitting to two > > balanced contexts and expecting "pick any two" behavior. But that's > > not what the test is testing for. > > Yeah ditch it. > > Instead make sure that the bonded setparam/ctx validation makes sure that > 1) no virtual engines are used > 2) no engine used twice > 3) anything else stupid you can come up with that we should make sure is > blocked. I've re-introduced the deletion and I'll add nuking that test to my IGT series. I did it as a separate patch as the FENCE_SUBMIT logic and the bonding are somewhat separate concerns. As far as validation goes, I don't think we need any more for this case. You used FENCE_SUBMIT and didn't properly isolate things such that the two run on different engines. Not our problem. --Jason _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx