From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by gabe.freedesktop.org (Postfix) with ESMTPS id 66BF56EA3D for ; Fri, 18 Jun 2021 16:03:53 +0000 (UTC) Received: by mail-qk1-x731.google.com with SMTP id q190so9494286qkd.2 for ; Fri, 18 Jun 2021 09:03:53 -0700 (PDT) MIME-Version: 1.0 References: <20210617191256.577244-1-jason@jlekstrand.net> <20210617191516.577394-6-jason@jlekstrand.net> <87mtrodlb0.wl-ashutosh.dixit@intel.com> In-Reply-To: <87mtrodlb0.wl-ashutosh.dixit@intel.com> From: Jason Ekstrand Date: Fri, 18 Jun 2021 11:03:41 -0500 Message-ID: Subject: Re: [igt-dev] [PATCH i-g-t 55/79] lib/i915/submission: Rework gem_test_all_engines to use intel_ctx_t List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Dixit, Ashutosh" Cc: IGT GPU Tools List-ID: On Thu, Jun 17, 2021 at 8:16 PM Dixit, Ashutosh wrote: > > On Thu, 17 Jun 2021 12:14:52 -0700, Jason Ekstrand wrote: > > > > This function used to be called gem_test_engine but it's only ever used > > to test all the engines in the GPU so we rename it for the one thing > > it's used for. We also convert to intel_ctx_t. It now creates a new > > context with all physical engines and iterates over all the engines in > > it. > > Please add your SOB here. Done > > --- > > lib/i915/gem_submission.c | 19 ++++++++----------- > > lib/i915/gem_submission.h | 2 +- > > tests/i915/gem_eio.c | 2 +- > > tests/i915/i915_pm_rpm.c | 2 +- > > 4 files changed, 11 insertions(+), 14 deletions(-) > > > > diff --git a/lib/i915/gem_submission.c b/lib/i915/gem_submission.c > > index 7c305d6d6..bec952493 100644 > > --- a/lib/i915/gem_submission.c > > +++ b/lib/i915/gem_submission.c > > @@ -177,20 +177,23 @@ static bool is_wedged(int i915) > > } > > > > /** > > - * gem_test_engine: > > + * gem_test_all_engines: > > * @i915: open i915 drm file descriptor > > * @engine: the engine (I915_EXEC_RING id) to exercise > > Delete @engine in the docs too. Done > > * > > * Execute a nop batch on the engine specified, or ALL_ENGINES for all, > > * and check it executes. > > */ > > -void gem_test_engine(int i915, unsigned int engine) > > +void gem_test_all_engines(int i915) > > With this this is: > > Reviewed-by: Ashutosh Dixit Thanks! _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev