From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92D3EC433DB for ; Mon, 25 Jan 2021 21:40:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 495F32083E for ; Mon, 25 Jan 2021 21:40:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733022AbhAYVkl (ORCPT ); Mon, 25 Jan 2021 16:40:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733044AbhAYVkJ (ORCPT ); Mon, 25 Jan 2021 16:40:09 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61E61C061573 for ; Mon, 25 Jan 2021 13:39:28 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id l9so20178746ejx.3 for ; Mon, 25 Jan 2021 13:39:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jlekstrand-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=t9M0ITSOMveR16He0Zm7nxQPCeyzBQO582YAXWbdC2o=; b=t0oz/yLhImMScrEx2TROt6/Yj3l4nmrPWnMrhRHCnMxVDCMTlsIzNkdZ2eROmvDMrv 5vP69HxELvTiYSAVQG12RN9H75We6yVDbMFNnlh/WRORv5i1NCttzVBb9EZaLWjQGmHK gFdLbjNX6TaGRsiA8XbqMMdq4vxqnAvTfZRQfetfURkUfkHu1iKKl+Sv+MkkUNhB9VgQ XQ6QvEthiGSNOSfBlPzNXv4jLO3IXy1c/By1rKpMKaO7+p0ZhrOP7Ec73hT9G52jzYGU J3kyZ7bLTYApYSG6wDla3CvjivJ3oUKtMpuhL21VxUYq6SjJHw2dhSMkSzdW8vpXLdc+ bhxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=t9M0ITSOMveR16He0Zm7nxQPCeyzBQO582YAXWbdC2o=; b=bdlex1q93Dzgk/s58n6InAHOevANVGFRrwQTZ2D+9yKshtUK/ZG3wAhXnSwe/gzW54 1lhBJ7G+hIUSJ99PIP4Kn1Egj/X4ivPFOSS7Y4kKr4oNaePIkjwP1uMHTKdly3291Zj0 oiRh5eZ5NGweqUp6IH00p6sEzR70uKMILZSIzrhKmc6EdYJAVLl7e0RRG+UJECIFylmB iuLe4mXZyPCvEHV6KMAEtvPs7gydGZpR7vDLG+yRFFa1KkzWKH108nie8BOxfHU0y/T5 cn/fjBjgc+UqKMbte+c+XcYnpkWNEvU36hvbFM32+IEK4TC48d12Kfe/nt4Y3nO/IClz Ot0g== X-Gm-Message-State: AOAM532R2dXKQQoFigmfgNfMucHBfHiIQHMf7NHb1RDI1JYvTxdpTyZP Z5io7HbhvvKaNALcFgMD0AfkK6wNctf6C4WcyZYPk6qZQdY= X-Google-Smtp-Source: ABdhPJzrO99CGgskBefYU39omC9nnH6nw3FKnnSGsYGK8edxEXo2adNViTXnxzMLTczwgTE6VE4u7ypkvTn2T/5MSYY= X-Received: by 2002:a17:906:4893:: with SMTP id v19mr1544854ejq.454.1611610767093; Mon, 25 Jan 2021 13:39:27 -0800 (PST) MIME-Version: 1.0 References: <20201126105539.2661-1-chris@chris-wilson.co.uk> <20201126140841.1982-1-chris@chris-wilson.co.uk> <20201126155010.GD6112@intel.com> In-Reply-To: <20201126155010.GD6112@intel.com> From: Jason Ekstrand Date: Mon, 25 Jan 2021 15:39:15 -0600 Message-ID: Subject: Re: [PATCH] drm/i915/gt: Program mocs:63 for cache eviction on gen9 To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Chris Wilson , Intel GFX , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org I just pulled drm-tip with both this and "drm/i915/gt: Declare gen9 has 64 mocs entries!" and the hang persists. You really had my hopes up there.... I think we need to merge the L3$ disable patch. --Jason On Thu, Nov 26, 2020 at 9:50 AM Ville Syrj=C3=A4l=C3=A4 wrote: > > On Thu, Nov 26, 2020 at 02:08:41PM +0000, Chris Wilson wrote: > > Ville noticed that the last mocs entry is used unconditionally by the H= W > > when it performs cache evictions, and noted that while the value is not > > meant to be writable by the driver, we should program it to a reasonabl= e > > value nevertheless. > > > > As it turns out, we can change the value of mocs:63 and the value we > > were programming into it would cause hard hangs in conjunction with > > atomic operations. > > > > v2: Add details from bspec about how it is used by HW > > > > Suggested-by: Ville Syrj=C3=A4l=C3=A4 > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2707 > > Fixes: 3bbaba0ceaa2 ("drm/i915: Added Programming of the MOCS") > > Signed-off-by: Chris Wilson > > Cc: Ville Syrj=C3=A4l=C3=A4 > > Cc: Jason Ekstrand > > Cc: # v4.3+ > > --- > > drivers/gpu/drm/i915/gt/intel_mocs.c | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i91= 5/gt/intel_mocs.c > > index 254873e1646e..26cedde80476 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_mocs.c > > +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c > > @@ -131,7 +131,19 @@ static const struct drm_i915_mocs_entry skl_mocs_t= able[] =3D { > > GEN9_MOCS_ENTRIES, > > MOCS_ENTRY(I915_MOCS_CACHED, > > LE_3_WB | LE_TC_2_LLC_ELLC | LE_LRUM(3), > > - L3_3_WB) > > + L3_3_WB), > > + > > + /* > > + * mocs:63 > > + * - used by the L3 for all its evictions. > > + * Thus it is expected to allow LLC cacheability to enable cohe= rent > > + * flows to be maintained. > > + * - used to force L3 uncachable cycles. > > + * Thus it is expected to make the surce L3 uncacheable. > > "surce"? > > > + */ > > + MOCS_ENTRY(63, > > + LE_3_WB | LE_TC_1_LLC | LE_LRUM(3), > > + L3_1_UC) > > }; > > > > /* NOTE: the LE_TGT_CACHE is not used on Broxton */ > > -- > > 2.20.1 > > -- > Ville Syrj=C3=A4l=C3=A4 > Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A35AC433E0 for ; Mon, 25 Jan 2021 21:39:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F32CE22510 for ; Mon, 25 Jan 2021 21:39:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F32CE22510 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jlekstrand.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B16289B22; Mon, 25 Jan 2021 21:39:29 +0000 (UTC) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E1496E037 for ; Mon, 25 Jan 2021 21:39:28 +0000 (UTC) Received: by mail-ej1-x62c.google.com with SMTP id gx5so20154710ejb.7 for ; Mon, 25 Jan 2021 13:39:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jlekstrand-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=t9M0ITSOMveR16He0Zm7nxQPCeyzBQO582YAXWbdC2o=; b=t0oz/yLhImMScrEx2TROt6/Yj3l4nmrPWnMrhRHCnMxVDCMTlsIzNkdZ2eROmvDMrv 5vP69HxELvTiYSAVQG12RN9H75We6yVDbMFNnlh/WRORv5i1NCttzVBb9EZaLWjQGmHK gFdLbjNX6TaGRsiA8XbqMMdq4vxqnAvTfZRQfetfURkUfkHu1iKKl+Sv+MkkUNhB9VgQ XQ6QvEthiGSNOSfBlPzNXv4jLO3IXy1c/By1rKpMKaO7+p0ZhrOP7Ec73hT9G52jzYGU J3kyZ7bLTYApYSG6wDla3CvjivJ3oUKtMpuhL21VxUYq6SjJHw2dhSMkSzdW8vpXLdc+ bhxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=t9M0ITSOMveR16He0Zm7nxQPCeyzBQO582YAXWbdC2o=; b=BUYVXAXYOKMMhJ/8vZUxebkJXswkEDtZyYsIAQyO3OdbtEiA3BCpef7liGWdsa1aOV LoZ+is+PKnQUTdeJysFHUg0Umvd5VfnECWIQDUplhFpkKAWBHyKEbnpgjSOtBm9ZuuKV qcGKpjb6gTOAkfd5LQm/7oBhJvKIQ47N7C5XMYSS4FM7TKvgYyZOy7nJgGC2rk9aveEB PUwaAVnQP53iMAlsPqXSnbvFlyW9crH17row0zDl13YTfiT3HPgNdPVW0YZT+WwKS1Tu apRpFnoBXyq52h130WBk56ulO+7R8sEC4l9XVXhpSNjUXr3C8kymsRPS87CDMnijJWuQ M6cQ== X-Gm-Message-State: AOAM53195R3lCX2VBYnCYzQ6MeqgYWA1DshpfVuJUZUN64yFEJpMJUP4 swdlKmlTx/8DOoZ/15AxvZUje9FKN7IJ7dtvp3TI2Q== X-Google-Smtp-Source: ABdhPJzrO99CGgskBefYU39omC9nnH6nw3FKnnSGsYGK8edxEXo2adNViTXnxzMLTczwgTE6VE4u7ypkvTn2T/5MSYY= X-Received: by 2002:a17:906:4893:: with SMTP id v19mr1544854ejq.454.1611610767093; Mon, 25 Jan 2021 13:39:27 -0800 (PST) MIME-Version: 1.0 References: <20201126105539.2661-1-chris@chris-wilson.co.uk> <20201126140841.1982-1-chris@chris-wilson.co.uk> <20201126155010.GD6112@intel.com> In-Reply-To: <20201126155010.GD6112@intel.com> From: Jason Ekstrand Date: Mon, 25 Jan 2021 15:39:15 -0600 Message-ID: To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Program mocs:63 for cache eviction on gen9 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel GFX , stable@vger.kernel.org, Chris Wilson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" SSBqdXN0IHB1bGxlZCBkcm0tdGlwIHdpdGggYm90aCB0aGlzIGFuZCAiZHJtL2k5MTUvZ3Q6IERl Y2xhcmUgZ2VuOQpoYXMgNjQgbW9jcyBlbnRyaWVzISIgYW5kIHRoZSBoYW5nIHBlcnNpc3RzLiAg WW91IHJlYWxseSBoYWQgbXkgaG9wZXMKdXAgdGhlcmUuLi4uICBJIHRoaW5rIHdlIG5lZWQgdG8g bWVyZ2UgdGhlIEwzJCBkaXNhYmxlIHBhdGNoLgoKLS1KYXNvbgoKCk9uIFRodSwgTm92IDI2LCAy MDIwIGF0IDk6NTAgQU0gVmlsbGUgU3lyasOkbMOkCjx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4gd3JvdGU6Cj4KPiBPbiBUaHUsIE5vdiAyNiwgMjAyMCBhdCAwMjowODo0MVBNICswMDAw LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiBWaWxsZSBub3RpY2VkIHRoYXQgdGhlIGxhc3QgbW9j cyBlbnRyeSBpcyB1c2VkIHVuY29uZGl0aW9uYWxseSBieSB0aGUgSFcKPiA+IHdoZW4gaXQgcGVy Zm9ybXMgY2FjaGUgZXZpY3Rpb25zLCBhbmQgbm90ZWQgdGhhdCB3aGlsZSB0aGUgdmFsdWUgaXMg bm90Cj4gPiBtZWFudCB0byBiZSB3cml0YWJsZSBieSB0aGUgZHJpdmVyLCB3ZSBzaG91bGQgcHJv Z3JhbSBpdCB0byBhIHJlYXNvbmFibGUKPiA+IHZhbHVlIG5ldmVydGhlbGVzcy4KPiA+Cj4gPiBB cyBpdCB0dXJucyBvdXQsIHdlIGNhbiBjaGFuZ2UgdGhlIHZhbHVlIG9mIG1vY3M6NjMgYW5kIHRo ZSB2YWx1ZSB3ZQo+ID4gd2VyZSBwcm9ncmFtbWluZyBpbnRvIGl0IHdvdWxkIGNhdXNlIGhhcmQg aGFuZ3MgaW4gY29uanVuY3Rpb24gd2l0aAo+ID4gYXRvbWljIG9wZXJhdGlvbnMuCj4gPgo+ID4g djI6IEFkZCBkZXRhaWxzIGZyb20gYnNwZWMgYWJvdXQgaG93IGl0IGlzIHVzZWQgYnkgSFcKPiA+ Cj4gPiBTdWdnZXN0ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cj4gPiBDbG9zZXM6IGh0dHBzOi8vZ2l0bGFiLmZyZWVkZXNrdG9wLm9yZy9kcm0v aW50ZWwvLS9pc3N1ZXMvMjcwNwo+ID4gRml4ZXM6IDNiYmFiYTBjZWFhMiAoImRybS9pOTE1OiBB ZGRlZCBQcm9ncmFtbWluZyBvZiB0aGUgTU9DUyIpCj4gPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBX aWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+IENjOiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gQ2M6IEphc29uIEVrc3RyYW5kIDxq YXNvbkBqbGVrc3RyYW5kLm5ldD4KPiA+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2 NC4zKwo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbW9jcy5jIHwg MTQgKysrKysrKysrKysrKy0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9n dC9pbnRlbF9tb2NzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9tb2NzLmMKPiA+ IGluZGV4IDI1NDg3M2UxNjQ2ZS4uMjZjZWRkZTgwNDc2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbW9jcy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9ndC9pbnRlbF9tb2NzLmMKPiA+IEBAIC0xMzEsNyArMTMxLDE5IEBAIHN0YXRpYyBjb25z dCBzdHJ1Y3QgZHJtX2k5MTVfbW9jc19lbnRyeSBza2xfbW9jc190YWJsZVtdID0gewo+ID4gICAg ICAgR0VOOV9NT0NTX0VOVFJJRVMsCj4gPiAgICAgICBNT0NTX0VOVFJZKEk5MTVfTU9DU19DQUNI RUQsCj4gPiAgICAgICAgICAgICAgICAgIExFXzNfV0IgfCBMRV9UQ18yX0xMQ19FTExDIHwgTEVf TFJVTSgzKSwKPiA+IC0gICAgICAgICAgICAgICAgTDNfM19XQikKPiA+ICsgICAgICAgICAgICAg ICAgTDNfM19XQiksCj4gPiArCj4gPiArICAgICAvKgo+ID4gKyAgICAgICogbW9jczo2Mwo+ID4g KyAgICAgICogLSB1c2VkIGJ5IHRoZSBMMyBmb3IgYWxsIGl0cyBldmljdGlvbnMuCj4gPiArICAg ICAgKiAgIFRodXMgaXQgaXMgZXhwZWN0ZWQgdG8gYWxsb3cgTExDIGNhY2hlYWJpbGl0eSB0byBl bmFibGUgY29oZXJlbnQKPiA+ICsgICAgICAqICAgZmxvd3MgdG8gYmUgbWFpbnRhaW5lZC4KPiA+ ICsgICAgICAqIC0gdXNlZCB0byBmb3JjZSBMMyB1bmNhY2hhYmxlIGN5Y2xlcy4KPiA+ICsgICAg ICAqICAgVGh1cyBpdCBpcyBleHBlY3RlZCB0byBtYWtlIHRoZSBzdXJjZSBMMyB1bmNhY2hlYWJs ZS4KPgo+ICJzdXJjZSI/Cj4KPiA+ICsgICAgICAqLwo+ID4gKyAgICAgTU9DU19FTlRSWSg2MywK PiA+ICsgICAgICAgICAgICAgICAgTEVfM19XQiB8IExFX1RDXzFfTExDIHwgTEVfTFJVTSgzKSwK PiA+ICsgICAgICAgICAgICAgICAgTDNfMV9VQykKPiA+ICB9Owo+ID4KPiA+ICAvKiBOT1RFOiB0 aGUgTEVfVEdUX0NBQ0hFIGlzIG5vdCB1c2VkIG9uIEJyb3h0b24gKi8KPiA+IC0tCj4gPiAyLjIw LjEKPgo+IC0tCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==