From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 815A36E92F for ; Thu, 17 Jun 2021 15:59:27 +0000 (UTC) Received: by mail-yb1-xb31.google.com with SMTP id f84so9002446ybg.0 for ; Thu, 17 Jun 2021 08:59:27 -0700 (PDT) MIME-Version: 1.0 References: <20210614163704.365989-1-jason@jlekstrand.net> <20210614163902.366168-13-jason@jlekstrand.net> <87czsl2v2q.wl-ashutosh.dixit@intel.com> In-Reply-To: <87czsl2v2q.wl-ashutosh.dixit@intel.com> From: Jason Ekstrand Date: Thu, 17 Jun 2021 10:59:15 -0500 Message-ID: Subject: Re: [igt-dev] [PATCH i-g-t 62/77] tests/i915/gem_workarounds: Convert to intel_ctx_t List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Dixit, Ashutosh" Cc: IGT GPU Tools List-ID: On Wed, Jun 16, 2021 at 7:28 PM Dixit, Ashutosh wrote: > > On Mon, 14 Jun 2021 09:38:47 -0700, Jason Ekstrand wrote: > > > > Signed-off-by: Jason Ekstrand > > Just to make sure, this would have worked with the previous code too > (i.e. without this patch), correct, using .ctx_id for igt_spin_new? What > then is the reason for this patch, is it that intel_ctx_0 is preferred? A context is required for SPIN_POLL_RUN. We could, in theory, make NULL work by just subbing in intel_ctx_0() but it's nicer to be explicit when we can, IMO. --Jason > Anyway the patch is fine so: > > Reviewed-by: Ashutosh Dixit _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev