From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753815AbdLHN5A (ORCPT ); Fri, 8 Dec 2017 08:57:00 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:38826 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753380AbdLHN45 (ORCPT ); Fri, 8 Dec 2017 08:56:57 -0500 X-Google-Smtp-Source: AGs4zMblbq6QPK7QLGkGg1GRYF2t+XMsnT5VJJRgeHqet1GFyrjDNx4w4Y0sDGvb8T32Q4efgaOSg7CRVByyJsTDqAc= MIME-Version: 1.0 In-Reply-To: References: <20171207183909.16240-1-guro@fb.com> <20171207183909.16240-5-guro@fb.com> From: Philippe Ombredanne Date: Fri, 8 Dec 2017 14:56:15 +0100 Message-ID: Subject: Re: [PATCH v2 net-next 4/4] bpftool: implement cgroup bpf operations To: Roman Gushchin Cc: netdev@vger.kernel.org, Quentin Monnet , LKML , kernel-team@fb.com, ast@kernel.org, daniel@iogearbox.net, jakub.kicinski@netronome.com, kafai@fb.com, David Ahern Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 8, 2017 at 11:34 AM, Quentin Monnet wrote: > 2017-12-07 18:39 UTC+0000 ~ Roman Gushchin >> This patch adds basic cgroup bpf operations to bpftool: >> cgroup list, attach and detach commands. [...] >> --- /dev/null >> +++ b/tools/bpf/bpftool/cgroup.c >> @@ -0,0 +1,305 @@ >> +/* >> + * Copyright (C) 2017 Facebook >> + * >> + * This program is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License >> + * as published by the Free Software Foundation; either version >> + * 2 of the License, or (at your option) any later version. >> + * >> + * >> + */ >> + Roman, Have you considered using the simpler and new SPDX ids instead? e.g.: // SPDX-License-Identifier: GPL-2.0+ // Copyright (C) 2017 Facebook // Author: Roman Gushchin This would boost your code/comments ratio nicely IMHO. For reference please check Linus [1][2][3], Thomas [4] and Greg [5] comments on the topic of C++ style // comments! Jonathan also wrote a nice background article on the SPDXification topic at LWN [6] PS: and if you could spread the word at FB, that would we awesome! [1] https://lkml.org/lkml/2017/11/2/715 [2] https://lkml.org/lkml/2017/11/25/125 [3] https://lkml.org/lkml/2017/11/25/133 [4] https://lkml.org/lkml/2017/11/2/805 [5] https://lkml.org/lkml/2017/10/19/165 [6] https://lwn.net/Articles/739183/ -- Cordially Philippe Ombredanne