From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751655AbdK3Vhj (ORCPT ); Thu, 30 Nov 2017 16:37:39 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:32833 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbdK3Vhh (ORCPT ); Thu, 30 Nov 2017 16:37:37 -0500 X-Google-Smtp-Source: AGs4zMaa/tGFWO6PVY1d/zxMND5/+2UmjK4frNklWyjDj7AkZ4EumIyZ29gIS+PJszyhm4j06GkXj0bU7SBgUe1GhTo= MIME-Version: 1.0 In-Reply-To: <1512067334-12761-2-git-send-email-jagan@amarulasolutions.com> References: <1512067334-12761-1-git-send-email-jagan@amarulasolutions.com> <1512067334-12761-2-git-send-email-jagan@amarulasolutions.com> From: Philippe Ombredanne Date: Thu, 30 Nov 2017 22:36:55 +0100 Message-ID: Subject: Re: [PATCH RFC 2/2] arm64: allwinner: a64: Add Brava Keller initial support To: Jagan Teki Cc: Maxime Ripard , Chen-Yu Tsai , Icenowy Zheng , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Michael Trimarchi , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Mark Janoff , Stuart Westerman , linux-sunxi@googlegroups.com, Jagan Teki Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jagan, On Thu, Nov 30, 2017 at 7:42 PM, Jagan Teki wrote: [] > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts > new file mode 100644 > index 0000000..f5303a3 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts > @@ -0,0 +1,244 @@ > +/* > + * Copyright (C) 2017 Jagan Teki > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ Rather than this long boilerplate, you might want to use the SPDX ids, as started by Greg and documented by Thomas. Noe that Linus wants the // comment style for the license line, and since there is only two line left here I suggest using it for both lines. You can check also the recent doc patch posted by Thomas (tglx) and comments from Linus and Greg. So I guess you could use this: > +// Copyright (C) 2017 Jagan Teki > +// SPDX-License-Indentifier: (GPL-2.0+ OR MIT) NB: what you call X11 is has the MIT license id in the SPDX license list. So you could replace 32 lines by only two lines :) it'[s neat right? And this would also help as we have tagged already ~15K files, so it would help to use this for new files so the amount of cleanup work still left does not increase. Thank you for your kind consideration! -- Cordially Philippe Ombredanne From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philippe Ombredanne Subject: Re: [PATCH RFC 2/2] arm64: allwinner: a64: Add Brava Keller initial support Date: Thu, 30 Nov 2017 22:36:55 +0100 Message-ID: References: <1512067334-12761-1-git-send-email-jagan@amarulasolutions.com> <1512067334-12761-2-git-send-email-jagan@amarulasolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1512067334-12761-2-git-send-email-jagan@amarulasolutions.com> Sender: linux-kernel-owner@vger.kernel.org To: Jagan Teki Cc: Maxime Ripard , Chen-Yu Tsai , Icenowy Zheng , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , Michael Trimarchi , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Mark Janoff , Stuart Westerman , linux-sunxi@googlegroups.com, Jagan Teki List-Id: devicetree@vger.kernel.org Jagan, On Thu, Nov 30, 2017 at 7:42 PM, Jagan Teki wrote: [] > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts > new file mode 100644 > index 0000000..f5303a3 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts > @@ -0,0 +1,244 @@ > +/* > + * Copyright (C) 2017 Jagan Teki > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ Rather than this long boilerplate, you might want to use the SPDX ids, as started by Greg and documented by Thomas. Noe that Linus wants the // comment style for the license line, and since there is only two line left here I suggest using it for both lines. You can check also the recent doc patch posted by Thomas (tglx) and comments from Linus and Greg. So I guess you could use this: > +// Copyright (C) 2017 Jagan Teki > +// SPDX-License-Indentifier: (GPL-2.0+ OR MIT) NB: what you call X11 is has the MIT license id in the SPDX license list. So you could replace 32 lines by only two lines :) it'[s neat right? And this would also help as we have tagged already ~15K files, so it would help to use this for new files so the amount of cleanup work still left does not increase. Thank you for your kind consideration! -- Cordially Philippe Ombredanne From mboxrd@z Thu Jan 1 00:00:00 1970 From: pombredanne@nexb.com (Philippe Ombredanne) Date: Thu, 30 Nov 2017 22:36:55 +0100 Subject: [PATCH RFC 2/2] arm64: allwinner: a64: Add Brava Keller initial support In-Reply-To: <1512067334-12761-2-git-send-email-jagan@amarulasolutions.com> References: <1512067334-12761-1-git-send-email-jagan@amarulasolutions.com> <1512067334-12761-2-git-send-email-jagan@amarulasolutions.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Jagan, On Thu, Nov 30, 2017 at 7:42 PM, Jagan Teki wrote: [] > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts > new file mode 100644 > index 0000000..f5303a3 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts > @@ -0,0 +1,244 @@ > +/* > + * Copyright (C) 2017 Jagan Teki > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ Rather than this long boilerplate, you might want to use the SPDX ids, as started by Greg and documented by Thomas. Noe that Linus wants the // comment style for the license line, and since there is only two line left here I suggest using it for both lines. You can check also the recent doc patch posted by Thomas (tglx) and comments from Linus and Greg. So I guess you could use this: > +// Copyright (C) 2017 Jagan Teki > +// SPDX-License-Indentifier: (GPL-2.0+ OR MIT) NB: what you call X11 is has the MIT license id in the SPDX license list. So you could replace 32 lines by only two lines :) it'[s neat right? And this would also help as we have tagged already ~15K files, so it would help to use this for new files so the amount of cleanup work still left does not increase. Thank you for your kind consideration! -- Cordially Philippe Ombredanne