From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com ([209.85.128.194]:38394 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751459AbeCTXrE (ORCPT ); Tue, 20 Mar 2018 19:47:04 -0400 Received: by mail-wr0-f194.google.com with SMTP id l8so3447252wrg.5 for ; Tue, 20 Mar 2018 16:47:04 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <804857E1F29AAC47BF68C404FC60A184ED5CCD20@ORSMSX105.amr.corp.intel.com> References: <20180320171320.10826-1-jeffrey.t.kirsher@intel.com> <1521567660.12047.5.camel@perches.com> <1521568343.12746.4.camel@intel.com> <804857E1F29AAC47BF68C404FC60A184ED5CCD20@ORSMSX105.amr.corp.intel.com> From: Philippe Ombredanne Date: Tue, 20 Mar 2018 16:46:23 -0700 Message-ID: Subject: Re: [net-next] intel: add SPDX identifiers to all the Intel drivers To: "Allan, Bruce W" Cc: "Kirsher, Jeffrey T" , Joe Perches , "davem@davemloft.net" , "netdev@vger.kernel.org" , "nhorman@redhat.com" , "sassmann@redhat.com" , "jogreene@redhat.com" , Kate Stewart , Greg Kroah-Hartman , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org List-ID: Allan, On Tue, Mar 20, 2018 at 1:48 PM, Allan, Bruce W wrote: >> -----Original Message----- >> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] >> On Behalf Of Jeff Kirsher >> Sent: Tuesday, March 20, 2018 10:52 AM >> To: Joe Perches ; davem@davemloft.net; Philippe >> Ombredanne >> Cc: netdev@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com; >> jogreene@redhat.com >> Subject: Re: [net-next] intel: add SPDX identifiers to all the Intel drivers >> >> On Tue, 2018-03-20 at 10:41 -0700, Joe Perches wrote: >> > On Tue, 2018-03-20 at 10:13 -0700, Jeff Kirsher wrote: >> > > Add the SPDX identifiers to all the Intel wired LAN driver files, >> > > as >> > > outlined in Documentation/process/license-rules.rst. >> > >> > So far the Documentation does not show using the -only variant. >> > >> > For a discussion, please see: >> > https://lkml.org/lkml/2018/2/8/311 > > But the Linux Foundation, the authority maintaining the valid SPDX identifiers, indicates at https://spdx.org/licenses/ that "GPL-2.0" is deprecated while "GPL-2.0-only" (and others) is appropriate. > Was there any mention in the thread or other conversations if/when the kernel's documentation (and all existing uses of "GPL-2.0" in the kernel) will be updated to "GPL-2.0-only"? The kernel (as documented by Thomas [1]) is using for now the V2.6 of the SPDX licenses list. [2] IMHO the reference should be the kernel doc and nothing else to ensure consistency and avoid confusion (which obviously was not avoided entirely here ;) ). What happened is in late December a new version 3 was published by SPDX and the v2.6 is no longer online. I will bring this up to the SPDX group because we should be able to reference the version 2.6 online (it is still in git though [2]). When the kernel maintainers decide to switch to V3.0 of the SPDX list, the doc will be updated and then Joe's script could be applied at once to update the past. What matters most here is consistency: having some v2.6 and some v3.0 SPDX ids at once is not a happy thing IMHO. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst [2] https://github.com/spdx/license-list-data/tree/v2.6 >> :-( I had it originally as GPL-2.0 and then it was pointed out that it >> was being deprecated, so rather than creating future thrash over the >> change, figured I would be ahead of the game. >> >> > >> > > diff --git a/drivers/net/ethernet/intel/e100.c >> > > b/drivers/net/ethernet/intel/e100.c >> > >> > [] >> > > @@ -1,3 +1,4 @@ >> > > +// SPDX-License-Identifier: GPL-2.0-only >> > >> > etc... -- Cordially Philippe Ombredanne