All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philippe Ombredanne <pombredanne@nexb.com>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: James Hogan <jhogan@kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	Linux MIPS <linux-mips@linux-mips.org>,
	Huacai Chan <chenhc@lemote.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 3/5] MIPS: Loongson64: Yeeloong add platform driver
Date: Sat, 16 Dec 2017 19:28:40 +0100	[thread overview]
Message-ID: <CAOFm3uHEmY-0y5qUDpLW+WLyi+TJd6LeV4qRhbhaXmCtX05mbw@mail.gmail.com> (raw)
In-Reply-To: <20171216145751.3486-4-jiaxun.yang@flygoat.com>

Dear Jiaxun,

On Sat, Dec 16, 2017 at 3:57 PM, Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> Yeeloong is a laptop with a MIPS Loongson 2F processor, AMD CS5536
> chipset, and KB3310B controller.

<snip>

> --- /dev/null
> +++ b/drivers/platform/mips/yeeloong_laptop.c
> @@ -0,0 +1,1142 @@
> +/*
> + * Driver for YeeLoong laptop extras
> + *
> + *  Copyright (C) 2017 Jiaxun Yang.
> + *  Author: Jiaxun Yang <jiaxun.yang@flygoat.com>
> + *
> + *  Copyright (C) 2009 Lemote Inc.
> + *  Author: Wu Zhangjin <wuzhangjin@gmail.com>, Liu Junliang <liujl@lemote.com>
> + *
> + *  Fixes: Petr Pisar <petr.pisar@atlas.cz>, 2012, 2013, 2014, 2015.
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License version 2 as
> + *  published by the Free Software Foundation.
> + */

Would you mind using the new SPDX tags here. See Thomas patches [1]

> +MODULE_LICENSE("GPL");

Also please make sure your module license (here GPL 2.0 or later per
module.h) matches your top level license tag  correctly (here GPL 2.0
only)?

[1] https://lkml.org/lkml/2017/12/4/934

-- 
Cordially
Philippe Ombredanne

  reply	other threads:[~2017-12-16 18:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-16 14:57 Add YeeLoong support v5 Jiaxun Yang
2017-12-16 14:57 ` [PATCH v5 1/5] MIPS: Lonngson64: Copy kernel command line from arcs_cmdline Jiaxun Yang
2017-12-20 16:36   ` Ralf Baechle
2017-12-16 14:57 ` [PATCH v5 2/5] MIPS: Loongson64: lemote-2f move ec_kb3310b.h to include dir and clean up Jiaxun Yang
2017-12-16 14:57 ` [PATCH v5 3/5] MIPS: Loongson64: Yeeloong add platform driver Jiaxun Yang
2017-12-16 18:28   ` Philippe Ombredanne [this message]
2017-12-16 14:57 ` [PATCH v5 4/5] MIPS: Loongson64: Load platform device during boot Jiaxun Yang
2017-12-16 14:57 ` [PATCH v5 5/5] MAINTAINERS: Add entry for Lemote YeeLoong Extra Driver Jiaxun Yang
2017-12-20 14:54   ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOFm3uHEmY-0y5qUDpLW+WLyi+TJd6LeV4qRhbhaXmCtX05mbw@mail.gmail.com \
    --to=pombredanne@nexb.com \
    --cc=chenhc@lemote.com \
    --cc=jhogan@kernel.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.