From: Philippe Ombredanne <firstname.lastname@example.org> To: Joe Perches <email@example.com> Cc: Rob Herring <firstname.lastname@example.org>, Igor Stoppa <email@example.com>, Kate Stewart <firstname.lastname@example.org>, Andrew Morton <email@example.com>, "firstname.lastname@example.org" <email@example.com>, Andy Whitcroft <firstname.lastname@example.org>, Greg Kroah-Hartman <email@example.com>, Thomas Gleixner <firstname.lastname@example.org>, Jonathan Corbet <email@example.com> Subject: Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check Date: Thu, 8 Feb 2018 15:35:17 +0100 [thread overview] Message-ID: <CAOFm3uHNvGOh_ErxpG9VeHwMzHGvdoN5Xx_JSN8y+QhB32ivmw@mail.gmail.com> (raw) In-Reply-To: <firstname.lastname@example.org> even On Fri, Feb 2, 2018 at 8:06 PM, Joe Perches <email@example.com> wrote: > On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote: >> On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa <firstname.lastname@example.org> wrote: >> > On 02/02/18 17:40, Rob Herring wrote: >> > > Add SPDX license tag check based on the rules defined in >> > >> > Shouldn't it also check that the license is compatible? >> > >> >> Perhaps we shouldn't try to script legal advice. > > True. > > I believe what was meant was that the > entry was a valid SPDX License entry > that already exists as a specific file > in the LICENSES/ path. > > So that entry must be some combination of: > > $ git ls-files LICENSES/ | cut -f3- -d'/' | sort > BSD-2-Clause > BSD-3-Clause > BSD-3-Clause-Clear > GPL-1.0 > GPL-2.0 > LGPL-2.0 > LGPL-2.1 > Linux-syscall-note > MIT > MPL-1.1 > > From my perspective, it'd be better if the > various + uses had their own individual > license files in the LICENSES/ path. > > Right now, there are many missing licenses > that are already used by various existing > SPDX-License-Identifier: entries. > > > APACHE-2.0 > BSD > CDDL > CDDL-1.0 > ISC > GPL-1.0+ > GPL-2.0+ > LGPL-2.1+ > OpenSSL > > There are odd entries like: > > GPL-2.0-only > > Parentheses around AND/OR aren't consistent. Joe, I have a comprehensive license expressions checker/parser  in Python ;) if it is ever needed, but that's likely overkill for the kernel. (this is not in Perl for one thing and second it is based on a boolean expression parser and minimizer, hence overkill for the limited kernel use case IMHO) However checking that licenses ids are known and listed in the kernel doc is essential IMHO to avoid drift and insulate the kernel from SPDX updates. Case in point the new SPDX "GPL-2.0-only" is NOT what was documented by tglx and therefore should not be used and banned until we update the doc accordingly. and until we update ALL the GPL-2.0 to GPL-2.0-only eventually which is best done at once. Otherwise, this is going to be a total mess on top of a complicated topic that requires quite a bit of maintainer energy!  https://github.com/nexB/license-expression/ -- Cordially Philippe Ombredanne
next prev parent reply other threads:[~2018-02-08 14:35 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-02 15:40 Rob Herring 2018-02-02 15:49 ` Igor Stoppa 2018-02-02 16:12 ` Greg Kroah-Hartman 2018-02-02 16:17 ` Jonathan Corbet 2018-02-02 18:27 ` Rob Herring 2018-02-02 19:06 ` Joe Perches 2018-02-02 20:18 ` Kate Stewart 2018-02-02 20:26 ` Kate Stewart 2018-02-02 20:55 ` Joe Perches 2018-02-08 14:41 ` Philippe Ombredanne 2018-02-02 20:57 ` Rob Herring 2018-02-02 21:10 ` Joe Perches 2018-02-03 13:41 ` Igor Stoppa 2018-02-08 14:44 ` Philippe Ombredanne 2018-02-08 14:35 ` Philippe Ombredanne [this message] 2018-02-08 17:24 ` Joe Perches 2018-02-08 18:09 ` Philippe Ombredanne 2018-02-02 21:18 ` Joe Perches 2018-02-09 0:35 ` Joe Perches 2018-02-09 5:58 ` Philippe Ombredanne
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAOFm3uHNvGOh_ErxpG9VeHwMzHGvdoN5Xx_JSN8y+QhB32ivmw@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.