From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752597AbdKEMyj (ORCPT ); Sun, 5 Nov 2017 07:54:39 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:43930 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752433AbdKEMyg (ORCPT ); Sun, 5 Nov 2017 07:54:36 -0500 X-Google-Smtp-Source: ABhQp+R46JVev/TRfXSd/oSC+SATBDzTqm6+nl8GNu1eAg+5FzDDYbNxqVYMjJuHmER37EQhiBb3mbOuXEgxTW2yRHs= MIME-Version: 1.0 In-Reply-To: <20171104104010.GA27490@kroah.com> References: <20171019083832.GA21820@kroah.com> <20171103102830.GA18343@kroah.com> <20171103165301.GR7223@localhost> <20171104104010.GA27490@kroah.com> From: Philippe Ombredanne Date: Sun, 5 Nov 2017 13:53:54 +0100 Message-ID: Subject: Re: [PATCH v2] USB: add SPDX identifiers to all remaining files in drivers/usb/ To: Greg Kroah-Hartman Cc: Johan Hovold , linux-usb@vger.kernel.org, LKML , Thomas Gleixner , Kate Stewart Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 4, 2017 at 11:40 AM, Greg Kroah-Hartman wrote: > On Fri, Nov 03, 2017 at 05:53:01PM +0100, Johan Hovold wrote: >> On Fri, Nov 03, 2017 at 11:28:30AM +0100, Greg Kroah-Hartman wrote: >> > It's good to have SPDX identifiers in all files to make it easier to >> > audit the kernel tree for correct licenses. >> > >> > Update the drivers/usb/ and include/linux/usb* files with the correct >> > SPDX license identifier based on the license text in the file itself. >> > The SPDX identifier is a legally binding shorthand, which can be used >> > instead of the full boiler plate text. >> > >> > This work is based on a script and data from Thomas Gleixner, Philippe >> > Ombredanne, and Kate Stewart. >> > >> > Cc: Thomas Gleixner >> > Cc: Kate Stewart >> > Cc: Philippe Ombredanne >> > Signed-off-by: Greg Kroah-Hartman >> >> I noticed several MODULE_LICENSE macros which did not match the headers >> (e.g. "GPL" being used for version 2 only modules) for which I'll send a >> follow-up patch. >> >> Someone should probably write a script for that once the SPDX >> identifiers are in. > > Yes, I think that someone might have a script for that, it will be much > easier to detect these things now. The issue is that the "v2" marking > came after the original "GPL" marking for MODULE_LICENSE() from what I > remember, so many of those will be wrong. If this can help my [1] tool can detect both header-level licenses-in-comments as well as MODULE_LICENSE macros. Based on that we could reasonably easily craft a script that scans a file and report discrepancies between the two. FWIW this is the same tool that has been used to provide some input to Greg to clean things up here. [1] https://github.com/nexB/scancode-toolkit -- Cordially Philippe Ombredanne