From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
Nugraha <richiisei@gmail.com>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel test robot <lkp@intel.com>,
Alviro Iskandar Setiawan <alviro.iskandar@gmail.com>
Subject: Re: [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning
Date: Tue, 15 Mar 2022 06:38:19 +0700 [thread overview]
Message-ID: <CAOG64qNUd12UaSNYax5tnZh5uOnqjmiiSc9HxTfTEU4w5HPvXA@mail.gmail.com> (raw)
In-Reply-To: <Yi+8ft7yXrNN4+Yx@dev-arch.thelio-3990X>
On Tue, Mar 15, 2022 at 5:07 AM Nathan Chancellor wrote:
> Hi Alviro,
[...]
>
> I would recommend removing these and just setting those values via git
> send-email flags. In other words:
>
> git send-email --to "..." --cc "..." --cc "..." <path to .patch>
>
> and so on. It can cause a lot of spam if this patch is ever backported
> or needed in other trees.
Fixed.
> > Reported-by: kernel test robot <lkp@intel.com>
> > Link: https://lore.kernel.org/lkml/202203091430.MLY27Bif-lkp@intel.com
> > Fixes: 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc: add PDMC driver")
>
> This should be simplified to:
>
> Fixes: 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver")
>
> I don't think the automated checkers will complain about that but the
> short form is preferred.
Fixed.
> > Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
>
> Thanks a lot for the patch!
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> I don't know if those nits are worth resending but I do not see this
> applied to Mark's tree yet. It might have gotten lost because this was
> sent as a reply to the build report, rather than its own thread, which
> has caused issues for me in the past:
>
> https://lore.kernel.org/r/20210903162639.GM4932@sirena.org.uk/
>
> If there is no action on this patch in the next couple of days, please
> consider resending with the above nits addressed with Codrin's tag and
> my tag.
Will address those. Thanks for the review.
-- Viro
WARNING: multiple messages have this Message-ID (diff)
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning
Date: Tue, 15 Mar 2022 06:38:19 +0700 [thread overview]
Message-ID: <CAOG64qNUd12UaSNYax5tnZh5uOnqjmiiSc9HxTfTEU4w5HPvXA@mail.gmail.com> (raw)
In-Reply-To: <Yi+8ft7yXrNN4+Yx@dev-arch.thelio-3990X>
[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]
On Tue, Mar 15, 2022 at 5:07 AM Nathan Chancellor wrote:
> Hi Alviro,
[...]
>
> I would recommend removing these and just setting those values via git
> send-email flags. In other words:
>
> git send-email --to "..." --cc "..." --cc "..." <path to .patch>
>
> and so on. It can cause a lot of spam if this patch is ever backported
> or needed in other trees.
Fixed.
> > Reported-by: kernel test robot <lkp@intel.com>
> > Link: https://lore.kernel.org/lkml/202203091430.MLY27Bif-lkp(a)intel.com
> > Fixes: 50291652af5269813baa6024eb0e81b5f0bbb451 ("ASoC: atmel: mchp-pdmc: add PDMC driver")
>
> This should be simplified to:
>
> Fixes: 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver")
>
> I don't think the automated checkers will complain about that but the
> short form is preferred.
Fixed.
> > Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
>
> Thanks a lot for the patch!
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> I don't know if those nits are worth resending but I do not see this
> applied to Mark's tree yet. It might have gotten lost because this was
> sent as a reply to the build report, rather than its own thread, which
> has caused issues for me in the past:
>
> https://lore.kernel.org/r/20210903162639.GM4932(a)sirena.org.uk/
>
> If there is no action on this patch in the next couple of days, please
> consider resending with the above nits addressed with Codrin's tag and
> my tag.
Will address those. Thanks for the review.
-- Viro
next prev parent reply other threads:[~2022-03-14 23:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 6:09 [ammarfaizi2-block:broonie/sound/for-next 13916/13921] sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array 'uvalue->value.integer.value' will always evaluate to 'true' kernel test robot
2022-03-09 6:58 ` [PATCH] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning Alviro Iskandar Setiawan
2022-03-09 6:58 ` Alviro Iskandar Setiawan
2022-03-09 7:55 ` Codrin.Ciubotariu
2022-03-09 7:55 ` Codrin.Ciubotariu
2022-03-14 22:06 ` Nathan Chancellor
2022-03-14 22:06 ` Nathan Chancellor
2022-03-14 23:38 ` Alviro Iskandar Setiawan [this message]
2022-03-14 23:38 ` Alviro Iskandar Setiawan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOG64qNUd12UaSNYax5tnZh5uOnqjmiiSc9HxTfTEU4w5HPvXA@mail.gmail.com \
--to=alviro.iskandar@gnuweeb.org \
--cc=alviro.iskandar@gmail.com \
--cc=broonie@kernel.org \
--cc=codrin.ciubotariu@microchip.com \
--cc=gwml@vger.gnuweeb.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=richiisei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.