From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752273AbcDKIAX (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Apr 2016 04:00:23 -0400
Received: from mail-wm0-f51.google.com ([74.125.82.51]:34688 "EHLO
	mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752137AbcDKIAT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Apr 2016 04:00:19 -0400
MIME-Version: 1.0
In-Reply-To: <CAOGi=dPSyUc269DzUegTZYMXud+uzoET6fraK40jAHbMNzJv0Q@mail.gmail.com>
References: <1451549374-30875-1-git-send-email-ling.ma.program@gmail.com>
	<20160105211834.GR6344@twins.programming.kicks-ass.net>
	<20160105214227.3a2adcd2@lxorguk.ukuu.org.uk>
	<20160106081643.GS6344@twins.programming.kicks-ass.net>
	<20160106082106.GU6373@twins.programming.kicks-ass.net>
	<20160106112450.6c5ad08b@lxorguk.ukuu.org.uk>
	<CAOGi=dPhZUiXAWwvrNXY=cPga9F16g2-N=MVVV-Oo-cFnQQyPg@mail.gmail.com>
	<20160112135016.247c6ca5@lxorguk.ukuu.org.uk>
	<CAOGi=dOz4ogdt303e6PERuGEcrAazVf_r8YigRjtb5kGm5M0eA@mail.gmail.com>
	<CAOGi=dPaV+H1eg+YeNj0maogMw9MxEqQJsVrpT_mJa9aLKaRUw@mail.gmail.com>
	<569E5816.6000909@hpe.com>
	<CAOGi=dNfmJQbN_0N_SK1AFwRzSqgxBmfAVNyBwkG-TdDYLbhMw@mail.gmail.com>
	<56B2744D.6080202@hpe.com>
	<CAOGi=dPSyUc269DzUegTZYMXud+uzoET6fraK40jAHbMNzJv0Q@mail.gmail.com>
Date: Mon, 11 Apr 2016 16:00:18 +0800
Message-ID: <CAOGi=dMcQR+ydbz5WSxy_7s2=vFYeuyd+N+AC5NJaSvvdLbxEw@mail.gmail.com>
Subject: Re: [RFC PATCH] alispinlock: acceleration from lock integration on
 multi-core platform
From: Ling Ma <ling.ma.program@gmail.com>
To: Waiman Long <waiman.long@hpe.com>
Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        Peter Zijlstra <peterz@infradead.org>, mingo@redhat.com,
        linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        Ling <ling.ml@alibaba-inc.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Is it acceptable for performance improvement or more comments on this patch?

Thanks
Ling

2016-04-05 11:44 GMT+08:00 Ling Ma <ling.ma.program@gmail.com>:
> Hi Longman,
>
>> with some modest increase in performance. That can be hard to justify. Maybe
>> you should find other use cases that involve less changes, but still have
>> noticeable performance improvement. That will make it easier to be accepted.
>
> The attachment is for other use case with the new lock optimization.
> It include two files: main.c (user space workload),
> fcntl-lock-opt.patch (kernel patch on 4.3.0-rc4 version)
> (The hardware platform is on Intel E5 2699 V3, 72 threads (18core *2Socket *2HT)
>
> 1. when we run a.out from main.c on original 4.3.0-rc4 version,
> the average throughput from a.out is 1887592( 98% cpu cost from perf top -d1)
>
> 2. when we run a.out from main.c with the fcntl-lock-opt.patch ,
> the average throughput from a.out is 5277281 (91% cpu cost from perf top -d1)
>
> So we say the new mechanism give us about 2.79x (5277281 / 1887592) improvement.
>
> Appreciate your comments.
>
> Thanks
> Ling