From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suman Tripathi Subject: Re: [PATCH v1 2/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. Date: Wed, 28 Jan 2015 18:52:20 +0530 Message-ID: References: <1422379260-10139-1-git-send-email-stripathi@apm.com> <2323575.nqxsEzcHbG@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <2323575.nqxsEzcHbG@wuerfel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Arnd Bergmann Cc: "devicetree@vger.kernel.org" , Mark Langsdorf , Jon Masters , anton@enomsg.org, linux-mmc@vger.kernel.org, chris@printf.net, patches , Don Dutile , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel List-Id: devicetree@vger.kernel.org T24gV2VkbmVzZGF5IDI4IEphbnVhcnkgMjAxNSAwOTo1MzoyNSBTdW1hbiBUcmlwYXRoaSB3cm90 ZToKPgo+IEkgYWRkZWQgdGhlIGlvbW11cyBpbiB0aGUgSU9NTVUgQUhCQyBwYXRjaC4gQW55dGhp bmcgd3JvbmcgaW4gdGhhdCA/Cj4gSW4gdGhlIG5leHQgdmVyc2lvbiBBbHNvIEkgd2lsbCByZW1v dmUgdGhlIElPTU1VIGhhY2tzIGZyb20gYXJhc2FuCj4gZHJpdmVyCgpIbW0sIEkgZ3Vlc3MgeW91 IGhhdmUgYSByZXF1aXJlZCBvcmRlcmluZyBiZXR3ZWVuIHRoZSBwYXRjaGVzIGVpdGhlcgp3YXks IHdoaWNoIG1ha2VzIGl0IGhhcmQgdG8gbWVyZ2UgaW4gYSB3YXkgdGhhdCBpcyBiaXNlY3RhYmxl LgoKWW91IGFyZSBjb3JyZWN0IHRoYXQgeW91IHNob3VsZCBub3QgbWVyZ2UgYSBwYXRjaCB3aXRo IHRoZSBpb21tdQpyZWZlcmVuY2UgYmVmb3JlIGFkZGluZyB0aGUgaW9tbXUgZGV2aWNlIG5vZGUs IGJlY2F1c2UgaXQgd291bGQKb3RoZXJ3aXNlIGJyZWFrIGJ1aWxkaW5nIHRoZSBtbWMgdHJlZS4K Ck9uZSBtb3JlIHBvaW50IGlzIHRoZSBiaW5kaW5nIGZvciBJT01NVSBuZWVkcyB0byBiZSBpbiB0 aGUgc2FtZSBwYXRjaAppbiB3aGljaCB0aGUgSU9NTVUgc3VwcG9ydCBpcyBhZGRlZC4gU28gdG8g cHJvdmlkZSB0aGUgYmluZGluZyBpbmZvIG9mCnRoZSBtYXN0ZXIgbm9kZSB3ZSByZXF1aXJlIHRo ZSBzZGhjIG5vZGVzIHRvIGJlIG1lcmdlZCBmaXJzdC4KClVzdWFsbHksIHRoZSByaWdodCBhbnN3 ZXIgaXMgdG8gbWVyZ2VkIHRoZSBkdHMgY2hhbmdlcyB0aHJvdWdoIHRoZQphcm0tc29jIHRyZWUs IGFuZCB0aGVuIHlvdSBjYW4ganVzdCBhZGQgdGhlIG5vZGUgZm9yIHRoZSBzZGhjIGRldmljZQph ZnRlciB0aGUgb25lIGZvciB0aGUgaW9tbXUgZGV2aWNlLgoKT24gV2VkLCBKYW4gMjgsIDIwMTUg YXQgNjoxNiBQTSwgQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4gd3JvdGU6Cj4gT24gV2Vk bmVzZGF5IDI4IEphbnVhcnkgMjAxNSAwOTo1MzoyNSBTdW1hbiBUcmlwYXRoaSB3cm90ZToKPj4K Pj4gSSBhZGRlZCB0aGUgaW9tbXVzIGluIHRoZSBJT01NVSBBSEJDIHBhdGNoLiBBbnl0aGluZyB3 cm9uZyBpbiB0aGF0ID8KPj4gSW4gdGhlIG5leHQgdmVyc2lvbiBBbHNvIEkgd2lsbCByZW1vdmUg dGhlIElPTU1VIGhhY2tzIGZyb20gYXJhc2FuCj4+IGRyaXZlcgo+Cj4gSG1tLCBJIGd1ZXNzIHlv dSBoYXZlIGEgcmVxdWlyZWQgb3JkZXJpbmcgYmV0d2VlbiB0aGUgcGF0Y2hlcyBlaXRoZXIKPiB3 YXksIHdoaWNoIG1ha2VzIGl0IGhhcmQgdG8gbWVyZ2UgaW4gYSB3YXkgdGhhdCBpcyBiaXNlY3Rh YmxlLgo+Cj4gWW91IGFyZSBjb3JyZWN0IHRoYXQgeW91IHNob3VsZCBub3QgbWVyZ2UgYSBwYXRj aCB3aXRoIHRoZSBpb21tdQo+IHJlZmVyZW5jZSBiZWZvcmUgYWRkaW5nIHRoZSBpb21tdSBkZXZp Y2Ugbm9kZSwgYmVjYXVzZSBpdCB3b3VsZAo+IG90aGVyd2lzZSBicmVhayBidWlsZGluZyB0aGUg bW1jIHRyZWUuCj4KPiBVc3VhbGx5LCB0aGUgcmlnaHQgYW5zd2VyIGlzIHRvIG1lcmdlZCB0aGUg ZHRzIGNoYW5nZXMgdGhyb3VnaCB0aGUKPiBhcm0tc29jIHRyZWUsIGFuZCB0aGVuIHlvdSBjYW4g anVzdCBhZGQgdGhlIG5vZGUgZm9yIHRoZSBzZGhjIGRldmljZQo+IGFmdGVyIHRoZSBvbmUgZm9y IHRoZSBpb21tdSBkZXZpY2UuCj4KPiAgICAgICAgIEFybmQKCgoKLS0gClRoYW5rcywKd2l0aCBy ZWdhcmRzLApTdW1hbiBUcmlwYXRoaQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpMaW51eHBwYy1kZXYgbWFpbGluZyBsaXN0CkxpbnV4cHBjLWRldkBsaXN0 cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1k ZXY= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yk0-f178.google.com (exprod5og120.obsmtp.com [64.18.0.137]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id A8F781A08CC for ; Thu, 29 Jan 2015 00:22:23 +1100 (AEDT) Received: by mail-yk0-f178.google.com with SMTP id q200so8840580ykb.9 for ; Wed, 28 Jan 2015 05:22:20 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <2323575.nqxsEzcHbG@wuerfel> References: <1422379260-10139-1-git-send-email-stripathi@apm.com> <2323575.nqxsEzcHbG@wuerfel> Date: Wed, 28 Jan 2015 18:52:20 +0530 Message-ID: Subject: Re: [PATCH v1 2/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. From: Suman Tripathi To: Arnd Bergmann Content-Type: text/plain; charset=UTF-8 Cc: "devicetree@vger.kernel.org" , Mark Langsdorf , Jon Masters , anton@enomsg.org, linux-mmc@vger.kernel.org, chris@printf.net, patches , Don Dutile , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wednesday 28 January 2015 09:53:25 Suman Tripathi wrote: > > I added the iommus in the IOMMU AHBC patch. Anything wrong in that ? > In the next version Also I will remove the IOMMU hacks from arasan > driver Hmm, I guess you have a required ordering between the patches either way, which makes it hard to merge in a way that is bisectable. You are correct that you should not merge a patch with the iommu reference before adding the iommu device node, because it would otherwise break building the mmc tree. One more point is the binding for IOMMU needs to be in the same patch in which the IOMMU support is added. So to provide the binding info of the master node we require the sdhc nodes to be merged first. Usually, the right answer is to merged the dts changes through the arm-soc tree, and then you can just add the node for the sdhc device after the one for the iommu device. On Wed, Jan 28, 2015 at 6:16 PM, Arnd Bergmann wrote: > On Wednesday 28 January 2015 09:53:25 Suman Tripathi wrote: >> >> I added the iommus in the IOMMU AHBC patch. Anything wrong in that ? >> In the next version Also I will remove the IOMMU hacks from arasan >> driver > > Hmm, I guess you have a required ordering between the patches either > way, which makes it hard to merge in a way that is bisectable. > > You are correct that you should not merge a patch with the iommu > reference before adding the iommu device node, because it would > otherwise break building the mmc tree. > > Usually, the right answer is to merged the dts changes through the > arm-soc tree, and then you can just add the node for the sdhc device > after the one for the iommu device. > > Arnd -- Thanks, with regards, Suman Tripathi From mboxrd@z Thu Jan 1 00:00:00 1970 From: stripathi@apm.com (Suman Tripathi) Date: Wed, 28 Jan 2015 18:52:20 +0530 Subject: [PATCH v1 2/2] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. In-Reply-To: <2323575.nqxsEzcHbG@wuerfel> References: <1422379260-10139-1-git-send-email-stripathi@apm.com> <2323575.nqxsEzcHbG@wuerfel> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 28 January 2015 09:53:25 Suman Tripathi wrote: > > I added the iommus in the IOMMU AHBC patch. Anything wrong in that ? > In the next version Also I will remove the IOMMU hacks from arasan > driver Hmm, I guess you have a required ordering between the patches either way, which makes it hard to merge in a way that is bisectable. You are correct that you should not merge a patch with the iommu reference before adding the iommu device node, because it would otherwise break building the mmc tree. One more point is the binding for IOMMU needs to be in the same patch in which the IOMMU support is added. So to provide the binding info of the master node we require the sdhc nodes to be merged first. Usually, the right answer is to merged the dts changes through the arm-soc tree, and then you can just add the node for the sdhc device after the one for the iommu device. On Wed, Jan 28, 2015 at 6:16 PM, Arnd Bergmann wrote: > On Wednesday 28 January 2015 09:53:25 Suman Tripathi wrote: >> >> I added the iommus in the IOMMU AHBC patch. Anything wrong in that ? >> In the next version Also I will remove the IOMMU hacks from arasan >> driver > > Hmm, I guess you have a required ordering between the patches either > way, which makes it hard to merge in a way that is bisectable. > > You are correct that you should not merge a patch with the iommu > reference before adding the iommu device node, because it would > otherwise break building the mmc tree. > > Usually, the right answer is to merged the dts changes through the > arm-soc tree, and then you can just add the node for the sdhc device > after the one for the iommu device. > > Arnd -- Thanks, with regards, Suman Tripathi