From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pekka Enberg <penberg@kernel.org>
Subject: Re: [PATCH 4/4] kvm tools: Implement MSI-X for virtio-rng
Date: Thu, 28 Jul 2011 12:33:17 +0300
Message-ID: <CAOJsxLGQE+H1M1S3iJNyWX6=s7EyWxogxXO+OuGB-pkuGYZ1XQ@mail.gmail.com>
References: <1311843715-5464-1-git-send-email-levinsasha928@gmail.com>
	<1311843715-5464-4-git-send-email-levinsasha928@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com,
	gorcunov@gmail.com, prasadjoshi124@gmail.com
To: Sasha Levin <levinsasha928@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-vw0-f52.google.com ([209.85.212.52]:47514 "EHLO
	mail-vw0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753630Ab1G1JdS convert rfc822-to-8bit (ORCPT
	<rfc822;kvm@vger.kernel.org>); Thu, 28 Jul 2011 05:33:18 -0400
Received: by vws16 with SMTP id 16so2722411vws.11
        for <kvm@vger.kernel.org>; Thu, 28 Jul 2011 02:33:17 -0700 (PDT)
In-Reply-To: <1311843715-5464-4-git-send-email-levinsasha928@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Jul 28, 2011 at 12:01 PM, Sasha Levin <levinsasha928@gmail.com>=
 wrote:
> @@ -163,8 +167,21 @@ static bool virtio_rng_pci_io_out(struct ioport =
*ioport, struct kvm *kvm, u16 po
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0rdev->status =A0 =A0 =A0 =A0 =A0 =A0=3D=
 ioport__read8(data);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break;
> =A0 =A0 =A0 =A0case VIRTIO_MSI_CONFIG_VECTOR:
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 rdev->config_vector =A0 =A0 =3D VIRTIO_=
MSI_NO_VECTOR;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 rdev->config_vector =A0 =A0 =3D ioport_=
_read16(data);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break;
> + =A0 =A0 =A0 case VIRTIO_MSI_QUEUE_VECTOR:
> + =A0 =A0 =A0 {

Nit: the curly brace should be on the same line as 'case' keyword.

> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 u32 gsi;
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 u32 vec;
> +