From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH] KVM: Add wrapper script around QEMU to test kernels Date: Mon, 7 Nov 2011 15:12:28 +0200 Message-ID: References: <4EB680D9.2070706@redhat.com> <877C82F4-F07C-44AA-8722-3AF57CFC4597@suse.de> <4EB7B1A9.9000409@redhat.com> <4EB7CA52.5050409@redhat.com> <20111107122902.GA24685@thunk.org> <20111107124757.GC24685@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE To: "Ted Ts'o" , Pekka Enberg , Gerd Hoffmann , Pekka Enberg , Alexander Graf , Avi Kivity Received: from mail-vw0-f46.google.com ([209.85.212.46]:65379 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754394Ab1KGNM3 convert rfc822-to-8bit (ORCPT ); Mon, 7 Nov 2011 08:12:29 -0500 In-Reply-To: <20111107124757.GC24685@thunk.org> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Nov 7, 2011 at 2:47 PM, Ted Ts'o wrote: > I don't think perf should be used as a precendent that now argues tha= t > any new kernel utility should be moved into the kernel sources. =A0Do= es > it make sense to move all of mount, fsck, login, etc., into the kerne= l > sources? =A0There are far more kernel tools outside of the kernel > sources than inside the kernel sources. You seem to think that the KVM tool was developed in isolation and we simply copied the code to tools/kvm for the pull request. That's simply not true. We've done a lot of work to make the code feel like kernel co= de from locking primitive APIs to serial console emulation register names. We really consider KVM tool to be a new Linux subsystem. It's the long lost cousin or bastard child of KVM, depending on who you ask. I don't know if it makes sense to merge the tools you've mentioned abov= e. My gut feeling is that it's probably not reasonable - there's already a community working on it with their own development process and coding style. I don't think there's a simple answer to this but I don't agree = with your rather extreme position that all userspace tools should be kept ou= t of the kernel tree. Pekka