From: Pekka Enberg <penberg@kernel.org>
To: Hin-Tak Leung <hintak_leung@yahoo.co.uk>
Cc: linux-fsdevel@vger.kernel.org, Naohiro Aota <naota@elisp.net>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@tuxera.com>
Subject: Re: [PATCH] hfsplus: Add record offset check
Date: Wed, 13 Jul 2011 09:06:29 +0300 [thread overview]
Message-ID: <CAOJsxLHi_5yuqvOEoGuGQbz86TTuMpinbHzuNEtmvZaZMhcJYA@mail.gmail.com> (raw)
In-Reply-To: <1310529537.96670.YahooMailClassic@web29502.mail.ird.yahoo.com>
On Wed, Jul 13, 2011 at 6:58 AM, Hin-Tak Leung <hintak_leung@yahoo.co.uk> wrote:
>> Corrupted disk may return record offset which is larger
>> than node size
>> and cause general protection fault like below:
>
> <snipped>
>
>> This patch add guard for this situation.
>>
>> Signed-off-by: Naohiro Aota <naota@elisp.net>
>
> Nacked. This isn't acceptable. Explained above.
'recoff' is read from disk which can be easily fuzzed to have an
offset that's larger than node_size, no? The kernel shouldn't oops in
that cases so what's the problem with the patch? (The changelog is
terribly vague, though, and needs to be fixed).
Pekka
next prev parent reply other threads:[~2011-07-13 6:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 18:46 [PATCH] hfsplus: Add record offset check Naohiro Aota
2011-07-13 3:58 ` Hin-Tak Leung
2011-07-13 3:58 ` Hin-Tak Leung
2011-07-13 6:06 ` Pekka Enberg [this message]
2011-07-14 5:06 ` Hin-Tak Leung
2011-07-13 22:20 ` Naohiro Aota
2011-07-14 7:30 ` Pekka Enberg
2011-07-14 8:07 ` Hin-Tak Leung
2011-07-14 14:53 ` Christoph Hellwig
2011-07-17 22:08 ` [PATCH v2] hfsplus: Add additional range check to handle on-disk corruptions Naohiro Aota
2011-07-18 15:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOJsxLHi_5yuqvOEoGuGQbz86TTuMpinbHzuNEtmvZaZMhcJYA@mail.gmail.com \
--to=penberg@kernel.org \
--cc=hch@tuxera.com \
--cc=hintak_leung@yahoo.co.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naota@elisp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.