All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shan Gavin <shan.gavin@gmail.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Andrew Jones <drjones@redhat.com>, Gavin Shan <gshan@redhat.com>,
	richard.henderson@linaro.org, QEMU <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH] hw/arm/virt: Validate memory size on the first NUMA node
Date: Mon, 7 Mar 2022 15:13:52 +0800	[thread overview]
Message-ID: <CAOL5Tw=E1iEALPt3H5-T9Tizg3DMpUH8dueiPuuiSvz51AY8UQ@mail.gmail.com> (raw)
In-Reply-To: <1abedac8-00c8-3039-ccfe-783f5eab9439@redhat.com>

Hi Laszlo,

Yes, I think it's enough to provide the user-friendly error message in EDK2.
The command lines to start the VM/guest can be adjusted to have more than
128MB memory associated for NUMA node#0 when it's seen by users.

Thanks,
Gavin

Laszlo Ersek <lersek@redhat.com> 于2022年3月4日周五 22:24写道：
>
> Gerd,
>
> On 03/04/22 11:58, Peter Maydell wrote:
> > On Fri, 4 Mar 2022 at 10:52, Igor Mammedov <imammedo@redhat.com> wrote:
> >> if firmware is not an option, I wouldn't opposed to printing warning
> >> message from QEMU if you can detect that you are running broken edk2
> >> and under condition that no new infa/hooks are invented for this.
> >> (assuming it's worth all the effort at all)
> >
> > I am definitely not in favour of that. QEMU should provide the
> > emulated hardware and let the firmware deal with detecting if
> > it's missing important stuff. It should as far as is possible
> > not have special-case detection-of-broken-guests handling.
> >
> > thanks
> > -- PMM
> >
>
> It's probably simplest if you replace the ASSERT()s in question; please
> see the attachment. (Only smoke tested.) Gavin indicated up-thread he'd
> be OK with an easier-to-understand error message.
>
> Laszlo


      reply	other threads:[~2022-03-07  7:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28  7:52 [PATCH] hw/arm/virt: Validate memory size on the first NUMA node Gavin Shan
2022-02-28  9:08 ` Igor Mammedov
2022-03-01  9:20   ` Gavin Shan
2022-03-01 11:42     ` Gerd Hoffmann
2022-03-03  3:25       ` Gavin Shan
2022-03-04  8:46         ` Gerd Hoffmann
2022-03-04 10:52         ` Igor Mammedov
2022-03-04 10:58           ` Peter Maydell
2022-03-04 14:24             ` Laszlo Ersek
2022-03-07  7:13               ` Shan Gavin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOL5Tw=E1iEALPt3H5-T9Tizg3DMpUH8dueiPuuiSvz51AY8UQ@mail.gmail.com' \
    --to=shan.gavin@gmail.com \
    --cc=drjones@redhat.com \
    --cc=gshan@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.