From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE7BC6787C for ; Sun, 14 Oct 2018 13:21:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F1C720652 for ; Sun, 14 Oct 2018 13:21:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M4QK1ccb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F1C720652 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726401AbeJNVCe (ORCPT ); Sun, 14 Oct 2018 17:02:34 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:34698 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbeJNVCe (ORCPT ); Sun, 14 Oct 2018 17:02:34 -0400 Received: by mail-pl1-f196.google.com with SMTP id f18-v6so8004919plr.1; Sun, 14 Oct 2018 06:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3p7rOh3EHCcs5xJhBdJ9os0FBYpeHAf7F1aAnqF/f30=; b=M4QK1ccb/idnXeaKqj+Ewbkhcgm7CdlXT/yTIpkXgaATox26SQJltMaTvHPGPG79xb 8FdicVlinm6TH9QQZywahbCsqU2Qo2cEeNF/BnNBRbcLzSuKYDeFaDlRsj9PNMtQl5/u ZX4AYSOkwd0qBIZSPiNXtPkByaFmv+vy/1D1182c0mcu5ApITPdk/hdFU1kMcAg5ZMkg VsR+cVaH4ChJ8jYBsBoXC7i04fwmIuiOlMYd8Hl4YZnQbq7dclEzhNcqcApiQBoSECiM GrKvFRQUSNqIOucytr38BPo65LejZNhIRfZwDzWlLHOw8Mlxuq6P6JkUPEi+BT/bzRTj FQbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3p7rOh3EHCcs5xJhBdJ9os0FBYpeHAf7F1aAnqF/f30=; b=jHXvbbnZnZpS1f6ZgpisjJ9mfYXH1tDZrV/sWMb1ShpmR2v/vxO+oc9DKH6eiUnQy/ xLhgY9FeI3WhruBpPfX5wsMBx/PDF/cLvy58IZEJ0Nv/AehefFKgjCC00JN6KCPXZB2x Q0med2EbGJpRACBJ4SZ23HB6xUyFtx+bCQ3YM/9rqj1hQDEebXUoMGcEcgzPtWz8ZJT0 pPGSd32fqmUbYH4sA1pqtFXr5A6sy/mCBVhWld4PhUC2zwiHB9YNdzXOoURTV0vIv4fn FFzr7+YEKYHs8JVo3KLdEBE3pwQGATsO0B9YKonkTOeFtbkMqT2p0YkybrlcbF+Wbawg tG7Q== X-Gm-Message-State: ABuFfoiDMXBlhHGuS1BfXpsVTGpt20fAT2TraNNmlCnN4S6ludI9bsmW c7GX0nDwgXjJ+1aVtTy7TE5ydsbS6WtotCkN5R6q0EBsGax6Tw== X-Google-Smtp-Source: ACcGV60Bsdv+2lbefbGLxTexZhfM8a9SDOpaKx+exqAsk4LqnWktEAF8KcHNub/RKj7H2PyE8ha/L2lfpnhhtHYxQ0w= X-Received: by 2002:a17:902:da4:: with SMTP id 33-v6mr12916512plv.172.1539523294880; Sun, 14 Oct 2018 06:21:34 -0700 (PDT) MIME-Version: 1.0 References: <20181013145406.4911-1-Tianyu.Lan@microsoft.com> <20181013145406.4911-3-Tianyu.Lan@microsoft.com> <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> <20181014092734.GV30658@n2100.armlinux.org.uk> <20181014093541.GW30658@n2100.armlinux.org.uk> In-Reply-To: <20181014093541.GW30658@n2100.armlinux.org.uk> From: Tianyu Lan Date: Sun, 14 Oct 2018 21:21:23 +0800 Message-ID: Subject: Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function To: linux@armlinux.org.uk Cc: Thomas Gleixner , linux-mips@linux-mips.org, linux@armlinux.org, kvm , Radim Krcmar , benh@kernel.crashing.org, will.deacon@arm.com, christoffer.dall@arm.com, paulus@ozlabs.org, "H. Peter Anvin" , kys@microsoft.com, kvmarm@lists.cs.columbia.edu, sthemmin@microsoft.com, mpe@ellerman.id.au, "the arch/x86 maintainers" , michael.h.kelley@microsoft.com, Ingo Molnar , catalin.marinas@arm.com, jhogan@kernel.org, Tianyu Lan , marc.zyngier@arm.com, haiyangz@microsoft.com, kvm-ppc@vger.kernel.org, liran.alon@oracle.com, Paolo Bonzini , linux-arm-kernel@lists.infradead.org, "linux-kernel@vger kernel org" , ralf@linux-mips.org, paul.burton@mips.com, devel@linuxdriverproject.org, vkuznets@redhat.com, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Russell: Thanks for your review. On Sun, Oct 14, 2018 at 5:36 PM Russell King - ARM Linux wrote: > > On Sun, Oct 14, 2018 at 10:27:34AM +0100, Russell King - ARM Linux wrote: > > On Sun, Oct 14, 2018 at 10:16:56AM +0200, Thomas Gleixner wrote: > > > On Sun, 14 Oct 2018, Liran Alon wrote: > > > > > On 13 Oct 2018, at 17:53, lantianyu1986@gmail.com wrote: > > > > > > > > > > From: Lan Tianyu > > > > > > > > > > This patch is to add wrapper functions for tlb_remote_flush_with_= range > > > > > callback. > > > > > > > > > > Signed-off-by: Lan Tianyu > > > > > --- > > > > > Change sicne V3: > > > > > Remove code of updating "tlbs_dirty" > > > > > Change since V2: > > > > > Fix comment in the kvm_flush_remote_tlbs_with_range() > > > > > --- > > > > > arch/x86/kvm/mmu.c | 40 ++++++++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 40 insertions(+) > > > > > > > > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > > > > > index c73d9f650de7..ff656d85903a 100644 > > > > > --- a/arch/x86/kvm/mmu.c > > > > > +++ b/arch/x86/kvm/mmu.c > > > > > @@ -264,6 +264,46 @@ static void mmu_spte_set(u64 *sptep, u64 spt= e); > > > > > static union kvm_mmu_page_role > > > > > kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu); > > > > > > > > > > + > > > > > +static inline bool kvm_available_flush_tlb_with_range(void) > > > > > +{ > > > > > + return kvm_x86_ops->tlb_remote_flush_with_range; > > > > > +} > > > > > > > > Seems that kvm_available_flush_tlb_with_range() is not used in this= patch=E2=80=A6 > > > > > > What's wrong with that? > > > > > > It provides the implementation and later patches make use of it. It's= a > > > sensible way to split patches into small, self contained entities. > > > > From what I can see of the patches that follow _this_ patch in the > > series, this function remains unused. So, not only is it not used > > in this patch, it's not used in this series. > > Note - I seem to have only received patches 1 through 4, so this is > based on the patches I've received. > Sorry to confuse your. I get from CCers from get_maintainer.pl script. The next patch "[PATCH V4 3/15]KVM: Replace old tlb flush function with new one to flush a specified range" calls new function. https://lkml.org/lkml/2018/10/13/254 The patch "[PATCH V4 4/15] KVM: Make kvm_set_spte_hva() return int" changes under ARM directory. Please have a look. Thanks. --=20 Best regards Tianyu Lan From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-x642.google.com ([IPv6:2607:f8b0:4864:20::642]:38240 "EHLO mail-pl1-x642.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23990490AbeJNNVlqK85g convert rfc822-to-8bit (ORCPT ); Sun, 14 Oct 2018 15:21:41 +0200 MIME-Version: 1.0 References: <20181013145406.4911-1-Tianyu.Lan@microsoft.com> <20181013145406.4911-3-Tianyu.Lan@microsoft.com> <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> <20181014092734.GV30658@n2100.armlinux.org.uk> <20181014093541.GW30658@n2100.armlinux.org.uk> In-Reply-To: <20181014093541.GW30658@n2100.armlinux.org.uk> From: Tianyu Lan Date: Sun, 14 Oct 2018 21:21:23 +0800 Message-ID: Subject: Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: linux@armlinux.org.uk Cc: Thomas Gleixner , linux-mips@linux-mips.org, kvm , Radim Krcmar , benh@kernel.crashing.org, will.deacon@arm.com, christoffer.dall@arm.com, paulus@ozlabs.org, "H. Peter Anvin" , kys@microsoft.com, kvmarm@lists.cs.columbia.edu, sthemmin@microsoft.com, mpe@ellerman.id.au, the arch/x86 maintainers , michael.h.kelley@microsoft.com, Ingo Molnar , catalin.marinas@arm.com, jhogan@kernel.org, Tianyu Lan , marc.zyngier@arm.com, haiyangz@microsoft.com, kvm-ppc@vger.kernel.org, liran.alon@oracle.com, Paolo Bonzini , linux-arm-kernel@lists.infradead.org, "linux-kernel@vger kernel org" , ralf@linux-mips.org, paul.burton@mips.com, devel@linuxdriverproject.org, vkuznets@redhat.com, linuxppc-dev@lists.ozlabs.org Message-ID: <20181014132123.nBhJAgzJJbwudgKFdXZjou8BhOxZM5Bb2QOg-35daUU@z> Hi Russell: Thanks for your review. On Sun, Oct 14, 2018 at 5:36 PM Russell King - ARM Linux wrote: > > On Sun, Oct 14, 2018 at 10:27:34AM +0100, Russell King - ARM Linux wrote: > > On Sun, Oct 14, 2018 at 10:16:56AM +0200, Thomas Gleixner wrote: > > > On Sun, 14 Oct 2018, Liran Alon wrote: > > > > > On 13 Oct 2018, at 17:53, lantianyu1986@gmail.com wrote: > > > > > > > > > > From: Lan Tianyu > > > > > > > > > > This patch is to add wrapper functions for tlb_remote_flush_with_range > > > > > callback. > > > > > > > > > > Signed-off-by: Lan Tianyu > > > > > --- > > > > > Change sicne V3: > > > > > Remove code of updating "tlbs_dirty" > > > > > Change since V2: > > > > > Fix comment in the kvm_flush_remote_tlbs_with_range() > > > > > --- > > > > > arch/x86/kvm/mmu.c | 40 ++++++++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 40 insertions(+) > > > > > > > > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > > > > > index c73d9f650de7..ff656d85903a 100644 > > > > > --- a/arch/x86/kvm/mmu.c > > > > > +++ b/arch/x86/kvm/mmu.c > > > > > @@ -264,6 +264,46 @@ static void mmu_spte_set(u64 *sptep, u64 spte); > > > > > static union kvm_mmu_page_role > > > > > kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu); > > > > > > > > > > + > > > > > +static inline bool kvm_available_flush_tlb_with_range(void) > > > > > +{ > > > > > + return kvm_x86_ops->tlb_remote_flush_with_range; > > > > > +} > > > > > > > > Seems that kvm_available_flush_tlb_with_range() is not used in this patch… > > > > > > What's wrong with that? > > > > > > It provides the implementation and later patches make use of it. It's a > > > sensible way to split patches into small, self contained entities. > > > > From what I can see of the patches that follow _this_ patch in the > > series, this function remains unused. So, not only is it not used > > in this patch, it's not used in this series. > > Note - I seem to have only received patches 1 through 4, so this is > based on the patches I've received. > Sorry to confuse your. I get from CCers from get_maintainer.pl script. The next patch "[PATCH V4 3/15]KVM: Replace old tlb flush function with new one to flush a specified range" calls new function. https://lkml.org/lkml/2018/10/13/254 The patch "[PATCH V4 4/15] KVM: Make kvm_set_spte_hva() return int" changes under ARM directory. Please have a look. Thanks. -- Best regards Tianyu Lan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tianyu Lan Subject: Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function Date: Sun, 14 Oct 2018 21:21:23 +0800 Message-ID: References: <20181013145406.4911-1-Tianyu.Lan@microsoft.com> <20181013145406.4911-3-Tianyu.Lan@microsoft.com> <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> <20181014092734.GV30658@n2100.armlinux.org.uk> <20181014093541.GW30658@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: linux-mips@linux-mips.org, linux@armlinux.org, kvm , Radim Krcmar , benh@kernel.crashing.org, will.deacon@arm.com, "linux-kernel@vger kernel org" , paulus@ozlabs.org, "H. Peter Anvin" , kvmarm@lists.cs.columbia.edu, sthemmin@microsoft.com, mpe@ellerman.id.au, the arch/x86 maintainers , michael.h.kelley@microsoft.com, Ingo Molnar , catalin.marinas@arm.com, jhogan@kernel.org, Tianyu Lan , marc.zyngier@arm.com, haiyangz@microsoft.com, kvm-ppc@vger.kernel.org, liran.alon@oracle.com, devel@linuxdriverproject.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, christoffer.dall@arm.com, ralf@linux-mips.org, paul.burton@mips.com, Paolo Bonzini , vkuznets@redhat.com, linuxppc-dev@lists.o To: linux@armlinux.org.uk Return-path: In-Reply-To: <20181014093541.GW30658@n2100.armlinux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: kvm.vger.kernel.org SGkgUnVzc2VsbDoKICAgICAgICAgICAgICBUaGFua3MgZm9yIHlvdXIgcmV2aWV3LgoKT24gU3Vu LCBPY3QgMTQsIDIwMTggYXQgNTozNiBQTSBSdXNzZWxsIEtpbmcgLSBBUk0gTGludXgKPGxpbnV4 QGFybWxpbnV4Lm9yZy51az4gd3JvdGU6Cj4KPiBPbiBTdW4sIE9jdCAxNCwgMjAxOCBhdCAxMDoy NzozNEFNICswMTAwLCBSdXNzZWxsIEtpbmcgLSBBUk0gTGludXggd3JvdGU6Cj4gPiBPbiBTdW4s IE9jdCAxNCwgMjAxOCBhdCAxMDoxNjo1NkFNICswMjAwLCBUaG9tYXMgR2xlaXhuZXIgd3JvdGU6 Cj4gPiA+IE9uIFN1biwgMTQgT2N0IDIwMTgsIExpcmFuIEFsb24gd3JvdGU6Cj4gPiA+ID4gPiBP biAxMyBPY3QgMjAxOCwgYXQgMTc6NTMsIGxhbnRpYW55dTE5ODZAZ21haWwuY29tIHdyb3RlOgo+ ID4gPiA+ID4KPiA+ID4gPiA+IEZyb206IExhbiBUaWFueXUgPFRpYW55dS5MYW5AbWljcm9zb2Z0 LmNvbT4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBUaGlzIHBhdGNoIGlzIHRvIGFkZCB3cmFwcGVyIGZ1 bmN0aW9ucyBmb3IgdGxiX3JlbW90ZV9mbHVzaF93aXRoX3JhbmdlCj4gPiA+ID4gPiBjYWxsYmFj ay4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBMYW4gVGlhbnl1IDxUaWFueXUu TGFuQG1pY3Jvc29mdC5jb20+Cj4gPiA+ID4gPiAtLS0KPiA+ID4gPiA+IENoYW5nZSBzaWNuZSBW MzoKPiA+ID4gPiA+ICAgICAgIFJlbW92ZSBjb2RlIG9mIHVwZGF0aW5nICJ0bGJzX2RpcnR5Igo+ ID4gPiA+ID4gQ2hhbmdlIHNpbmNlIFYyOgo+ID4gPiA+ID4gICAgICAgRml4IGNvbW1lbnQgaW4g dGhlIGt2bV9mbHVzaF9yZW1vdGVfdGxic193aXRoX3JhbmdlKCkKPiA+ID4gPiA+IC0tLQo+ID4g PiA+ID4gYXJjaC94ODYva3ZtL21tdS5jIHwgNDAgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKwo+ID4gPiA+ID4gMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKykK PiA+ID4gPiA+Cj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvYXJjaC94ODYva3ZtL21tdS5jIGIvYXJj aC94ODYva3ZtL21tdS5jCj4gPiA+ID4gPiBpbmRleCBjNzNkOWY2NTBkZTcuLmZmNjU2ZDg1OTAz YSAxMDA2NDQKPiA+ID4gPiA+IC0tLSBhL2FyY2gveDg2L2t2bS9tbXUuYwo+ID4gPiA+ID4gKysr IGIvYXJjaC94ODYva3ZtL21tdS5jCj4gPiA+ID4gPiBAQCAtMjY0LDYgKzI2NCw0NiBAQCBzdGF0 aWMgdm9pZCBtbXVfc3B0ZV9zZXQodTY0ICpzcHRlcCwgdTY0IHNwdGUpOwo+ID4gPiA+ID4gc3Rh dGljIHVuaW9uIGt2bV9tbXVfcGFnZV9yb2xlCj4gPiA+ID4gPiBrdm1fbW11X2NhbGNfcm9vdF9w YWdlX3JvbGUoc3RydWN0IGt2bV92Y3B1ICp2Y3B1KTsKPiA+ID4gPiA+Cj4gPiA+ID4gPiArCj4g PiA+ID4gPiArc3RhdGljIGlubGluZSBib29sIGt2bV9hdmFpbGFibGVfZmx1c2hfdGxiX3dpdGhf cmFuZ2Uodm9pZCkKPiA+ID4gPiA+ICt7Cj4gPiA+ID4gPiArICAgICAgIHJldHVybiBrdm1feDg2 X29wcy0+dGxiX3JlbW90ZV9mbHVzaF93aXRoX3JhbmdlOwo+ID4gPiA+ID4gK30KPiA+ID4gPgo+ ID4gPiA+IFNlZW1zIHRoYXQga3ZtX2F2YWlsYWJsZV9mbHVzaF90bGJfd2l0aF9yYW5nZSgpIGlz IG5vdCB1c2VkIGluIHRoaXMgcGF0Y2jigKYKPiA+ID4KPiA+ID4gV2hhdCdzIHdyb25nIHdpdGgg dGhhdD8KPiA+ID4KPiA+ID4gSXQgcHJvdmlkZXMgdGhlIGltcGxlbWVudGF0aW9uIGFuZCBsYXRl ciBwYXRjaGVzIG1ha2UgdXNlIG9mIGl0LiBJdCdzIGEKPiA+ID4gc2Vuc2libGUgd2F5IHRvIHNw bGl0IHBhdGNoZXMgaW50byBzbWFsbCwgc2VsZiBjb250YWluZWQgZW50aXRpZXMuCj4gPgo+ID4g RnJvbSB3aGF0IEkgY2FuIHNlZSBvZiB0aGUgcGF0Y2hlcyB0aGF0IGZvbGxvdyBfdGhpc18gcGF0 Y2ggaW4gdGhlCj4gPiBzZXJpZXMsIHRoaXMgZnVuY3Rpb24gcmVtYWlucyB1bnVzZWQuICBTbywg bm90IG9ubHkgaXMgaXQgbm90IHVzZWQKPiA+IGluIHRoaXMgcGF0Y2gsIGl0J3Mgbm90IHVzZWQg aW4gdGhpcyBzZXJpZXMuCj4KPiBOb3RlIC0gSSBzZWVtIHRvIGhhdmUgb25seSByZWNlaXZlZCBw YXRjaGVzIDEgdGhyb3VnaCA0LCBzbyB0aGlzIGlzCj4gYmFzZWQgb24gdGhlIHBhdGNoZXMgSSd2 ZSByZWNlaXZlZC4KPgoKU29ycnkgdG8gY29uZnVzZSB5b3VyLiBJIGdldCBmcm9tIENDZXJzIGZy b20gZ2V0X21haW50YWluZXIucGwgc2NyaXB0LgpUaGUgbmV4dCBwYXRjaCAiW1BBVENIIFY0IDMv MTVdS1ZNOiBSZXBsYWNlIG9sZCB0bGIgZmx1c2ggZnVuY3Rpb24gd2l0aApuZXcgb25lIHRvIGZs dXNoIGEgc3BlY2lmaWVkIHJhbmdlIiBjYWxscyBuZXcgZnVuY3Rpb24uCmh0dHBzOi8vbGttbC5v cmcvbGttbC8yMDE4LzEwLzEzLzI1NAoKVGhlIHBhdGNoICJbUEFUQ0ggVjQgNC8xNV0gS1ZNOiBN YWtlIGt2bV9zZXRfc3B0ZV9odmEoKSByZXR1cm4gaW50IgpjaGFuZ2VzIHVuZGVyIEFSTSBkaXJl Y3RvcnkuIFBsZWFzZSBoYXZlIGEgbG9vay4gVGhhbmtzLgotLSAKQmVzdCByZWdhcmRzClRpYW55 dSBMYW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZGV2 ZWwgbWFpbGluZyBsaXN0CmRldmVsQGxpbnV4ZHJpdmVycHJvamVjdC5vcmcKaHR0cDovL2RyaXZl cmRldi5saW51eGRyaXZlcnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vZHJpdmVyZGV2LWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85EC6C6787C for ; Sun, 14 Oct 2018 13:24:01 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C415220659 for ; Sun, 14 Oct 2018 13:24:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M4QK1ccb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C415220659 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42Y2My3nxQzDsGh for ; Mon, 15 Oct 2018 00:23:58 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="M4QK1ccb"; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::644; helo=mail-pl1-x644.google.com; envelope-from=lantianyu1986@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="M4QK1ccb"; dkim-atps=neutral Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42Y2KF07GnzF39c for ; Mon, 15 Oct 2018 00:21:36 +1100 (AEDT) Received: by mail-pl1-x644.google.com with SMTP id c8-v6so7986975plo.9 for ; Sun, 14 Oct 2018 06:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3p7rOh3EHCcs5xJhBdJ9os0FBYpeHAf7F1aAnqF/f30=; b=M4QK1ccb/idnXeaKqj+Ewbkhcgm7CdlXT/yTIpkXgaATox26SQJltMaTvHPGPG79xb 8FdicVlinm6TH9QQZywahbCsqU2Qo2cEeNF/BnNBRbcLzSuKYDeFaDlRsj9PNMtQl5/u ZX4AYSOkwd0qBIZSPiNXtPkByaFmv+vy/1D1182c0mcu5ApITPdk/hdFU1kMcAg5ZMkg VsR+cVaH4ChJ8jYBsBoXC7i04fwmIuiOlMYd8Hl4YZnQbq7dclEzhNcqcApiQBoSECiM GrKvFRQUSNqIOucytr38BPo65LejZNhIRfZwDzWlLHOw8Mlxuq6P6JkUPEi+BT/bzRTj FQbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3p7rOh3EHCcs5xJhBdJ9os0FBYpeHAf7F1aAnqF/f30=; b=EUEsVjNaqD9mTRMk8ozEJe3isZhbS7GrNi8ZbNAymVVLyKY6gZmNoN58L0gAE74Op6 WMl2Py3mcGxhiiTuRSPPcFRhX+6HDCjFbyCOZUhXh+QeH/hsi5WBIENkhQ/ZgYMWc5cx jbWqTfrHFUNpXfK78joPRhnkOi2qPoVmsc475Y1yE2wtE5CuwB77cNT0xNOLzVFatCGx wCEIC6nMY810ZGY5MBhnJox5bu3TP8kBOq5eZoLSuQ6B0+ileeE28+RgfxXryxMUpCZd QyjSEruYT6YZOZos6JubjKjyEPihWjlJ4Fzv9IBSNf6yHmGsGxZnP7hXypEUqWNqecs9 v06g== X-Gm-Message-State: ABuFfojBTKkWpQH/ErCwmv2mOymjLdI5Kw/GEmKXWFvqWWGmjOAUnPAP xlLD1s+hR5FSor3PAi37SUrw0vQyi++sIaTi/DE= X-Google-Smtp-Source: ACcGV60Bsdv+2lbefbGLxTexZhfM8a9SDOpaKx+exqAsk4LqnWktEAF8KcHNub/RKj7H2PyE8ha/L2lfpnhhtHYxQ0w= X-Received: by 2002:a17:902:da4:: with SMTP id 33-v6mr12916512plv.172.1539523294880; Sun, 14 Oct 2018 06:21:34 -0700 (PDT) MIME-Version: 1.0 References: <20181013145406.4911-1-Tianyu.Lan@microsoft.com> <20181013145406.4911-3-Tianyu.Lan@microsoft.com> <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> <20181014092734.GV30658@n2100.armlinux.org.uk> <20181014093541.GW30658@n2100.armlinux.org.uk> In-Reply-To: <20181014093541.GW30658@n2100.armlinux.org.uk> From: Tianyu Lan Date: Sun, 14 Oct 2018 21:21:23 +0800 Message-ID: Subject: Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function To: linux@armlinux.org.uk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mips@linux-mips.org, linux@armlinux.org, kvm , Radim Krcmar , will.deacon@arm.com, "linux-kernel@vger kernel org" , "H. Peter Anvin" , kys@microsoft.com, kvmarm@lists.cs.columbia.edu, sthemmin@microsoft.com, the arch/x86 maintainers , michael.h.kelley@microsoft.com, Ingo Molnar , catalin.marinas@arm.com, jhogan@kernel.org, Tianyu Lan , marc.zyngier@arm.com, haiyangz@microsoft.com, kvm-ppc@vger.kernel.org, liran.alon@oracle.com, devel@linuxdriverproject.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, christoffer.dall@arm.com, ralf@linux-mips.org, paul.burton@mips.com, Paolo Bonzini , vkuznets@redhat.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Russell: Thanks for your review. On Sun, Oct 14, 2018 at 5:36 PM Russell King - ARM Linux wrote: > > On Sun, Oct 14, 2018 at 10:27:34AM +0100, Russell King - ARM Linux wrote: > > On Sun, Oct 14, 2018 at 10:16:56AM +0200, Thomas Gleixner wrote: > > > On Sun, 14 Oct 2018, Liran Alon wrote: > > > > > On 13 Oct 2018, at 17:53, lantianyu1986@gmail.com wrote: > > > > > > > > > > From: Lan Tianyu > > > > > > > > > > This patch is to add wrapper functions for tlb_remote_flush_with_= range > > > > > callback. > > > > > > > > > > Signed-off-by: Lan Tianyu > > > > > --- > > > > > Change sicne V3: > > > > > Remove code of updating "tlbs_dirty" > > > > > Change since V2: > > > > > Fix comment in the kvm_flush_remote_tlbs_with_range() > > > > > --- > > > > > arch/x86/kvm/mmu.c | 40 ++++++++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 40 insertions(+) > > > > > > > > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > > > > > index c73d9f650de7..ff656d85903a 100644 > > > > > --- a/arch/x86/kvm/mmu.c > > > > > +++ b/arch/x86/kvm/mmu.c > > > > > @@ -264,6 +264,46 @@ static void mmu_spte_set(u64 *sptep, u64 spt= e); > > > > > static union kvm_mmu_page_role > > > > > kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu); > > > > > > > > > > + > > > > > +static inline bool kvm_available_flush_tlb_with_range(void) > > > > > +{ > > > > > + return kvm_x86_ops->tlb_remote_flush_with_range; > > > > > +} > > > > > > > > Seems that kvm_available_flush_tlb_with_range() is not used in this= patch=E2=80=A6 > > > > > > What's wrong with that? > > > > > > It provides the implementation and later patches make use of it. It's= a > > > sensible way to split patches into small, self contained entities. > > > > From what I can see of the patches that follow _this_ patch in the > > series, this function remains unused. So, not only is it not used > > in this patch, it's not used in this series. > > Note - I seem to have only received patches 1 through 4, so this is > based on the patches I've received. > Sorry to confuse your. I get from CCers from get_maintainer.pl script. The next patch "[PATCH V4 3/15]KVM: Replace old tlb flush function with new one to flush a specified range" calls new function. https://lkml.org/lkml/2018/10/13/254 The patch "[PATCH V4 4/15] KVM: Make kvm_set_spte_hva() return int" changes under ARM directory. Please have a look. Thanks. --=20 Best regards Tianyu Lan From mboxrd@z Thu Jan 1 00:00:00 1970 From: lantianyu1986@gmail.com (Tianyu Lan) Date: Sun, 14 Oct 2018 21:21:23 +0800 Subject: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function In-Reply-To: <20181014093541.GW30658@n2100.armlinux.org.uk> References: <20181013145406.4911-1-Tianyu.Lan@microsoft.com> <20181013145406.4911-3-Tianyu.Lan@microsoft.com> <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> <20181014092734.GV30658@n2100.armlinux.org.uk> <20181014093541.GW30658@n2100.armlinux.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Russell: Thanks for your review. On Sun, Oct 14, 2018 at 5:36 PM Russell King - ARM Linux wrote: > > On Sun, Oct 14, 2018 at 10:27:34AM +0100, Russell King - ARM Linux wrote: > > On Sun, Oct 14, 2018 at 10:16:56AM +0200, Thomas Gleixner wrote: > > > On Sun, 14 Oct 2018, Liran Alon wrote: > > > > > On 13 Oct 2018, at 17:53, lantianyu1986 at gmail.com wrote: > > > > > > > > > > From: Lan Tianyu > > > > > > > > > > This patch is to add wrapper functions for tlb_remote_flush_with_range > > > > > callback. > > > > > > > > > > Signed-off-by: Lan Tianyu > > > > > --- > > > > > Change sicne V3: > > > > > Remove code of updating "tlbs_dirty" > > > > > Change since V2: > > > > > Fix comment in the kvm_flush_remote_tlbs_with_range() > > > > > --- > > > > > arch/x86/kvm/mmu.c | 40 ++++++++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 40 insertions(+) > > > > > > > > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > > > > > index c73d9f650de7..ff656d85903a 100644 > > > > > --- a/arch/x86/kvm/mmu.c > > > > > +++ b/arch/x86/kvm/mmu.c > > > > > @@ -264,6 +264,46 @@ static void mmu_spte_set(u64 *sptep, u64 spte); > > > > > static union kvm_mmu_page_role > > > > > kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu); > > > > > > > > > > + > > > > > +static inline bool kvm_available_flush_tlb_with_range(void) > > > > > +{ > > > > > + return kvm_x86_ops->tlb_remote_flush_with_range; > > > > > +} > > > > > > > > Seems that kvm_available_flush_tlb_with_range() is not used in this patch? > > > > > > What's wrong with that? > > > > > > It provides the implementation and later patches make use of it. It's a > > > sensible way to split patches into small, self contained entities. > > > > From what I can see of the patches that follow _this_ patch in the > > series, this function remains unused. So, not only is it not used > > in this patch, it's not used in this series. > > Note - I seem to have only received patches 1 through 4, so this is > based on the patches I've received. > Sorry to confuse your. I get from CCers from get_maintainer.pl script. The next patch "[PATCH V4 3/15]KVM: Replace old tlb flush function with new one to flush a specified range" calls new function. https://lkml.org/lkml/2018/10/13/254 The patch "[PATCH V4 4/15] KVM: Make kvm_set_spte_hva() return int" changes under ARM directory. Please have a look. Thanks. -- Best regards Tianyu Lan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tianyu Lan Date: Sun, 14 Oct 2018 13:21:23 +0000 Subject: Re: [PATCH V4 2/15] KVM/MMU: Add tlb flush with range helper function Message-Id: List-Id: References: <20181013145406.4911-1-Tianyu.Lan@microsoft.com> <20181013145406.4911-3-Tianyu.Lan@microsoft.com> <4D709C3A-A91C-4CA7-922A-E77618EF21B4@oracle.com> <20181014092734.GV30658@n2100.armlinux.org.uk> <20181014093541.GW30658@n2100.armlinux.org.uk> In-Reply-To: <20181014093541.GW30658@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: linux@armlinux.org.uk Cc: Thomas Gleixner , linux-mips@linux-mips.org, linux@armlinux.org, kvm , Radim Krcmar , benh@kernel.crashing.org, will.deacon@arm.com, christoffer.dall@arm.com, paulus@ozlabs.org, "H. Peter Anvin" , kys@microsoft.com, kvmarm@lists.cs.columbia.edu, sthemmin@microsoft.com, mpe@ellerman.id.au, the arch/x86 maintainers , michael.h.kelley@microsoft.com, Ingo Molnar , catalin.marinas@arm.com, jhogan@kernel.org, Tianyu Lan , marc.zyngier@arm.com, haiyangz@microsoft.com, kvm-ppc@vger.kernel.org, liran.alon@oracle.com, Paolo Bonzini , linux-arm-kernel@lists.infradead.org, "linux-kernel@vger kernel org" , ralf@linux-mips.org, paul.burton@mips.com, devel@linuxdriverproject.org, vkuznets@redhat.com, linuxppc-dev@lists.ozlabs.org Hi Russell: Thanks for your review. On Sun, Oct 14, 2018 at 5:36 PM Russell King - ARM Linux wrote: > > On Sun, Oct 14, 2018 at 10:27:34AM +0100, Russell King - ARM Linux wrote: > > On Sun, Oct 14, 2018 at 10:16:56AM +0200, Thomas Gleixner wrote: > > > On Sun, 14 Oct 2018, Liran Alon wrote: > > > > > On 13 Oct 2018, at 17:53, lantianyu1986@gmail.com wrote: > > > > > > > > > > From: Lan Tianyu > > > > > > > > > > This patch is to add wrapper functions for tlb_remote_flush_with_= range > > > > > callback. > > > > > > > > > > Signed-off-by: Lan Tianyu > > > > > --- > > > > > Change sicne V3: > > > > > Remove code of updating "tlbs_dirty" > > > > > Change since V2: > > > > > Fix comment in the kvm_flush_remote_tlbs_with_range() > > > > > --- > > > > > arch/x86/kvm/mmu.c | 40 ++++++++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 40 insertions(+) > > > > > > > > > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > > > > > index c73d9f650de7..ff656d85903a 100644 > > > > > --- a/arch/x86/kvm/mmu.c > > > > > +++ b/arch/x86/kvm/mmu.c > > > > > @@ -264,6 +264,46 @@ static void mmu_spte_set(u64 *sptep, u64 spt= e); > > > > > static union kvm_mmu_page_role > > > > > kvm_mmu_calc_root_page_role(struct kvm_vcpu *vcpu); > > > > > > > > > > + > > > > > +static inline bool kvm_available_flush_tlb_with_range(void) > > > > > +{ > > > > > + return kvm_x86_ops->tlb_remote_flush_with_range; > > > > > +} > > > > > > > > Seems that kvm_available_flush_tlb_with_range() is not used in this= patch=E2=80=A6 > > > > > > What's wrong with that? > > > > > > It provides the implementation and later patches make use of it. It's= a > > > sensible way to split patches into small, self contained entities. > > > > From what I can see of the patches that follow _this_ patch in the > > series, this function remains unused. So, not only is it not used > > in this patch, it's not used in this series. > > Note - I seem to have only received patches 1 through 4, so this is > based on the patches I've received. > Sorry to confuse your. I get from CCers from get_maintainer.pl script. The next patch "[PATCH V4 3/15]KVM: Replace old tlb flush function with new one to flush a specified range" calls new function. https://lkml.org/lkml/2018/10/13/254 The patch "[PATCH V4 4/15] KVM: Make kvm_set_spte_hva() return int" changes under ARM directory. Please have a look. Thanks. --=20 Best regards Tianyu Lan