From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, MAILING_LIST_MULTI,MISSING_HEADERS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C81EC433B4 for ; Wed, 19 May 2021 22:14:54 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47B576124C for ; Wed, 19 May 2021 22:14:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47B576124C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FlnGz4nFhz302V for ; Thu, 20 May 2021 08:14:51 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=rGSpNfu7; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=google.com (client-ip=2607:f8b0:4864:20::b33; helo=mail-yb1-xb33.google.com; envelope-from=nanzhou@google.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=rGSpNfu7; dkim-atps=neutral Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FlnGW435xz2xg6 for ; Thu, 20 May 2021 08:14:24 +1000 (AEST) Received: by mail-yb1-xb33.google.com with SMTP id l7so20118122ybf.8 for ; Wed, 19 May 2021 15:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:cc; bh=iARP6YjHl6+2jq1uhzlU9W3sxz7XCuoQL7Ia4n6sAGU=; b=rGSpNfu7t/VBb4nsT0qzTbLOeA62XB2wOh1IzR6j0sCcDKGUKd2IPrzDKQEWzrqZVM p1dJ9p8p/WP9RQsOajHBlm2ygU6HZq2J3l7rzue4zqhq/RwEvt5Uul3KFp0qwBHZmskO z5z4I4nrl2SdNAKkivS8Ne/Gj3kBc1N57NA9zjtOqg0RJp0R6EWcb77uJMSgCj8vL/AN 7eWrc6swxNT+KlSeP58xToSpjTK+SJ9C8daLDdWhlCQyJG4LQ6GcWKYkAJuPLH0DCZfl nYBp5FjXwrg9oSAuThIDo9c/LfrwQg31dhKJ+/OrLO7DBLi3ilih0FQMxg9WtCH8CRhk zNEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc; bh=iARP6YjHl6+2jq1uhzlU9W3sxz7XCuoQL7Ia4n6sAGU=; b=kkWFgJZoZ1bIYeKiC+PMxTs2wSkb1b96FYUeG6bfKFzvjf0Q5jdj1JTk9H+HnlJle9 5wh5532nqfF/L7v8t5CHa7m1aSgT7S61Z4cOG9rFXpgjihmY3wdS9HkI/LbCGqsW6mq1 ibQwLMhcx+oX59n7XdW1wKqgORjul4aMvwKYKpdZGOPfUQV4Kwgc7qxtNp29PEJytDWm kfI2rqDNq8EPp1opyOo8QErrq3QMUBsa6zUXz35Yi+8xFiXKUQPUkS80HcTQ6+0xw9dy YUXnlbChSUkAUwyJJDck6rlGpTfWmAPp90asG+JhnNTdokDYBX6wSr6OmWPBVKgiHX3B 05ng== X-Gm-Message-State: AOAM531PWGhqO2yquy2SXPIQKsK8oheyHCt3KStf3x1xKviaApk9vH5P Jpp5znnbSznAkGlGLt8+UBnDr8saCE10vv+J2twEBBOkMjfxDw== X-Received: by 2002:a25:b112:: with SMTP id g18mt2559588ybj.281.1621462459941; Wed, 19 May 2021 15:14:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nan Zhou Date: Wed, 19 May 2021 15:14:09 -0700 Message-ID: Subject: Re: SimpleStorage proposals Content-Type: multipart/alternative; boundary="000000000000f2640005c2b6254b" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "openbmc@lists.ozlabs.org" , "bradleyb@fuzziesquirrel.com" , =?UTF-8?B?SnVuLUxpbiBDaGVuICjpmbPkv4rpnJYp?= Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" --000000000000f2640005c2b6254b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > > > > Thanks for your reply, Ed! > > > >> > >> You've also omitted what properties you're trying to target. Could > >> you walk through a little bit about what you're trying to accomplish > >> with this? (beyond just "implement the redfish schemas). Are you > >> trying to get smart data? just inventory information? Do you plan to > >> represent connections? > > > > > > As a first step, we are only going to implement three properties, Name, > Presence, and PowerStatus. We don't plan to represent connections at the > moment. > I'm assuming these will be the dbus properties names, as redfish > doesn't really have a presence property or a powerstatus property. > With that said, that seems reasonable to me to want to do, but we need > to make sure we're clear on how this differs from the existing Drive > interfaces. Hi Ed, the presence I am talking about is kind of a logical concept. You can find the dbus and redfish properties in the proposal. I believe we plan to use the following mappings, dbus redifish logical State(enabled) Device#Status#State If state is "enabled", the device is considered present. Health(OK) Device#Status#Heatlth(OK) If health is "OK", the device is considered present and its current status is OK (its power should be OK at least). On Wed, May 19, 2021 at 2:40 PM Ed Tanous wrote: > On Wed, May 19, 2021 at 2:27 PM Nan Zhou wrote: > > > > Thanks for your reply, Ed! > > > >> > >> You've also omitted what properties you're trying to target. Could > >> you walk through a little bit about what you're trying to accomplish > >> with this? (beyond just "implement the redfish schemas). Are you > >> trying to get smart data? just inventory information? Do you plan to > >> represent connections? > > > > > > As a first step, we are only going to implement three properties, Name, > Presence, and PowerStatus. We don't plan to represent connections at the > moment. > > I'm assuming these will be the dbus properties names, as redfish > doesn't really have a presence property or a powerstatus property. > With that said, that seems reasonable to me to want to do, but we need > to make sure we're clear on how this differs from the existing Drive > interfaces. > > > > > On Wed, May 19, 2021 at 1:43 PM Ed Tanous wrote: > >> > >> On Wed, May 19, 2021 at 12:57 AM Jun-Lin Chen (=E9=99=B3=E4=BF=8A=E9= =9C=96) > >> wrote: > >> > > >> > Hi all, > >> > > >> > > >> > > >> > In order to implement the feature to view simple storage device > status, such SATA HDD presence status. > >> > > >> > We propose to implement it on the Redfish SimpleStorage URI. > >> > > >> > > >> > > >> > As our proposal for Redfish SimpleStorage, > https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/43352 > >> > > >> > And an new daemon, > https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/43351 > >> > > >> > > >> > > >> > There are two new dbus-interfaces to be proposed, > >> > > >> > xyz.openbmc_project.Inventory.Item.StorageDevice: here is an empty > interface just mark the dbus path that SimpleStorage Manager should colle= ct. > >> > > >> > xyz.openbmc_project.Inventory.Item.SimpleStorage: it should have the > properties redfish needs, and can be parser by bmcweb. > >> > >> > >> How does this differ from xyz.openbmc_project.Inventory.Item.Drive? > >> They look fairly similar; We generally don't name dbus interfaces > >> after Redfish directly. We should reuse what already exists where > >> possible, and only invent new things where needed. > >> > >> You've also omitted what properties you're trying to target. Could > >> you walk through a little bit about what you're trying to accomplish > >> with this? (beyond just "implement the redfish schemas). Are you > >> trying to get smart data? just inventory information? Do you plan to > >> represent connections? > >> > >> > > >> > > >> > > >> > The details are in the proposal. > >> > > >> > > >> > > >> > Welcome and thank you for comments and suggestions > >> > > >> > > >> > > >> > Best regards, > >> > > >> > Jun-Lin Chen > >> > > >> > > --000000000000f2640005c2b6254b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
>
> Thanks for your reply, Ed!
=
>
>>
<= span class=3D"gmail-im" style=3D"color:rgb(80,0,80)">>> You've al= so omitted what properties you're trying to target.=C2=A0 Could
>> you walk = through a little bit about what you're trying to accomplish
<= span class=3D"gmail-im" style=3D"color:rgb(80,0,80)">>> with this?=C2= =A0 (beyond just "implement the redfish schemas).=C2=A0 Are you
>> trying t= o get smart data?=C2=A0 just inventory information?=C2=A0 Do you plan to>> repr= esent connections?
>
>
>= As a first step, we are only going to implement three properties, Name, Pr= esence, and PowerStatus. We don't plan to represent connections at the = moment.
I'm assuming these will be the dbus properties names, as redfishdoesn't really have a presence property or a powerstatus property.
= With that said, that seems reasonable to me to want to do, but we need
t= o make sure we're clear on how this differs from the existing Drive
= interfaces.
Hi Ed, the presence I am talking about is kind= of a logical=C2=A0concept.=C2=A0You can find the dbus and redfish properti= es in the proposal. I believe we plan to use the following mappings,
<= div>
dbus=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0redifish=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0logical=C2=A0=C2=A0
State(enabled)=C2=A0 =C2=A0 = =C2=A0 =C2=A0Device#Status#State=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0If state is "enabled", the device is considered present.
Health(OK)=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Device#Stat= us#Heatlth(OK)=C2=A0 =C2=A0If health is "OK", the device is consi= dered present and its current status is OK (its power should be OK at least= ).

On Wed, May 19, 2021 at 2:40 PM Ed Tanous <edtanous@google.com> wrote:
On Wed, May 19, 2021 at 2:27 PM Nan Zh= ou <nanzhou@goog= le.com> wrote:
>
> Thanks for your reply, Ed!
>
>>
>> You've also omitted what properties you're trying to targe= t.=C2=A0 Could
>> you walk through a little bit about what you're trying to acco= mplish
>> with this?=C2=A0 (beyond just "implement the redfish schemas)= .=C2=A0 Are you
>> trying to get smart data?=C2=A0 just inventory information?=C2=A0 = Do you plan to
>> represent connections?
>
>
> As a first step, we are only going to implement three properties, Name= , Presence, and PowerStatus. We don't plan to represent connections at = the moment.

I'm assuming these will be the dbus properties names, as redfish
doesn't really have a presence property or a powerstatus property.
With that said, that seems reasonable to me to want to do, but we need
to make sure we're clear on how this differs from the existing Drive interfaces.

>
> On Wed, May 19, 2021 at 1:43 PM Ed Tanous <ed@tanous.net> wrote:
>>
>> On Wed, May 19, 2021 at 12:57 AM Jun-Lin Chen (=E9=99=B3=E4=BF=8A= =E9=9C=96)
>> <Jun-Lin.Chen@quantatw.com> wrote:
>> >
>> > Hi all,
>> >
>> >
>> >
>> > In order to implement the feature to view simple storage devi= ce status, such SATA HDD presence status.
>> >
>> > We propose to implement it on the Redfish SimpleStorage URI.<= br> >> >
>> >
>> >
>> > As our proposal for Redfish SimpleStorage, https://gerrit.openbmc-project.xyz/c/openbmc/docs/+/43352=
>> >
>> > And an new daemon, https://ge= rrit.openbmc-project.xyz/c/openbmc/docs/+/43351
>> >
>> >
>> >
>> > There are two new dbus-interfaces to be proposed,
>> >
>> > xyz.openbmc_project.Inventory.Item.StorageDevice: here is an = empty interface just mark the dbus path that SimpleStorage Manager should c= ollect.
>> >
>> > xyz.openbmc_project.Inventory.Item.SimpleStorage: it should h= ave the properties redfish needs, and can be parser by bmcweb.
>>
>>
>> How does this differ from xyz.openbmc_project.Inventory.Item.Drive= ?
>> They look fairly similar;=C2=A0 We generally don't name dbus i= nterfaces
>> after Redfish directly.=C2=A0 We should reuse what already exists = where
>> possible, and only invent new things where needed.
>>
>> You've also omitted what properties you're trying to targe= t.=C2=A0 Could
>> you walk through a little bit about what you're trying to acco= mplish
>> with this?=C2=A0 (beyond just "implement the redfish schemas)= .=C2=A0 Are you
>> trying to get smart data?=C2=A0 just inventory information?=C2=A0 = Do you plan to
>> represent connections?
>>
>> >
>> >
>> >
>> > The details are in the proposal.
>> >
>> >
>> >
>> > Welcome and thank you for comments and suggestions
>> >
>> >
>> >
>> > Best regards,
>> >
>> > Jun-Lin Chen
>> >
>> >
--000000000000f2640005c2b6254b--