Re: [PATCH 2/2] net: asix: Move declaration of ax88172a_info to shared header

[Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Fri, Aug 9, 2013 at 2:31 PM, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> From: Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> Ensure that the definition of ax88172a_info matches the declaration seen
> by users and silence sparse warnings about symbols without declarations
> in the global namespace by moving the declaration into the shared header
> asix.h.
>
> Signed-off-by: Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  drivers/net/usb/asix.h         | 2 ++
>  drivers/net/usb/asix_devices.c | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/usb/asix.h b/drivers/net/usb/asix.h
> index 346c032..bdaa12d 100644
> --- a/drivers/net/usb/asix.h
> +++ b/drivers/net/usb/asix.h
> @@ -178,6 +178,8 @@ struct asix_common_private {
>         struct asix_rx_fixup_info rx_fixup_info;
>  };
>
> +extern const struct driver_info ax88172a_info;

You could drop the 'extern' here.

All other function prototypes in this header file do not use 'extern'.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html