All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: imx_keypad - convert to a DT-only driver
Date: Tue, 16 Mar 2021 10:35:13 -0300	[thread overview]
Message-ID: <CAOMZO5AKRmA4Qi_YJiE9mPSGZK4KQToO3u5-z271KWR9CUh+GA@mail.gmail.com> (raw)
In-Reply-To: <YFAOYaPkLjCLBIWy@google.com>

Hi Dmitry,

On Mon, Mar 15, 2021 at 10:48 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:

> > @@ -458,6 +458,7 @@ config KEYBOARD_SNVS_PWRKEY
> >  config KEYBOARD_IMX
> >       tristate "IMX keypad support"
> >       depends on ARCH_MXC || COMPILE_TEST
> > +     depends on OF
>
> ARCH_MXC is a stronger constraint than OF, so I wonder if we really need
> this.

ARCH_MXC does not depend on OF yet, but I agree this is a good
suggestion and will submit a patch to do so.

For the time being, I will keep the OF dependency in the driver.

> If we truly converting this driver then we should also remove references
> to dev_get_platdata() and checks for pdev->dev.of_node from
> imx_keypad_probe.

Good point. I removed them in v2.

Thanks

      reply	other threads:[~2021-03-16 13:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 17:10 [PATCH] Input: imx_keypad - convert to a DT-only driver Fabio Estevam
2021-03-16  1:48 ` Dmitry Torokhov
2021-03-16 13:35   ` Fabio Estevam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5AKRmA4Qi_YJiE9mPSGZK4KQToO3u5-z271KWR9CUh+GA@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.