From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752616AbcBOUyb (ORCPT <rfc822;w@1wt.eu>);
	Mon, 15 Feb 2016 15:54:31 -0500
Received: from mail-io0-f169.google.com ([209.85.223.169]:34341 "EHLO
	mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752491AbcBOUy3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 15 Feb 2016 15:54:29 -0500
MIME-Version: 1.0
In-Reply-To: <1455566460-31291-1-git-send-email-clemens.gruber@pqgruber.com>
References: <1455566460-31291-1-git-send-email-clemens.gruber@pqgruber.com>
Date: Mon, 15 Feb 2016 18:54:29 -0200
Message-ID: <CAOMZO5AO4KY+PcQ7ka5Ot-TL222frLO50On+tFXFWGkKhQ25PA@mail.gmail.com>
Subject: Re: [PATCH v2] phy: marvell: Fix and unify reg-init behavior
From: Fabio Estevam <festevam@gmail.com>
To: Clemens Gruber <clemens.gruber@pqgruber.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>, Andrew Lunn <andrew@lunn.ch>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 15, 2016 at 6:01 PM, Clemens Gruber
<clemens.gruber@pqgruber.com> wrote:

> +static int marvell_config_init(struct phy_device *phydev)
> +{
> +       int err;
> +
> +       /* Set registers from marvell,reg-init DT property */
> +       err = marvell_of_reg_init(phydev);
> +       if (err < 0)
> +               return err;
> +
> +       return 0;
>  }

Couldn't this be replaced by

return marvell_of_reg_init(phydev); ?