From: festevam@gmail.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx: Fix Ethernet PHY reset polarity
Date: Sun, 4 Jun 2017 18:06:07 -0300 [thread overview]
Message-ID: <CAOMZO5AP3nNob79G++uDAUBPpzu0dc2gaZnA_wtqbk1vmyFNUQ@mail.gmail.com> (raw)
In-Reply-To: <20170604184937.GA10273@lunn.ch>
Hi Andrew,
On Sun, Jun 4, 2017 at 3:49 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> Hi Fabio
>
> Device tree bindings are supposed to be stable. So we can never fix
Correct and this patch does not cause device tree to be unstable.
> the FEC to respect the flag. This change to 'GPIO_ACTIVE_LOW' makes
> the suggestion the flag is used, and can be set to GPIO_ACTIVE_HIGH.
> If i were to change the value, i would set it to 42, or something new
> like GPIO_FLAGS_BROKEN.
GPIO_ACTIVE_LOW reflects the real polarity of the pin, so the dts
should reflect the reality.
All the users of FEC in mainline are active low, so better fix the dts
description.
It is true that the FEC driver ignores the GPIO polarity and assume
active-low by default, unless ''phy-reset-active-high' is passed.
However device tree should properly describe the hardware,
independently of the kernel driver details and this is what this patch
does.
next prev parent reply other threads:[~2017-06-04 21:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 17:31 [PATCH] ARM: dts: imx: Fix Ethernet PHY reset polarity Fabio Estevam
2017-06-04 18:49 ` Andrew Lunn
2017-06-04 21:06 ` Fabio Estevam [this message]
2017-06-05 14:21 ` Andrew Lunn
2017-06-05 14:19 ` Andrew Lunn
2017-06-05 15:24 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5AP3nNob79G++uDAUBPpzu0dc2gaZnA_wtqbk1vmyFNUQ@mail.gmail.com \
--to=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.