From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0985FC54EBD for ; Fri, 6 Jan 2023 20:30:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A1953853EB; Fri, 6 Jan 2023 21:30:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="n/mnSIic"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A5393854D1; Fri, 6 Jan 2023 21:30:01 +0100 (CET) Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CA57D85358 for ; Fri, 6 Jan 2023 21:29:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-pl1-x632.google.com with SMTP id d15so2840100pls.6 for ; Fri, 06 Jan 2023 12:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xoRD5oZkpeM/wsvK8tdFOkPbxbG21ybBoISaFoPk99c=; b=n/mnSIicemQTZptIDJPcY+DBYIri17fIDQEf697fKoYe8NMSmEZQ7R0wVHq0zCfnft HRJlvdHXJESP04gobouMLrdW9+jqM8QEStbUEZLlK0gR0kBZIihkeDuFivcCWCw8q0Lm +0ssYaPE8M/CO8JxddS3mig/ubHqzY5yC9rc2LexT5/DqPq1rMlbcW/NgiWfEdk3z3cu QVzgyaEK4s1hwlYzN8vro1xEvgvvA2GV/2ni+TVOLm3AeLy8V8MdHqmhdP7z8NWwYeEP J8+8wq484CEzFvzA0oZEpoj9+KdIdxE6KXNqG7go/B/oAzqVE375/ojI0pR/dxQF9J+Y wJoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xoRD5oZkpeM/wsvK8tdFOkPbxbG21ybBoISaFoPk99c=; b=PCamCeCeHOp1zotCMUhYhAsj5AM3O1hdA1Z41JqWcNeUpz6tfr5J2TCx54X+YBsYGq N8FkqLsRsNF20GHfkkkF3flK9nchGbsw+OvdLfF58dVWRiK7boKRAwNFd7bTSILQMYNa 165LbiDq+DLVw+ivHbP0cAuw5RMI5h7UYGHhVCJc6qvkFpNltj8WEZpxAH9C9XpUfWov ysJnXjTSDuS8bvgFApAuPJAhU33RZLztzbKoxD8WtApK31aUF6OEBwGEYXYs1I91rl5J 9HrJRBLIH4iDNGpuTVak0GAieyeaN1rBIn3csAPPyKcU0vcxZsyfZ+SexvirdUepDIrd vY/g== X-Gm-Message-State: AFqh2kp4izKfwjZ+amqXS+cO3WgUj5UW+0LnsO8jkcObGW6BFoAwKNe3 OLXcIfMv79E3mvloceg1nwSPwKD57/Lb1GOwAnc= X-Google-Smtp-Source: AMrXdXtT/VMFbOVKlsxtVLsvC1o1LFth1q1rSfBmUavef68SYj/jMlbjrQkp95Bz+s5Fxr7AGBEsmQxT8VcI2sUp/ds= X-Received: by 2002:a17:902:9342:b0:192:607b:f67c with SMTP id g2-20020a170902934200b00192607bf67cmr3319962plp.55.1673036997142; Fri, 06 Jan 2023 12:29:57 -0800 (PST) MIME-Version: 1.0 References: <20230106155143.4025812-1-trini@konsulko.com> In-Reply-To: <20230106155143.4025812-1-trini@konsulko.com> From: Fabio Estevam Date: Fri, 6 Jan 2023 17:29:45 -0300 Message-ID: Subject: Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow" To: Tom Rini Cc: u-boot@lists.denx.de, Marek Vasut , Patrick Delaunay , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Peng Fan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Fri, Jan 6, 2023 at 12:51 PM Tom Rini wrote: > > This reverts commit 777aaaa706bcfe08c284aed06886db7d482af3f8. > > The changes to this generic function, which is intended to help with > 32bit platforms with large amounts of memory has unintended side effects > (which in turn lead to boot failures) on other platforms which were > previously functional. > > Reported-by: Marek Vasut > Cc: Patrick Delaunay > Cc: Pali Roh=C3=A1r > Signed-off-by: Tom Rini Peng also reported an imx issue caused by 777aaaa706bc (""common/memsize.c: Fix get_effective_memsize() to check for overflow""): https://patchwork.ozlabs.org/project/uboot/patch/20221107080016.1304-2-peng= .fan@oss.nxp.com/