From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCH 2/3] ASoC: wm9713: Use empty struct initializer Date: Wed, 14 Feb 2018 15:01:36 -0200 Message-ID: References: <1518622745-12162-1-git-send-email-festevam@gmail.com> <1518622745-12162-2-git-send-email-festevam@gmail.com> <938aa54c-c599-9efc-e78f-4e72db08199e@opensource.cirrus.com> <52f37612-1e70-33d7-f4c9-e1221e6667fd@opensource.cirrus.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ot0-f196.google.com (mail-ot0-f196.google.com [74.125.82.196]) by alsa0.perex.cz (Postfix) with ESMTP id 92C74267B6D for ; Wed, 14 Feb 2018 18:01:38 +0100 (CET) Received: by mail-ot0-f196.google.com with SMTP id m20so20966210otf.3 for ; Wed, 14 Feb 2018 09:01:38 -0800 (PST) In-Reply-To: <52f37612-1e70-33d7-f4c9-e1221e6667fd@opensource.cirrus.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Richard Fitzgerald Cc: Fabio Estevam , alsa-devel@alsa-project.org, Mark Brown , Charles Keepax List-Id: alsa-devel@alsa-project.org On Wed, Feb 14, 2018 at 2:56 PM, Richard Fitzgerald wrote: > I agree but your commit message didn't say that. It's irrelevant now > Mark has merged the patch, but for anyone looking at the commit message > later, the structure of your commit message implies that the problem > is that {0} doesn't work correctly (probably untrue and certainly not Yes, and that is the message I want to give: {0} does not work correctly if the first member of the struct is a pointer, as we should not explicitly write 0 to pointers.