All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
@ 2015-05-31 21:01 Nikolay Dimitrov
  2015-06-01 13:46 ` Otavio Salvador
                   ` (2 more replies)
  0 siblings, 3 replies; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-05-31 21:01 UTC (permalink / raw)
  To: meta-freescale; +Cc: fabio.estevam

Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg>
---
 ...-mx6sabresd-Enable-HDMI-video-in-bootargs.patch |   60 ++++++++++++++++++++
 recipes-bsp/u-boot/u-boot-fslc_2015.04.bb          |    2 +
 2 files changed, 62 insertions(+)
 create mode 100644 recipes-bsp/u-boot/u-boot-fslc/0001-mx6sabresd-Enable-HDMI-video-in-bootargs.patch

diff --git a/recipes-bsp/u-boot/u-boot-fslc/0001-mx6sabresd-Enable-HDMI-video-in-bootargs.patch b/recipes-bsp/u-boot/u-boot-fslc/0001-mx6sabresd-Enable-HDMI-video-in-bootargs.patch
new file mode 100644
index 0000000..bce93d2
--- /dev/null
+++ b/recipes-bsp/u-boot/u-boot-fslc/0001-mx6sabresd-Enable-HDMI-video-in-bootargs.patch
@@ -0,0 +1,60 @@
+From 36b480be4cbe134adb91097b4a1d0b0750553cc4 Mon Sep 17 00:00:00 2001
+From: Nikolay Dimitrov <picmaster@mail.bg>
+Date: Fri, 22 May 2015 22:15:06 +0300
+Subject: [PATCH] mx6sabresd: Enable HDMI video in bootargs
+
+Upstream-Status: Inappropriate [FSL kernel specific]
+
+Link: http://lists.denx.de/pipermail/u-boot/2015-May/215014.html
+
+Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg>
+---
+ include/configs/mx6sabre_common.h |    7 ++++++-
+ include/configs/mx6sabresd.h      |    6 ++++++
+ 2 files changed, 12 insertions(+), 1 deletion(-)
+
+diff --git a/include/configs/mx6sabre_common.h b/include/configs/mx6sabre_common.h
+index b72522b..86745ac 100644
+--- a/include/configs/mx6sabre_common.h
++++ b/include/configs/mx6sabre_common.h
+@@ -121,6 +121,10 @@
+ #define EMMC_ENV ""
+ #endif
+ 
++#ifndef VIDEO_ARGS
++#define VIDEO_ARGS ""
++#endif
++
+ #define CONFIG_EXTRA_ENV_SETTINGS \
+ 	"script=boot.scr\0" \
+ 	"image=zImage\0" \
+@@ -149,7 +153,8 @@
+ 		"fi\0" \
+ 	EMMC_ENV	  \
+ 	"mmcargs=setenv bootargs console=${console},${baudrate} " \
+-		"root=${mmcroot}\0" \
++		"root=${mmcroot} " \
++		VIDEO_ARGS "\0" \
+ 	"loadbootscript=" \
+ 		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
+ 	"bootscript=echo Running bootscript from mmc ...; " \
+diff --git a/include/configs/mx6sabresd.h b/include/configs/mx6sabresd.h
+index dab2fd2..1bd4912 100644
+--- a/include/configs/mx6sabresd.h
++++ b/include/configs/mx6sabresd.h
+@@ -31,6 +31,12 @@
+ 
+ #define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */
+ 
++#define VIDEO_ARGS	"video=mxcfb0:dev=hdmi,1280x720M@60,if=RGB24 " \
++				"video=mxcfb1:off " \
++				"video=mxcfb2:off " \
++				"video=mxcfb3:off " \
++				"fbmem=28M"
++
+ #include "mx6sabre_common.h"
+ 
+ #define CONFIG_SYS_FSL_USDHC_NUM	3
+-- 
+1.7.10.4
+
diff --git a/recipes-bsp/u-boot/u-boot-fslc_2015.04.bb b/recipes-bsp/u-boot/u-boot-fslc_2015.04.bb
index 726d442..e5cec59 100644
--- a/recipes-bsp/u-boot/u-boot-fslc_2015.04.bb
+++ b/recipes-bsp/u-boot/u-boot-fslc_2015.04.bb
@@ -4,3 +4,5 @@ PV = "v2015.04+git${SRCPV}"
 
 SRCREV = "b16ec2de8ddd3ce3bca7566e045dc085755550f6"
 SRCBRANCH = "patches-2015.04"
+
+SRC_URI += "file://0001-mx6sabresd-Enable-HDMI-video-in-bootargs.patch"
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-05-31 21:01 [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs Nikolay Dimitrov
@ 2015-06-01 13:46 ` Otavio Salvador
  2015-06-01 14:57   ` Nikolay Dimitrov
  2015-06-01 14:01 ` Fabio Estevam
  2015-06-11 12:47 ` Fabio Estevam
  2 siblings, 1 reply; 24+ messages in thread
From: Otavio Salvador @ 2015-06-01 13:46 UTC (permalink / raw)
  To: Nikolay Dimitrov; +Cc: meta-freescale, Fabio Estevam

On Sun, May 31, 2015 at 6:01 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
> Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg>

I agree with the patch but please send it to be applied in the U-Boot
FSLC fork and not in the recipe. This makes it easier to rebase and
maintain against new releases of U-Boot and simplifies the recipe.
Once I apply it we can bump the revision :)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-05-31 21:01 [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs Nikolay Dimitrov
  2015-06-01 13:46 ` Otavio Salvador
@ 2015-06-01 14:01 ` Fabio Estevam
  2015-06-01 14:55   ` Nikolay Dimitrov
  2015-06-01 19:46   ` Nikolay Dimitrov
  2015-06-11 12:47 ` Fabio Estevam
  2 siblings, 2 replies; 24+ messages in thread
From: Fabio Estevam @ 2015-06-01 14:01 UTC (permalink / raw)
  To: Nikolay Dimitrov; +Cc: meta-freescale, Fabio Estevam

On Sun, May 31, 2015 at 6:01 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:

> ++#define VIDEO_ARGS    "video=mxcfb0:dev=hdmi,1280x720M@60,if=RGB24 " \

What if the user wants to use LVDS as fb0?

Not sure if we should really hardcode this kernel command line.

Regards,

Fabio Estevam


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-01 14:01 ` Fabio Estevam
@ 2015-06-01 14:55   ` Nikolay Dimitrov
  2015-06-01 15:04     ` Gary Thomas
  2015-06-01 19:46   ` Nikolay Dimitrov
  1 sibling, 1 reply; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-06-01 14:55 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: meta-freescale, Fabio Estevam, Otavio Salvador

Hi Fabio,

On 06/01/2015 05:01 PM, Fabio Estevam wrote:
> On Sun, May 31, 2015 at 6:01 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>
>> ++#define VIDEO_ARGS    "video=mxcfb0:dev=hdmi,1280x720M@60,if=RGB24 " \
>
> What if the user wants to use LVDS as fb0?
>
> Not sure if we should really hardcode this kernel command line.

Well, the user has some options:

1. editenv mmcargs
2. edit the patch and rebuild

The only reason of proposing it this way is that I haven't found a
better way to do it.

Regards,
Nikolay

PS: Actually, there's a slightly better way - adding support for
extlinux boot configuration, and if you guys are interested I can send
a patch so you can kick my arse about it too :D.


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-01 13:46 ` Otavio Salvador
@ 2015-06-01 14:57   ` Nikolay Dimitrov
  0 siblings, 0 replies; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-06-01 14:57 UTC (permalink / raw)
  To: Otavio Salvador; +Cc: meta-freescale, Fabio Estevam

Hi Otavio,

On 06/01/2015 04:46 PM, Otavio Salvador wrote:
> On Sun, May 31, 2015 at 6:01 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>> Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg>
>
> I agree with the patch but please send it to be applied in the U-Boot
> FSLC fork and not in the recipe. This makes it easier to rebase and
> maintain against new releases of U-Boot and simplifies the recipe.
> Once I apply it we can bump the revision :)

OK, will do, after I understand and address Fabio's concerns.

Regards,
Nikolay


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-01 14:55   ` Nikolay Dimitrov
@ 2015-06-01 15:04     ` Gary Thomas
  0 siblings, 0 replies; 24+ messages in thread
From: Gary Thomas @ 2015-06-01 15:04 UTC (permalink / raw)
  To: meta-freescale

On 2015-06-01 08:55, Nikolay Dimitrov wrote:
> Hi Fabio,
>
> On 06/01/2015 05:01 PM, Fabio Estevam wrote:
>> On Sun, May 31, 2015 at 6:01 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>>
>>> ++#define VIDEO_ARGS    "video=mxcfb0:dev=hdmi,1280x720M@60,if=RGB24 " \
>>
>> What if the user wants to use LVDS as fb0?
>>
>> Not sure if we should really hardcode this kernel command line.
>
> Well, the user has some options:
>
> 1. editenv mmcargs
> 2. edit the patch and rebuild
>
> The only reason of proposing it this way is that I haven't found a
> better way to do it.

If you make this a proper U-Boot [enviroment] variable then it's easy
to override - no compiling necessary :-)

> PS: Actually, there's a slightly better way - adding support for
> extlinux boot configuration, and if you guys are interested I can send
> a patch so you can kick my arse about it too :D.

It might be nice to know how this can work in any case.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-01 14:01 ` Fabio Estevam
  2015-06-01 14:55   ` Nikolay Dimitrov
@ 2015-06-01 19:46   ` Nikolay Dimitrov
  2015-06-02 16:06     ` Nikolay Dimitrov
  1 sibling, 1 reply; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-06-01 19:46 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: meta-freescale, Fabio Estevam, Otavio Salvador

Hi Fabio,

On 06/01/2015 05:01 PM, Fabio Estevam wrote:
> On Sun, May 31, 2015 at 6:01 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>
>> ++#define VIDEO_ARGS    "video=mxcfb0:dev=hdmi,1280x720M@60,if=RGB24 " \
>
> What if the user wants to use LVDS as fb0?
>
> Not sure if we should really hardcode this kernel command line.

What do you think about this:


video_args_hdmi=setenv video_args $video_args 
video=mxcfb${fbid}:dev=hdmi,1280x720M@60,if=RGB24\0
video_args_lvds=setenv video_args $video_args 
video=mxcfb${fbid}:dev=ldb,LDB-XGA,if=RGB666\0
video_args_lcd=setenv video_args $video_args 
video=mxcfb${fbid}:dev=lcd,CLAA-WVGA,if=RGB666\0
fb=0\0
video_interfaces=hdmi lvds lcd\0

config_video=for v in ${video_interfaces}; do \
     run video_args_${v}; \
     setexpr fb $fb + 1; \
done\0

mmcargs=setenv bootargs console=${console},${baudrate} \
     root=${mmcroot} \
     ${video_args}\0
...
mmcboot=echo Booting from mmc ...; \
     run config_video; \
     run mmcargs; \
     ...


Now video interfaces can be selected and reordered at will just by 
editing video_interfaces env-var.

Regards,
Nikolay


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-01 19:46   ` Nikolay Dimitrov
@ 2015-06-02 16:06     ` Nikolay Dimitrov
  2015-06-02 16:09       ` Otavio Salvador
  0 siblings, 1 reply; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-06-02 16:06 UTC (permalink / raw)
  To: meta-freescale, Fabio Estevam, Otavio Salvador

Hi guys,

On 06/01/2015 10:46 PM, Nikolay Dimitrov wrote:
> Hi Fabio,
>
> On 06/01/2015 05:01 PM, Fabio Estevam wrote:
>> On Sun, May 31, 2015 at 6:01 PM, Nikolay Dimitrov <picmaster@mail.bg>
>> wrote:
>>
>>> ++#define VIDEO_ARGS    "video=mxcfb0:dev=hdmi,1280x720M@60,if=RGB24 " \
>>
>> What if the user wants to use LVDS as fb0?
>>
>> Not sure if we should really hardcode this kernel command line.
>
> What do you think about this:
>
>
> video_args_hdmi=setenv video_args $video_args
> video=mxcfb${fbid}:dev=hdmi,1280x720M@60,if=RGB24\0
> video_args_lvds=setenv video_args $video_args
> video=mxcfb${fbid}:dev=ldb,LDB-XGA,if=RGB666\0
> video_args_lcd=setenv video_args $video_args
> video=mxcfb${fbid}:dev=lcd,CLAA-WVGA,if=RGB666\0
> fb=0\0
> video_interfaces=hdmi lvds lcd\0
>
> config_video=for v in ${video_interfaces}; do \
>      run video_args_${v}; \
>      setexpr fb $fb + 1; \
> done\0
>
> mmcargs=setenv bootargs console=${console},${baudrate} \
>      root=${mmcroot} \
>      ${video_args}\0
> ...
> mmcboot=echo Booting from mmc ...; \
>      run config_video; \
>      run mmcargs; \
>      ...
>
>
> Now video interfaces can be selected and reordered at will just by
> editing video_interfaces env-var.

I've cleaned-up the code and sent a pull-request for you to review:

https://github.com/Freescale/u-boot-fslc/pull/8

Regards,
Nikolay


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-02 16:06     ` Nikolay Dimitrov
@ 2015-06-02 16:09       ` Otavio Salvador
  2015-06-03 18:29         ` Nikolay Dimitrov
  0 siblings, 1 reply; 24+ messages in thread
From: Otavio Salvador @ 2015-06-02 16:09 UTC (permalink / raw)
  To: Nikolay Dimitrov; +Cc: meta-freescale

On Tue, Jun 2, 2015 at 1:06 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
...
> I've cleaned-up the code and sent a pull-request for you to review:
>
> https://github.com/Freescale/u-boot-fslc/pull/8

I commented there.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-02 16:09       ` Otavio Salvador
@ 2015-06-03 18:29         ` Nikolay Dimitrov
  2015-06-11 12:07           ` Nikolay Dimitrov
  0 siblings, 1 reply; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-06-03 18:29 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: meta-freescale, Otavio Salvador

Hi Fabio,

We're looking for your input on the following question - do you think
that my patch should cover also sabreauto board, in order to avoid the
VIDEO_ARGS define "hack"?

If you prefer such approach, it would be great if you can test the
patch on the actual board and confirm that it works, as I don't have
access to such board.

FYI - here's the Github discussion for my pull request:

https://github.com/Freescale/u-boot-fslc/pull/8

Thanks in advance for looking into this.

Kind regards,
Nikolay


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-03 18:29         ` Nikolay Dimitrov
@ 2015-06-11 12:07           ` Nikolay Dimitrov
  0 siblings, 0 replies; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-06-11 12:07 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: meta-freescale, Otavio Salvador

Hi Fabio,

On 06/03/2015 09:29 PM, Nikolay Dimitrov wrote:
> Hi Fabio,
>
> We're looking for your input on the following question - do you think
> that my patch should cover also sabreauto board, in order to avoid the
> VIDEO_ARGS define "hack"?
>
> If you prefer such approach, it would be great if you can test the
> patch on the actual board and confirm that it works, as I don't have
> access to such board.
>
> FYI - here's the Github discussion for my pull request:
>
> https://github.com/Freescale/u-boot-fslc/pull/8
>
> Thanks in advance for looking into this.

Can you please take a look at this and tell me your opinion?

Thanks and regards,
Nikolay


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-05-31 21:01 [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs Nikolay Dimitrov
  2015-06-01 13:46 ` Otavio Salvador
  2015-06-01 14:01 ` Fabio Estevam
@ 2015-06-11 12:47 ` Fabio Estevam
  2015-06-11 14:16   ` Nikolay Dimitrov
  2 siblings, 1 reply; 24+ messages in thread
From: Fabio Estevam @ 2015-06-11 12:47 UTC (permalink / raw)
  To: Nikolay Dimitrov, Otavio Salvador; +Cc: meta-freescale, Fabio Estevam

Hi Nikolay,

Sorry for the delay.

On Sun, May 31, 2015 at 6:01 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:

> ++#ifndef VIDEO_ARGS
> ++#define VIDEO_ARGS ""
> ++#endif
> ++
> + #define CONFIG_EXTRA_ENV_SETTINGS \
> +       "script=boot.scr\0" \
> +       "image=zImage\0" \
> +@@ -149,7 +153,8 @@
> +               "fi\0" \
> +       EMMC_ENV          \
> +       "mmcargs=setenv bootargs console=${console},${baudrate} " \
> +-              "root=${mmcroot}\0" \
> ++              "root=${mmcroot} " \
> ++              VIDEO_ARGS "\0" \

This only affects mmc boot, but what if people boot from NFS?

> +       "loadbootscript=" \
> +               "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
> +       "bootscript=echo Running bootscript from mmc ...; " \
> +diff --git a/include/configs/mx6sabresd.h b/include/configs/mx6sabresd.h
> +index dab2fd2..1bd4912 100644
> +--- a/include/configs/mx6sabresd.h
> ++++ b/include/configs/mx6sabresd.h
> +@@ -31,6 +31,12 @@
> +
> + #define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */
> +
> ++#define VIDEO_ARGS    "video=mxcfb0:dev=hdmi,1280x720M@60,if=RGB24 " \
> ++                              "video=mxcfb1:off " \
> ++                              "video=mxcfb2:off " \
> ++                              "video=mxcfb3:off " \
> ++                              "fbmem=28M"
> ++
> + #include "mx6sabre_common.h"

To be honest I don't know what is the best way to handle this.

We could also use the 'hdmidet' command in U-boot and set HDMI as
video argument if a HDMI is connected, but then there is also the
issue that the FSL kernel hangs with HDMI enabled in U-boot.

Regards,

Fabio Estevam


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-11 12:47 ` Fabio Estevam
@ 2015-06-11 14:16   ` Nikolay Dimitrov
  2015-06-11 17:02     ` Fabio Estevam
  0 siblings, 1 reply; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-06-11 14:16 UTC (permalink / raw)
  To: Fabio Estevam, Otavio Salvador; +Cc: meta-freescale, Fabio Estevam

Hi Fabio,

On 06/11/2015 03:47 PM, Fabio Estevam wrote:
> Hi Nikolay,
>
> Sorry for the delay.

Np, I'm sorry for poking you.

> This only affects mmc boot, but what if people boot from NFS?

For sure I realize that there are lots of possible permutations, but I
would prefer someone who really needs this functionality to test and
propose a patch for it, which patch extends the current solution. I
just don't have the resources to implement all the possible variants,
but I will always welcome if you send such a patch.

> To be honest I don't know what is the best way to handle this.

Same here, but this my 4th attempt to provide a better solution
(mainline u-boot, yocto master, 2 patch attempts to u-boot-fslc), and
I'm starting to run out of ideas :D.

Actually the code in your email is from my old patch you rejected.
Here's the actual code from the Github u-boot-fslc pull-request:



 From 1dd053085a7c7dbe7b40aa81b29c35f9de7ef001 Mon Sep 17 00:00:00 2001
From: Nikolay Dimitrov <picmaster@mail.bg>
Date: Tue, 2 Jun 2015 18:44:17 +0300
Subject: [PATCH] mx6sabresd: Enable video interfaces in bootargs

Generate kernel video bootargs for sabresd, based on a list of needed video
interfaces ("video_interfaces" U-Boot env-var). The order of initialization
and video settings can be fully customized.

Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg>
---
  include/configs/mx6sabre_common.h |   25 ++++++++++++++++++++++++-
  include/configs/mx6sabresd.h      |    3 +++
  2 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/include/configs/mx6sabre_common.h 
b/include/configs/mx6sabre_common.h
index b72522b..a8746a4 100644
--- a/include/configs/mx6sabre_common.h
+++ b/include/configs/mx6sabre_common.h
@@ -121,6 +121,14 @@
  #define EMMC_ENV ""
  #endif

+#ifndef VIDEO_ARGS
+#define VIDEO_ARGS ""
+#endif
+
+#ifndef VIDEO_ARGS_SCRIPT
+#define VIDEO_ARGS_SCRIPT ""
+#endif
+
  #define CONFIG_EXTRA_ENV_SETTINGS \
  	"script=boot.scr\0" \
  	"image=zImage\0" \
@@ -148,8 +156,22 @@
  			"fi; "	\
  		"fi\0" \
  	EMMC_ENV	  \
+	"video_args_hdmi=setenv video_args $video_args " \
+		"video=mxcfb${fb}:dev=hdmi,1280x720M@60,if=RGB24\0" \
+	"video_args_lvds=setenv video_args $video_args " \
+		"video=mxcfb${fb}:dev=ldb,LDB-XGA,if=RGB666\0" \
+	"video_args_lcd=setenv video_args $video_args " \
+		"video=mxcfb${fb}:dev=lcd,CLAA-WVGA,if=RGB666\0" \
+	"fb=0\0" \
+	"video_interfaces=hdmi lvds lcd\0" \
+	"video_args_script=" \
+		"for v in ${video_interfaces}; do " \
+			"run video_args_${v}; " \
+			"setexpr fb $fb + 1; " \
+		"done\0" \
  	"mmcargs=setenv bootargs console=${console},${baudrate} " \
-		"root=${mmcroot}\0" \
+		"root=${mmcroot} " \
+		VIDEO_ARGS "\0" \
  	"loadbootscript=" \
  		"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
  	"bootscript=echo Running bootscript from mmc ...; " \
@@ -157,6 +179,7 @@
  	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
  	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
  	"mmcboot=echo Booting from mmc ...; " \
+		VIDEO_ARGS_SCRIPT \
  		"run mmcargs; " \
  		"if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
  			"if run loadfdt; then " \
diff --git a/include/configs/mx6sabresd.h b/include/configs/mx6sabresd.h
index fe71321..9835510 100644
--- a/include/configs/mx6sabresd.h
+++ b/include/configs/mx6sabresd.h
@@ -31,6 +31,9 @@

  #define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */

+#define VIDEO_ARGS        "${video_args}"
+#define VIDEO_ARGS_SCRIPT "run video_args_script; "
+
  #include "mx6sabre_common.h"

  #define CONFIG_SYS_FSL_USDHC_NUM	3
-- 
1.7.10.4



 > We could also use the 'hdmidet' command in U-boot and set HDMI as
 > video argument if a HDMI is connected, but then there is also the
 > issue that the FSL kernel hangs with HDMI enabled in U-boot.

That's correct. I don't think that hdmidet can work without U-Boot HDMI
support, so I would propose the dumb idea of just disabling the U-Boot
HDMI support and have things working in Linux.

Regards,
Nikolay


^ permalink raw reply related	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-11 14:16   ` Nikolay Dimitrov
@ 2015-06-11 17:02     ` Fabio Estevam
  2015-06-11 17:04       ` Nikolay Dimitrov
  2015-06-11 17:06       ` Nikolay Dimitrov
  0 siblings, 2 replies; 24+ messages in thread
From: Fabio Estevam @ 2015-06-11 17:02 UTC (permalink / raw)
  To: Nikolay Dimitrov; +Cc: meta-freescale, Fabio Estevam, Otavio Salvador

Hi Nikolay,

On Thu, Jun 11, 2015 at 11:16 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote:

> Actually the code in your email is from my old patch you rejected.
> Here's the actual code from the Github u-boot-fslc pull-request:

No objections from me.

Regards,

Fabio Estevam


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-11 17:02     ` Fabio Estevam
@ 2015-06-11 17:04       ` Nikolay Dimitrov
  2015-06-11 17:06       ` Nikolay Dimitrov
  1 sibling, 0 replies; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-06-11 17:04 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: meta-freescale, Fabio Estevam, Otavio Salvador

Hi Fabio,

On 06/11/2015 08:02 PM, Fabio Estevam wrote:
> Hi Nikolay,
>
> On Thu, Jun 11, 2015 at 11:16 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>
>> Actually the code in your email is from my old patch you rejected.
>> Here's the actual code from the Github u-boot-fslc pull-request:
>
> No objections from me.
>
> Regards,
>
> Fabio Estevam

Thanks!

Regards,
Nikolay


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-11 17:02     ` Fabio Estevam
  2015-06-11 17:04       ` Nikolay Dimitrov
@ 2015-06-11 17:06       ` Nikolay Dimitrov
  2015-06-11 17:08         ` Fabio Estevam
  1 sibling, 1 reply; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-06-11 17:06 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: meta-freescale, Fabio Estevam, Otavio Salvador

Hi Fabio,

On 06/11/2015 08:02 PM, Fabio Estevam wrote:
> Hi Nikolay,
>
> On Thu, Jun 11, 2015 at 11:16 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>
>> Actually the code in your email is from my old patch you rejected.
>> Here's the actual code from the Github u-boot-fslc pull-request:
>
> No objections from me.

Errm... still, would you recommend to apply the patch as it is only for 
sabresd, or I should change it so it can also work for sabreauto (which 
I can't test here)?

Regards,
Nikolay


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-11 17:06       ` Nikolay Dimitrov
@ 2015-06-11 17:08         ` Fabio Estevam
  2015-06-11 17:14           ` Nikolay Dimitrov
  0 siblings, 1 reply; 24+ messages in thread
From: Fabio Estevam @ 2015-06-11 17:08 UTC (permalink / raw)
  To: Nikolay Dimitrov; +Cc: meta-freescale, Fabio Estevam, Otavio Salvador

On Thu, Jun 11, 2015 at 2:06 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:

> Errm... still, would you recommend to apply the patch as it is only for
> sabresd, or I should change it so it can also work for sabreauto (which I
> can't test here)?

I also can't test it on sabreauto at the moment, so the current
approach (sabresd only) is fine.

Regards,

Fabio Estevam


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-11 17:08         ` Fabio Estevam
@ 2015-06-11 17:14           ` Nikolay Dimitrov
  2015-06-24  2:47             ` Nikolay Dimitrov
  0 siblings, 1 reply; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-06-11 17:14 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: meta-freescale, Fabio Estevam, Otavio Salvador

That's great, thanks!

On 06/11/2015 08:08 PM, Fabio Estevam wrote:
> On Thu, Jun 11, 2015 at 2:06 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>
>> Errm... still, would you recommend to apply the patch as it is only for
>> sabresd, or I should change it so it can also work for sabreauto (which I
>> can't test here)?
>
> I also can't test it on sabreauto at the moment, so the current
> approach (sabresd only) is fine.
>
> Regards,
>
> Fabio Estevam
>
>
>


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-11 17:14           ` Nikolay Dimitrov
@ 2015-06-24  2:47             ` Nikolay Dimitrov
  2015-07-02 21:31               ` Otavio Salvador
  0 siblings, 1 reply; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-06-24  2:47 UTC (permalink / raw)
  To: Otavio Salvador; +Cc: meta-freescale

Hi Otavio,

I don't want to be (too) annoying, but just to kindly remind you - do
you plan to bump u-boot-fslc to 5d9ffd2?

Thanks in advance. Regards,
Nikolay


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-06-24  2:47             ` Nikolay Dimitrov
@ 2015-07-02 21:31               ` Otavio Salvador
  2015-07-03 17:43                 ` Otavio Salvador
  0 siblings, 1 reply; 24+ messages in thread
From: Otavio Salvador @ 2015-07-02 21:31 UTC (permalink / raw)
  To: Nikolay Dimitrov; +Cc: meta-freescale

On Tue, Jun 23, 2015 at 11:47 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
> I don't want to be (too) annoying, but just to kindly remind you - do
> you plan to bump u-boot-fslc to 5d9ffd2?

Queued for merging.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-07-02 21:31               ` Otavio Salvador
@ 2015-07-03 17:43                 ` Otavio Salvador
  2015-07-03 21:23                   ` Nikolay Dimitrov
  0 siblings, 1 reply; 24+ messages in thread
From: Otavio Salvador @ 2015-07-03 17:43 UTC (permalink / raw)
  To: Nikolay Dimitrov; +Cc: meta-freescale

Hello,

Can you rebase this and resend? it didn't apply.

On Thu, Jul 2, 2015 at 6:31 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
> On Tue, Jun 23, 2015 at 11:47 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>> I don't want to be (too) annoying, but just to kindly remind you - do
>> you plan to bump u-boot-fslc to 5d9ffd2?
>
> Queued for merging.
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-07-03 17:43                 ` Otavio Salvador
@ 2015-07-03 21:23                   ` Nikolay Dimitrov
  2015-07-03 21:26                     ` Otavio Salvador
  0 siblings, 1 reply; 24+ messages in thread
From: Nikolay Dimitrov @ 2015-07-03 21:23 UTC (permalink / raw)
  To: Otavio Salvador; +Cc: meta-freescale

Hi Otavio,

On 07/03/2015 08:43 PM, Otavio Salvador wrote:
> Hello,
>
> Can you rebase this and resend? it didn't apply.

The patch you're trying to merge from patchwork was rejected by you on
1.June, when you recommended me to add it to u-boot-fslc instead, and
you promised to bump the u-boot-fslc revision.

The new SRCREV should be 5d9ffd2.

>
> On Thu, Jul 2, 2015 at 6:31 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> On Tue, Jun 23, 2015 at 11:47 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>>> I don't want to be (too) annoying, but just to kindly remind you - do
>>> you plan to bump u-boot-fslc to 5d9ffd2?
>>
>> Queued for merging.
>>
>> --
>> Otavio Salvador                             O.S. Systems
>> http://www.ossystems.com.br        http://code.ossystems.com.br
>> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Regards,
Nikolay


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-07-03 21:23                   ` Nikolay Dimitrov
@ 2015-07-03 21:26                     ` Otavio Salvador
  2015-07-04  1:57                       ` Fabio Estevam
  0 siblings, 1 reply; 24+ messages in thread
From: Otavio Salvador @ 2015-07-03 21:26 UTC (permalink / raw)
  To: Nikolay Dimitrov; +Cc: meta-freescale

On Fri, Jul 3, 2015 at 6:23 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
> On 07/03/2015 08:43 PM, Otavio Salvador wrote:
>> Can you rebase this and resend? it didn't apply.
>
> The patch you're trying to merge from patchwork was rejected by you on
> 1.June, when you recommended me to add it to u-boot-fslc instead, and
> you promised to bump the u-boot-fslc revision.
>
> The new SRCREV should be 5d9ffd2.

Mind to cook a u-boot-fslc bump patch? otherwise I do it on Monday.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs
  2015-07-03 21:26                     ` Otavio Salvador
@ 2015-07-04  1:57                       ` Fabio Estevam
  0 siblings, 0 replies; 24+ messages in thread
From: Fabio Estevam @ 2015-07-04  1:57 UTC (permalink / raw)
  To: Otavio Salvador; +Cc: meta-freescale

On Fri, Jul 3, 2015 at 6:26 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:

>> The new SRCREV should be 5d9ffd2.
>
> Mind to cook a u-boot-fslc bump patch? otherwise I do it on Monday.

I have sent a patch for this.

Regards,

Fabio Estevam


^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2015-07-04  1:57 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-31 21:01 [meta-fsl-arm][PATCH] u-boot-fslc: mx6sabresd: Enable HDMI video in bootargs Nikolay Dimitrov
2015-06-01 13:46 ` Otavio Salvador
2015-06-01 14:57   ` Nikolay Dimitrov
2015-06-01 14:01 ` Fabio Estevam
2015-06-01 14:55   ` Nikolay Dimitrov
2015-06-01 15:04     ` Gary Thomas
2015-06-01 19:46   ` Nikolay Dimitrov
2015-06-02 16:06     ` Nikolay Dimitrov
2015-06-02 16:09       ` Otavio Salvador
2015-06-03 18:29         ` Nikolay Dimitrov
2015-06-11 12:07           ` Nikolay Dimitrov
2015-06-11 12:47 ` Fabio Estevam
2015-06-11 14:16   ` Nikolay Dimitrov
2015-06-11 17:02     ` Fabio Estevam
2015-06-11 17:04       ` Nikolay Dimitrov
2015-06-11 17:06       ` Nikolay Dimitrov
2015-06-11 17:08         ` Fabio Estevam
2015-06-11 17:14           ` Nikolay Dimitrov
2015-06-24  2:47             ` Nikolay Dimitrov
2015-07-02 21:31               ` Otavio Salvador
2015-07-03 17:43                 ` Otavio Salvador
2015-07-03 21:23                   ` Nikolay Dimitrov
2015-07-03 21:26                     ` Otavio Salvador
2015-07-04  1:57                       ` Fabio Estevam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.