From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B4CC433E3 for ; Tue, 23 Mar 2021 14:03:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4859F619CD for ; Tue, 23 Mar 2021 14:03:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231613AbhCWOCq (ORCPT ); Tue, 23 Mar 2021 10:02:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231839AbhCWOCZ (ORCPT ); Tue, 23 Mar 2021 10:02:25 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D595BC061574 for ; Tue, 23 Mar 2021 07:02:24 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id m12so26781391lfq.10 for ; Tue, 23 Mar 2021 07:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ku+levvVxBeqKSuHI7QAU6DJ1TT9V2yW8FV3fTDnwwo=; b=Y4sDWZnWLFkjeVLPKdcxZ9yafDLWRrvFZTzPiEKg8gxPfH70ZCk6lCglyy8tJqxPpm AU4lNcx4+faeYBwKzIlFF4T6qnIGRbykR42u3VFqxtPO6JWxnNVvInx9PdC3LF06Ts+6 DKLmuVRW3PKiaxdZjTm3r+/OS+peiAm9T0HuWfdibI8MUHClff3qHkYl3gLpx35sgFUV AugfY7kpJMUBLhaJrR0nfZ24txNcRqwFz2+Tu948DmtkSPGT3zsHP0iaQlibIA+4VTm7 VMWQTj+XtpOKOy7fsBkZYAsUp9saldvz1XzJaer6qj266b4DYlaqDf0unUa+0cftwsFy wCJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ku+levvVxBeqKSuHI7QAU6DJ1TT9V2yW8FV3fTDnwwo=; b=HzXCazIs7IPnp9iTpDqluWEWqtm4JAgWER3X/lFAs+ulucIgZAqBaeR+lVDfAcE4HC l8zetdHw7LGqCbbLZnEf9dfg1u3hYo2B56K05oenGcjB1o4/wjDe8/6p/WIFaZqnk+mk N4/roDed/nYpPpYmx7TvaDgSF6r8KYcoBxKdvJacxebwN8EfppiLTpyC0qjAIyAu6W+C ovE31VYrMhWd2aY5IW45vbnZAk+I9PpLaABAacK84YWz9j1GE8PUYc00MKOR/vv4ujN+ kqje4MpBPr79jcjEtAY0xWep5F5xbGd0GNktBXpn073x9o973wswmCvXSgJxf5LXiWi+ VHtw== X-Gm-Message-State: AOAM532uG1pSkh6OMbNVvU9eKL9t7+iAVZZ8dgNLYHC8NYq5LhVZuN0u k/XdQmYJbfBFKE8ew8jeK6Wta7/Ko3GsECL1Y1I= X-Google-Smtp-Source: ABdhPJysRw/CzY1wTwDNpPh0ik6UsRhl1MsyNfGxru2rIW2RG1tLkFLSGaeMeUgUm0BNDEhNCX9AVH9Ht53tDcclgd8= X-Received: by 2002:a05:6512:3996:: with SMTP id j22mr2564356lfu.443.1616508143271; Tue, 23 Mar 2021 07:02:23 -0700 (PDT) MIME-Version: 1.0 References: <20210323130550.2289487-1-arnd@kernel.org> In-Reply-To: <20210323130550.2289487-1-arnd@kernel.org> From: Fabio Estevam Date: Tue, 23 Mar 2021 11:02:12 -0300 Message-ID: Subject: Re: [PATCH] drm/imx: fix out of bounds array access warning To: Arnd Bergmann Cc: Philipp Zabel , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Arnd Bergmann , Pengutronix Kernel Team , NXP Linux Team , Marco Felsch , Joe Perches , Laurent Pinchart , Liu Ying , Thomas Zimmermann , DRI mailing list , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Tue, Mar 23, 2021 at 10:05 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > When CONFIG_OF is disabled, building with 'make W=1' produces warnings > about out of bounds array access: > > drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': > drivers/gpu/drm/imx/imx-ldb.c:186:8: error: array subscript -22 is below array bounds of 'struct clk *[4]' [-Werror=array-bounds] What about making the driver depend on OF instead (like it is done in DRM_IMX_HDMI) ? --- a/drivers/gpu/drm/imx/Kconfig +++ b/drivers/gpu/drm/imx/Kconfig @@ -27,7 +27,7 @@ config DRM_IMX_TVE config DRM_IMX_LDB tristate "Support for LVDS displays" - depends on DRM_IMX && MFD_SYSCON + depends on DRM_IMX && MFD_SYSCON && OF depends on COMMON_CLK select DRM_PANEL help From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A290C433C1 for ; Tue, 23 Mar 2021 14:03:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 075B96199F for ; Tue, 23 Mar 2021 14:03:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 075B96199F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q3oa2+Gz8RsDZxpy5IHSKoHoMIT+6SD64cyo4G2TRmg=; b=GM9lYzv4zROdKQ+CxuSaivjNq yqIL8tyyrygtI+m3cOWWVPtvpDfwwgwi499PY+sHJFh/N8XxhA4uJghI68Lelpm+vVYbB66KgCam5 8V3Ra+se+dLUyTzRlkXMSQnw7w0TBQ+0xaQUc06jnAI2v9cjpS6fVs3JO45a/N5fQsGAbYIRuW5kV EnVA1dYkNZhbvTbTeSEdrLMKW6zsnB7zZvKx4f3oBIeX4fTUDqSiQTkdxBXv7XA5eIj1QjHfcVkbh 8yXvtz1czIAO4HIqgtKqOoDJzubuPm6iGP0pkn5dNpu7OXvA7KeY1GAKAkvzSedBwrEOarnGEhy0+ HS07LNjNQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOhc6-00F6fN-Gu; Tue, 23 Mar 2021 14:02:30 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOhc2-00F6e1-ET for linux-arm-kernel@lists.infradead.org; Tue, 23 Mar 2021 14:02:28 +0000 Received: by mail-lf1-x12a.google.com with SMTP id g8so19672228lfv.12 for ; Tue, 23 Mar 2021 07:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ku+levvVxBeqKSuHI7QAU6DJ1TT9V2yW8FV3fTDnwwo=; b=Y4sDWZnWLFkjeVLPKdcxZ9yafDLWRrvFZTzPiEKg8gxPfH70ZCk6lCglyy8tJqxPpm AU4lNcx4+faeYBwKzIlFF4T6qnIGRbykR42u3VFqxtPO6JWxnNVvInx9PdC3LF06Ts+6 DKLmuVRW3PKiaxdZjTm3r+/OS+peiAm9T0HuWfdibI8MUHClff3qHkYl3gLpx35sgFUV AugfY7kpJMUBLhaJrR0nfZ24txNcRqwFz2+Tu948DmtkSPGT3zsHP0iaQlibIA+4VTm7 VMWQTj+XtpOKOy7fsBkZYAsUp9saldvz1XzJaer6qj266b4DYlaqDf0unUa+0cftwsFy wCJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ku+levvVxBeqKSuHI7QAU6DJ1TT9V2yW8FV3fTDnwwo=; b=tUZ6HAzaQ3mkpU2cA5LpjZgepZ5Z4EIXLPifz7K/h60n9rt1XJD48x8F0Eu3tkiQ7X tVI7kBLrxN9fVwnn3ZUtJdltwn7zJDoabIeWmivLyVT2tzHbcsPm7MHNPG6Knl+XVR5o 6iA15UyZNdHwjKkEguloWQKnqAeAbPlEycFb5a1dCbbEp4u7zu+XQaie17nEZxEyloMe OCSRQnvp+kxOFzfOXV38MbLDYVgWggP7AMJolztripceymVhUB/pHe1MYEE6kwjGu2ae AZ5BVSAWz7O2ASb90RtWoQB4p1fkRoh8w1sJNZo/X4TliV5Y+KW2SMNTUDnRbQnBVD/y Xw4A== X-Gm-Message-State: AOAM530mXlZFVoy14xrkTGLHLPyu4KRYddszNYyT+eU2/f0jA4b3u5A9 UEWB8ARHLNypG/k+aHy9afhFXaPRbAzWfrcrlgY= X-Google-Smtp-Source: ABdhPJysRw/CzY1wTwDNpPh0ik6UsRhl1MsyNfGxru2rIW2RG1tLkFLSGaeMeUgUm0BNDEhNCX9AVH9Ht53tDcclgd8= X-Received: by 2002:a05:6512:3996:: with SMTP id j22mr2564356lfu.443.1616508143271; Tue, 23 Mar 2021 07:02:23 -0700 (PDT) MIME-Version: 1.0 References: <20210323130550.2289487-1-arnd@kernel.org> In-Reply-To: <20210323130550.2289487-1-arnd@kernel.org> From: Fabio Estevam Date: Tue, 23 Mar 2021 11:02:12 -0300 Message-ID: Subject: Re: [PATCH] drm/imx: fix out of bounds array access warning To: Arnd Bergmann Cc: Philipp Zabel , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Arnd Bergmann , Pengutronix Kernel Team , NXP Linux Team , Marco Felsch , Joe Perches , Laurent Pinchart , Liu Ying , Thomas Zimmermann , DRI mailing list , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210323_140226_612655_1B72894C X-CRM114-Status: GOOD ( 10.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On Tue, Mar 23, 2021 at 10:05 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > When CONFIG_OF is disabled, building with 'make W=1' produces warnings > about out of bounds array access: > > drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': > drivers/gpu/drm/imx/imx-ldb.c:186:8: error: array subscript -22 is below array bounds of 'struct clk *[4]' [-Werror=array-bounds] What about making the driver depend on OF instead (like it is done in DRM_IMX_HDMI) ? --- a/drivers/gpu/drm/imx/Kconfig +++ b/drivers/gpu/drm/imx/Kconfig @@ -27,7 +27,7 @@ config DRM_IMX_TVE config DRM_IMX_LDB tristate "Support for LVDS displays" - depends on DRM_IMX && MFD_SYSCON + depends on DRM_IMX && MFD_SYSCON && OF depends on COMMON_CLK select DRM_PANEL help _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E885EC433DB for ; Tue, 23 Mar 2021 14:02:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A82CE6199F for ; Tue, 23 Mar 2021 14:02:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A82CE6199F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F39089E7B; Tue, 23 Mar 2021 14:02:26 +0000 (UTC) Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by gabe.freedesktop.org (Postfix) with ESMTPS id E8CC189E7B for ; Tue, 23 Mar 2021 14:02:24 +0000 (UTC) Received: by mail-lf1-x129.google.com with SMTP id b14so13530177lfv.8 for ; Tue, 23 Mar 2021 07:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ku+levvVxBeqKSuHI7QAU6DJ1TT9V2yW8FV3fTDnwwo=; b=Y4sDWZnWLFkjeVLPKdcxZ9yafDLWRrvFZTzPiEKg8gxPfH70ZCk6lCglyy8tJqxPpm AU4lNcx4+faeYBwKzIlFF4T6qnIGRbykR42u3VFqxtPO6JWxnNVvInx9PdC3LF06Ts+6 DKLmuVRW3PKiaxdZjTm3r+/OS+peiAm9T0HuWfdibI8MUHClff3qHkYl3gLpx35sgFUV AugfY7kpJMUBLhaJrR0nfZ24txNcRqwFz2+Tu948DmtkSPGT3zsHP0iaQlibIA+4VTm7 VMWQTj+XtpOKOy7fsBkZYAsUp9saldvz1XzJaer6qj266b4DYlaqDf0unUa+0cftwsFy wCJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ku+levvVxBeqKSuHI7QAU6DJ1TT9V2yW8FV3fTDnwwo=; b=i2V4oIOUbbatbFbcH6bqsix7iKZhIKiCnedFG4gJr2dzq9v+GXWGvgiQrWsLxSyDas vncnc4VLRLmQhC6CEuOWsv4WJhigN02DxBA4xmMU6g84bwcypT8QrV9XMlI6YR6on6/X 3gfkyIOSwKiFp0yHk3pmBGFDDbVFskd6Gs0lEuQsiJiZWT3AN1fLXE42TXo9ciIWVT/d qzLi5Z+hW5N6k9TtqYt/ZGmdDvPqI0uGrmenqTuCxN0Ub7MfWEqpcBqjTBf9YHAI2Y2J aR3BIVrIRfVGOO4Jl+ss/EDx35Sx3xX0Yg8FPE8d3yLTjIdrn1zCSeueYr3zYVGXacqz PkGA== X-Gm-Message-State: AOAM530Buh0Hzq/tUeKGjRPszt2+o1UCbTBTvM9oG5aOZERQ+5PePBwR br+sYGI7IHKbF+woQs74r6dmYte7ciV2h6y02W0= X-Google-Smtp-Source: ABdhPJysRw/CzY1wTwDNpPh0ik6UsRhl1MsyNfGxru2rIW2RG1tLkFLSGaeMeUgUm0BNDEhNCX9AVH9Ht53tDcclgd8= X-Received: by 2002:a05:6512:3996:: with SMTP id j22mr2564356lfu.443.1616508143271; Tue, 23 Mar 2021 07:02:23 -0700 (PDT) MIME-Version: 1.0 References: <20210323130550.2289487-1-arnd@kernel.org> In-Reply-To: <20210323130550.2289487-1-arnd@kernel.org> From: Fabio Estevam Date: Tue, 23 Mar 2021 11:02:12 -0300 Message-ID: Subject: Re: [PATCH] drm/imx: fix out of bounds array access warning To: Arnd Bergmann X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , David Airlie , Thomas Zimmermann , Sascha Hauer , Marco Felsch , DRI mailing list , linux-kernel , Liu Ying , NXP Linux Team , Joe Perches , Shawn Guo , Pengutronix Kernel Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Arnd, On Tue, Mar 23, 2021 at 10:05 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > When CONFIG_OF is disabled, building with 'make W=1' produces warnings > about out of bounds array access: > > drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': > drivers/gpu/drm/imx/imx-ldb.c:186:8: error: array subscript -22 is below array bounds of 'struct clk *[4]' [-Werror=array-bounds] What about making the driver depend on OF instead (like it is done in DRM_IMX_HDMI) ? --- a/drivers/gpu/drm/imx/Kconfig +++ b/drivers/gpu/drm/imx/Kconfig @@ -27,7 +27,7 @@ config DRM_IMX_TVE config DRM_IMX_LDB tristate "Support for LVDS displays" - depends on DRM_IMX && MFD_SYSCON + depends on DRM_IMX && MFD_SYSCON && OF depends on COMMON_CLK select DRM_PANEL help _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel