From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbeDZGV0 (ORCPT ); Thu, 26 Apr 2018 02:21:26 -0400 Received: from mail-ot0-f171.google.com ([74.125.82.171]:39701 "EHLO mail-ot0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508AbeDZGVW (ORCPT ); Thu, 26 Apr 2018 02:21:22 -0400 X-Google-Smtp-Source: AIpwx49I+ayX4m4I5E1Vz4DyVLcud6FQl0gZlaHwbtODe05ih3WsABvgx+xdYpy1rOxgk4SXV6zVDXslWBNy5ZWrumA= MIME-Version: 1.0 In-Reply-To: References: <1524634571-5914-1-git-send-email-Anson.Huang@nxp.com> <1524634571-5914-3-git-send-email-Anson.Huang@nxp.com> From: Fabio Estevam Date: Thu, 26 Apr 2018 03:21:21 -0300 Message-ID: Subject: Re: [PATCH V4 3/6] ARM: dts: imx6sx-sabreauto: add IO expander max7310 support To: Anson Huang Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , Rob Herring , Mark Rutland , Russell King - ARM Linux , dl-linux-imx , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 26, 2018 at 12:06 AM, Anson Huang wrote: > MAX7310 pins are for PCIe, CAN, MLB. GPS etc., these modules are NOT enabled yet, so > I can NOT test it, I think we should add MAX7310 users when these modules are enabled, > ethernet PHY is NOT controlled by it. You said previously that MAX7310 also controls the Ethernet PHY. Is the vendor dts wrong then? If there are no MAX7310 users, why are you adding support for MAX7310 then? Confused. From mboxrd@z Thu Jan 1 00:00:00 1970 From: festevam@gmail.com (Fabio Estevam) Date: Thu, 26 Apr 2018 03:21:21 -0300 Subject: [PATCH V4 3/6] ARM: dts: imx6sx-sabreauto: add IO expander max7310 support In-Reply-To: References: <1524634571-5914-1-git-send-email-Anson.Huang@nxp.com> <1524634571-5914-3-git-send-email-Anson.Huang@nxp.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Apr 26, 2018 at 12:06 AM, Anson Huang wrote: > MAX7310 pins are for PCIe, CAN, MLB. GPS etc., these modules are NOT enabled yet, so > I can NOT test it, I think we should add MAX7310 users when these modules are enabled, > ethernet PHY is NOT controlled by it. You said previously that MAX7310 also controls the Ethernet PHY. Is the vendor dts wrong then? If there are no MAX7310 users, why are you adding support for MAX7310 then? Confused.