From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D0E7C07E95 for ; Sun, 4 Jul 2021 15:35:41 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D512613E5 for ; Sun, 4 Jul 2021 15:35:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D512613E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EBF6682B20; Sun, 4 Jul 2021 17:35:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="tTDYtA22"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DAC0182B66; Sun, 4 Jul 2021 17:35:35 +0200 (CEST) Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 50FC9803B2 for ; Sun, 4 Jul 2021 17:35:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-lf1-x12a.google.com with SMTP id bq39so15158913lfb.12 for ; Sun, 04 Jul 2021 08:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Rmxf7hT6YPA3T+R0/KZFkzAMXIacypPMgwGMwXbQPHE=; b=tTDYtA22E/YflGS7zxQA9keEQNpLjM6wTdTfRnspEJRlxrChsoBBlrVIDcLMoZu33I jlAmNipvgHlqlWevr6HAJTn9u4UQs3ZUG2M1KcwD0OLOUt4MgwzKH1VHr5VY2iTM1vhX bwfJg6c1YIQQYxfsLSIS/aBvkFp+HSKpxfOm2Ud3Oj5A1Fi8ROb1uC9wwAsVJ8Fpc0FM pUdq9u5qrVqTmbnL2pHbZVj7zPFKM7jwfC3dhE9nWKU2tNp6fqzNX/H2h6rFcVlEdAvR XWtm+q6hkjsCIVvOg735BrDGIQGj+bD53srND5X87Xb3dCH9Mr2xWV3iSDWmV8GD04wf Xcsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Rmxf7hT6YPA3T+R0/KZFkzAMXIacypPMgwGMwXbQPHE=; b=qHiDo9vXp357mMoNRayQL+ODKUqtT/TwhESp+Rom/a0SSBXQNQlXxGn8Rwd50Zhj5U 6Q7oydJKqw9IBrFlkGKzg7W2PlRTY8a2fdgcX/pPh0gWEFjpDtk3v//ud/2/IuivcGBQ DuDt/D/Ej0IBZjZYOTBQ8gBi/EY4ImHQEHrSoC8T2aUWlbPOWLmBYRWuZV/cSlrW4/IF PSb4WaDDLdlT6ttpdJvtw2+O1iTcAOucBW2IcAgU2xHT2Lpgx0aOta6ny6HgpEnUVVCX lStD0Scr+opHuRZEQu2FuE30ej3rKsWUcxsjE1GmAwRdixcGB305MQiU8TLScABW2BOw fSsQ== X-Gm-Message-State: AOAM5324g408GQMuwF6ynoVTNwvLgRIHx2KvcEIM/SACtmsQFEG/7u2t +qguFggrGR827pugFo9Xh/J6P8chNkOWvT5j/BM= X-Google-Smtp-Source: ABdhPJytmLHIDrfB2pzfwkMVOKDbZM+8ilZ/TRf0v5j4oMVOzkLTf4wmpzfs6e7/bAyOuy4CUXwvtNr5AbdiQJOFDPc= X-Received: by 2002:a05:6512:3765:: with SMTP id z5mr7038742lft.583.1625412932659; Sun, 04 Jul 2021 08:35:32 -0700 (PDT) MIME-Version: 1.0 References: <20210703195837.28153-1-festevam@denx.de> <20210703195837.28153-2-festevam@denx.de> <39d5feea-7390-25a9-e82d-e1a720c0024e@denx.de> In-Reply-To: From: Fabio Estevam Date: Sun, 4 Jul 2021 12:35:21 -0300 Message-ID: Subject: Re: [PATCH 1/8] imx8mm: Fix USB reg addresses for i.MX8MM To: Marek Vasut Cc: Fabio Estevam , Stefano Babic , U-Boot-Denx , Schrempf Frieder , Tim Harvey , dl-uboot-imx Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Marek, On Sat, Jul 3, 2021 at 10:04 PM Marek Vasut wrote: > > Retrieving the USB base addresses from DT would be preferred, yes, but > > the current code does not do that. > > I implemented exactly that in mx6_parse_dt_addrs() , see: > 4dcfa3bcbcb ("usb: ehci-mx6: Parse USB PHY and MISC offsets from DT") We are talking about USB_BASE_ADDR, right? imx6/imx7/imxrt provide the USB_BASE_ADDR as define. If we remove the imx6 definition from arch/arm/include/asm/arch-mx6/imx-reg= s.h the ehci-mx6: driver fails to build. I didn't want to change ehci-mx6 in this aspect, so that's why I used Frieder's patch that passes USB_BASE_ADDR via define for i.MX8MM too. Is this an acceptable solution? > > Without providing these defines: > > > > drivers/usb/host/ehci-mx6.c:254:62: error: =E2=80=98USB_BASE_ADDR=E2=80= =99 undeclared > > (first use in this function); did you mean =E2=80=98SRC_BASE_ADDR=E2=80= =99? > > 254 | struct usbnc_regs *usbnc =3D (struct usbnc_regs > > *)(uintptr_t)(USB_BASE_ADDR + > > I suspect you need CONFIG_PHY for mx8m . CONFIG_PHY is already selected by imx8mm_evk_defconfig. Thanks, Fabio Estevam