From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Date: Thu, 7 Jan 2016 14:49:51 -0200 Subject: [U-Boot] [PATCH 1/3] pci: Add error values definitions from the kernel In-Reply-To: <20160107162830.GC3359@bill-the-cat> References: <1452113598-32409-1-git-send-email-festevam@gmail.com> <20160107162830.GC3359@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Jan 7, 2016 at 2:28 PM, Tom Rini wrote: > On Thu, Jan 07, 2016 at 11:31:06AM -0200, Fabio Estevam wrote: >> On Thu, Jan 7, 2016 at 10:58 AM, Bin Meng wrote: >> >> > Ah, yes! Sorry I wanted to say the original proposal to "return 0" >> > instead. But now I failed to understand why this fixed the issue >> > because those error numbers are not zero. >> >> The problem only happens if we return a negative value. >> >> > And why returning zero is bad? From a working PCIe controller (either >> >> It is not bad, but I still prefer to keep in sync with the kernel driver. > > And would allow further features later on? That's correct, Tom.