From: Fabio Estevam <festevam@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Mark Brown <broonie@kernel.org>,
Kirill Kapranov <kirill.kapranov@compulab.co.il>,
linux-spi@vger.kernel.org,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH -next] spi: Fix double IDR allocation with DT aliases
Date: Mon, 27 Aug 2018 11:13:49 -0300 [thread overview]
Message-ID: <CAOMZO5B43Cm+xtAMc5tLHAMzoVO0JJR+T+G0MPtC9oGAmjrP2w@mail.gmail.com> (raw)
In-Reply-To: <20180821095303.27664-1-geert+renesas@glider.be>
Hi Geert,
On Tue, Aug 21, 2018 at 6:53 AM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> If the SPI bus number is provided by a DT alias, idr_alloc() is called
> twice, leading to:
>
> WARNING: CPU: 1 PID: 1 at drivers/spi/spi.c:2179 spi_register_controller+0x11c/0x5d8
> couldn't get idr
>
> Fix this by moving the handling of fixed SPI bus numbers up, before the
> DT handling code fills in ctlr->bus_num.
>
> Fixes: 1a4327fbf4554d5b ("spi: fix IDR collision on systems with both fixed and dynamic SPI bus numbers")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
This fixes SPI on imx51-babbage, thanks.
Tested-by: Fabio Estevam <fabio.estevam@nxp.com>
next prev parent reply other threads:[~2018-08-27 14:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 9:53 [PATCH -next] spi: Fix double IDR allocation with DT aliases Geert Uytterhoeven
2018-08-21 13:40 ` Greg KH
2018-08-21 17:42 ` Geert Uytterhoeven
2018-08-22 17:51 ` Kirill Kapranov
2018-08-23 10:21 ` Mark Brown
2018-08-25 17:54 ` Kirill Kapranov
2018-08-26 13:24 ` Mark Brown
2018-08-28 19:47 ` Kirill kapranov
2018-08-27 14:13 ` Fabio Estevam [this message]
2018-08-28 20:58 ` Applied "spi: Fix double IDR allocation with DT aliases" to the spi tree Mark Brown
2018-08-28 20:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5B43Cm+xtAMc5tLHAMzoVO0JJR+T+G0MPtC9oGAmjrP2w@mail.gmail.com \
--to=festevam@gmail.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=kirill.kapranov@compulab.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.