From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F4AC433E6 for ; Wed, 17 Mar 2021 11:58:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB62464F6A for ; Wed, 17 Mar 2021 11:58:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231543AbhCQL5u (ORCPT ); Wed, 17 Mar 2021 07:57:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231319AbhCQL5o (ORCPT ); Wed, 17 Mar 2021 07:57:44 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 702DAC06174A for ; Wed, 17 Mar 2021 04:57:44 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id u10so2766843lju.7 for ; Wed, 17 Mar 2021 04:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1n8lEKAP5tmFeQAnYvwrYiTflTL44w750U5WdG9uU0E=; b=D97uK5relVNUag4c14xbhpiGR63UmxR5Vgcyjg/JiHrBCt7q+Or0Twxt/OaOxa0608 RM+lN+lwEZoWgWRuEBtnn9n1SmHX4TJHxGlwm2YLGqXDvmIMF/PwFnno+5C0pAbaz4oO AkH5CDGPj6KDuo1PvaPjVUON2lz2FhmmeizlwdSGCQcS95YrXPBpKhexL08n3jkM0XNr RTKJSEKwwR06JBy5JtJushv5Ss/S6oENbPTCODbEu74NaHm3tRHVEsKZh/BJvBj0W5j9 wI84uL2kw2jKert808KLU9qX6PVB+ayVfk9U5gQs7i4FoHsDvtXzC5KDi02Tgg+3mXvk a74g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1n8lEKAP5tmFeQAnYvwrYiTflTL44w750U5WdG9uU0E=; b=Lt6Gn+kQGijul/4opCg7OKg1VayzCgr1c5cgXGmP1K7g4jL15VFaelWzsiI6V35kS3 qp+YnRP/gvHAbU/eX8bmnViFFZlfg1Oom9xwbAdLfQPAz53xCJklQ5ZERIuCERV/PQKQ d10rsN6wN7Ks+OISzjNzXTUtiScqR+4Ed2fLqR3tOtBtR1DRiefLIb5zb75v6wkPaFiy 3vfoYngoISLEY2Pt4LpAeMI8r2U7QSIR6sObe59oZarR3/hHiACTCvrrxVlWeOsH90fJ y7lVvsbYV2EcdkAq9YRkz/VebJd/emFFp5qlhk8HUkzwDodiJt7slMN1ETvCL6LZsJuD 0lkQ== X-Gm-Message-State: AOAM533TBo1prlfq34JP4ackp7WS8+Vyrz6FJjWHisZ27zAPgRxOxh8i WtIKjFkB117LVb8a7h/TgmhsV0+Gz9rfbyAcneU= X-Google-Smtp-Source: ABdhPJwDiRxBiJIhWHpBHtNBplCV2HbWRI82c+TkdyI2ovMw94noWimGzg8EUEvXacIFHJ8313fNSp7h1pkLa3s54KA= X-Received: by 2002:a2e:a58d:: with SMTP id m13mr2183644ljp.347.1615982262942; Wed, 17 Mar 2021 04:57:42 -0700 (PDT) MIME-Version: 1.0 References: <20210311192746.7362-1-heiko.thiery@gmail.com> <20210317080249.GT11246@dragon> In-Reply-To: From: Fabio Estevam Date: Wed, 17 Mar 2021 08:57:31 -0300 Message-ID: Subject: Re: [PATCH v2] arm64: configs: Enable PCIe support for imx8mq boards To: Heiko Thiery Cc: Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , Catalin Marinas , Will Deacon , Michael Walle , Lucas Stach , Baruch Siach , Andrey Smirnov , Chris Healy Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On Wed, Mar 17, 2021 at 8:52 AM Heiko Thiery wrote: > > Do we really want it to be built-in? If so, it would be nice to have some > > comments about that in commit log. > > Why would you not want it? I see other SOC PCI controllers are also > enabled. I would like to have it because we have an Intel e1000 on our > pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we > would have the PCI support with the default defconfig. On the NXP > imx8mq EVK a m.2 is connected to the PCI interface. > > Is this the kind of comments you want? You have selected the driver to be built-in: CONFIG_PCI_IMX6=y Shawn's question is why it needs to be built-in instead of a kernel module: CONFIG_PCI_IMX6=m On arch/arm64/configs/defconfig the preference is to select the options as modules, whenever possible. If it can't be a module and needs to be built-in, then please provide a justification in the commit log. Hope this can clarify. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A44C433DB for ; Wed, 17 Mar 2021 11:59:13 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5E1964EB9 for ; Wed, 17 Mar 2021 11:59:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5E1964EB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XpnUz7D5+ieCaYbiuInx6o6tmMJ+GuWQV6CSoERc4KE=; b=kubqr9iiUDPF9NjuHaWjtyTNC toFegWjtB1xRVoiw6UNfzwLRevvJ6YOpvUjj8GPv3KxmajOJJaTkUVx8qwnAs7WbIu0yJpbCp7USH lF4MrSNNMYzciZ2FMjkGcLXccPrDlgXGkFpvyOq8W+NPZzcnTygt2gtz8LHKMp4Gf/Di/lRLrvL6Q D8MdNBfD0e1WMXS0je3T5WrD6N+kGnSelyPPhQwjjWmlHcwzrnJUZQP6ziQqrMGihn5z80qPtJpxm cJYyFKX5Ur/zjUN7HnuthBcU0THCVaSqJKTmugDODt4hBCIsfVNG7dxA+hWyfCu2i90kGEmWsteMm SBa8cUjtQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lMUo9-0033Wc-96; Wed, 17 Mar 2021 11:57:49 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lMUo4-0033Vb-8f for linux-arm-kernel@lists.infradead.org; Wed, 17 Mar 2021 11:57:46 +0000 Received: by mail-lj1-x229.google.com with SMTP id f26so2757679ljp.8 for ; Wed, 17 Mar 2021 04:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1n8lEKAP5tmFeQAnYvwrYiTflTL44w750U5WdG9uU0E=; b=D97uK5relVNUag4c14xbhpiGR63UmxR5Vgcyjg/JiHrBCt7q+Or0Twxt/OaOxa0608 RM+lN+lwEZoWgWRuEBtnn9n1SmHX4TJHxGlwm2YLGqXDvmIMF/PwFnno+5C0pAbaz4oO AkH5CDGPj6KDuo1PvaPjVUON2lz2FhmmeizlwdSGCQcS95YrXPBpKhexL08n3jkM0XNr RTKJSEKwwR06JBy5JtJushv5Ss/S6oENbPTCODbEu74NaHm3tRHVEsKZh/BJvBj0W5j9 wI84uL2kw2jKert808KLU9qX6PVB+ayVfk9U5gQs7i4FoHsDvtXzC5KDi02Tgg+3mXvk a74g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1n8lEKAP5tmFeQAnYvwrYiTflTL44w750U5WdG9uU0E=; b=PEs1yvlHntzRublwU7ok4zkEk/clur5EghnrrtsaStm6R9iNmU68AuxvXpRTNmHskD 5Z0hkM0Cdyix6mEUzoVC9SiP1Rq+0hHZE8PGNPHKVlTNjaEovCNT2WvdwHX5+KIsoFuR C4AQQZswSajKTESMyDXKLy10OpND+1iDVJ36QObhg3YWtvS/AhEzGRCC8ON3vrV4Zaxk 6WYYbb+0099pWutzuKRFLM/skj0iSqetFBS90cwahcGSxXBxy0Y1aBt3hZiHdRByj0KO MceTup+IdmTgw4jkv5tPhV9b18xBFL5lDUXEfPsboB9wHmEhI6CNwUcyvJX2B5XGabSu N97A== X-Gm-Message-State: AOAM531NXLCojY9An7tx/rLttjWAJg9Z9s4kBJkPNghuhJfZ0kapcSLZ Xo4DTzo5Q05CzZ9HnHOvU8hkPtCh76lpHSQQRt8= X-Google-Smtp-Source: ABdhPJwDiRxBiJIhWHpBHtNBplCV2HbWRI82c+TkdyI2ovMw94noWimGzg8EUEvXacIFHJ8313fNSp7h1pkLa3s54KA= X-Received: by 2002:a2e:a58d:: with SMTP id m13mr2183644ljp.347.1615982262942; Wed, 17 Mar 2021 04:57:42 -0700 (PDT) MIME-Version: 1.0 References: <20210311192746.7362-1-heiko.thiery@gmail.com> <20210317080249.GT11246@dragon> In-Reply-To: From: Fabio Estevam Date: Wed, 17 Mar 2021 08:57:31 -0300 Message-ID: Subject: Re: [PATCH v2] arm64: configs: Enable PCIe support for imx8mq boards To: Heiko Thiery Cc: Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , Catalin Marinas , Will Deacon , Michael Walle , Lucas Stach , Baruch Siach , Andrey Smirnov , Chris Healy X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210317_115744_401993_B3C6A12F X-CRM114-Status: GOOD ( 17.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Heiko, On Wed, Mar 17, 2021 at 8:52 AM Heiko Thiery wrote: > > Do we really want it to be built-in? If so, it would be nice to have some > > comments about that in commit log. > > Why would you not want it? I see other SOC PCI controllers are also > enabled. I would like to have it because we have an Intel e1000 on our > pitx-imx8m board and the seconds PCI slot is for a m.2 card. So we > would have the PCI support with the default defconfig. On the NXP > imx8mq EVK a m.2 is connected to the PCI interface. > > Is this the kind of comments you want? You have selected the driver to be built-in: CONFIG_PCI_IMX6=y Shawn's question is why it needs to be built-in instead of a kernel module: CONFIG_PCI_IMX6=m On arch/arm64/configs/defconfig the preference is to select the options as modules, whenever possible. If it can't be a module and needs to be built-in, then please provide a justification in the commit log. Hope this can clarify. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel