All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt: fsl-imx-cspi.txt: Fix comment about GPIOs used for chip selects
@ 2012-04-21 17:21 Fabio Estevam
       [not found] ` <1335028873-3395-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2012-04-21 17:21 UTC (permalink / raw)
  To: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ
  Cc: Fabio Estevam, Fabio Estevam, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ

The gpio numbers does not match the comment. 

Fix the comments for GPIOs used for chip selects.

Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
 .../devicetree/bindings/spi/fsl-imx-cspi.txt       |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
index 9841057..4256a6d 100644
--- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
+++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
@@ -17,6 +17,6 @@ ecspi@70010000 {
 	reg = <0x70010000 0x4000>;
 	interrupts = <36>;
 	fsl,spi-num-chipselects = <2>;
-	cs-gpios = <&gpio3 24 0>, /* GPIO4_24 */
-		   <&gpio3 25 0>; /* GPIO4_25 */
+	cs-gpios = <&gpio3 24 0>, /* GPIO3_24 */
+		   <&gpio3 25 0>; /* GPIO3_25 */
 };
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt: fsl-imx-cspi.txt: Fix comment about GPIOs used for chip selects
       [not found] ` <1335028873-3395-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2012-04-23  1:32   ` Shawn Guo
       [not found]     ` <CAAQ0ZWTsdrYQ28=K=acnP=HT3+1DuTa-X8q0NM66xcvSP21hgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  2012-06-11 14:23   ` Rob Herring
  1 sibling, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2012-04-23  1:32 UTC (permalink / raw)
  To: Fabio Estevam, Grant Likely
  Cc: Fabio Estevam, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ

On 22 April 2012 01:21, Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> The gpio numbers does not match the comment.
>
> Fix the comments for GPIOs used for chip selects.
>
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Acked-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Grant, Rob,

Please let me know if you prefer to have it go through arm-soc tree
than spi or dt tree.

Regards,
Shawn

> ---
>  .../devicetree/bindings/spi/fsl-imx-cspi.txt       |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> index 9841057..4256a6d 100644
> --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> @@ -17,6 +17,6 @@ ecspi@70010000 {
>        reg = <0x70010000 0x4000>;
>        interrupts = <36>;
>        fsl,spi-num-chipselects = <2>;
> -       cs-gpios = <&gpio3 24 0>, /* GPIO4_24 */
> -                  <&gpio3 25 0>; /* GPIO4_25 */
> +       cs-gpios = <&gpio3 24 0>, /* GPIO3_24 */
> +                  <&gpio3 25 0>; /* GPIO3_25 */
>  };
> --
> 1.7.1
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt: fsl-imx-cspi.txt: Fix comment about GPIOs used for chip selects
       [not found]     ` <CAAQ0ZWTsdrYQ28=K=acnP=HT3+1DuTa-X8q0NM66xcvSP21hgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2012-05-21  3:27       ` Fabio Estevam
       [not found]         ` <CAOMZO5B9sX0VuE=Oz3DE4esRHMk9NXpA05pzFb5cxYm=8+qWcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2012-05-21  3:27 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Fabio Estevam, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ

On Sun, Apr 22, 2012 at 10:32 PM, Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> On 22 April 2012 01:21, Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> The gpio numbers does not match the comment.
>>
>> Fix the comments for GPIOs used for chip selects.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>
> Acked-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> Grant, Rob,
>
> Please let me know if you prefer to have it go through arm-soc tree
> than spi or dt tree.

Can this be applied?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt: fsl-imx-cspi.txt: Fix comment about GPIOs used for chip selects
       [not found]         ` <CAOMZO5B9sX0VuE=Oz3DE4esRHMk9NXpA05pzFb5cxYm=8+qWcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2012-06-10 16:54           ` Fabio Estevam
  0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2012-06-10 16:54 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Fabio Estevam, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ,
	rob.herring-bsGFqQB8/DxBDgjK7y7TUQ

Pinging again.

On Mon, May 21, 2012 at 12:27 AM, Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Sun, Apr 22, 2012 at 10:32 PM, Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>> On 22 April 2012 01:21, Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>> The gpio numbers does not match the comment.
>>>
>>> Fix the comments for GPIOs used for chip selects.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
>>
>> Acked-by: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>
>> Grant, Rob,
>>
>> Please let me know if you prefer to have it go through arm-soc tree
>> than spi or dt tree.
>
> Can this be applied?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt: fsl-imx-cspi.txt: Fix comment about GPIOs used for chip selects
       [not found] ` <1335028873-3395-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  2012-04-23  1:32   ` Shawn Guo
@ 2012-06-11 14:23   ` Rob Herring
  1 sibling, 0 replies; 5+ messages in thread
From: Rob Herring @ 2012-06-11 14:23 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: Fabio Estevam, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ

On 04/21/2012 12:21 PM, Fabio Estevam wrote:
> The gpio numbers does not match the comment. 
> 
> Fix the comments for GPIOs used for chip selects.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

Applied.

> ---
>  .../devicetree/bindings/spi/fsl-imx-cspi.txt       |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> index 9841057..4256a6d 100644
> --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> @@ -17,6 +17,6 @@ ecspi@70010000 {
>  	reg = <0x70010000 0x4000>;
>  	interrupts = <36>;
>  	fsl,spi-num-chipselects = <2>;
> -	cs-gpios = <&gpio3 24 0>, /* GPIO4_24 */
> -		   <&gpio3 25 0>; /* GPIO4_25 */
> +	cs-gpios = <&gpio3 24 0>, /* GPIO3_24 */
> +		   <&gpio3 25 0>; /* GPIO3_25 */
>  };

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-06-11 14:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-21 17:21 [PATCH] dt: fsl-imx-cspi.txt: Fix comment about GPIOs used for chip selects Fabio Estevam
     [not found] ` <1335028873-3395-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-04-23  1:32   ` Shawn Guo
     [not found]     ` <CAAQ0ZWTsdrYQ28=K=acnP=HT3+1DuTa-X8q0NM66xcvSP21hgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-21  3:27       ` Fabio Estevam
     [not found]         ` <CAOMZO5B9sX0VuE=Oz3DE4esRHMk9NXpA05pzFb5cxYm=8+qWcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-10 16:54           ` Fabio Estevam
2012-06-11 14:23   ` Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.