* [PATCH] ARM: dts: imx: Swap M53Menlo pinctrl_power_button/pinctrl_power_out pins
@ 2021-07-18 21:43 Marek Vasut
2021-07-18 22:00 ` Fabio Estevam
2021-07-23 8:14 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Marek Vasut @ 2021-07-18 21:43 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Marek Vasut, Shawn Guo, Fabio Estevam, NXP Linux Team
The pinctrl_power_button/pinctrl_power_out each define single GPIO
pinmux, except it is exactly the other one than the matching gpio-keys
and gpio-poweroff DT nodes use for that functionality. Swap the two
GPIOs to correct this error.
Fixes: 50d29fdb765d ("ARM: dts: imx53: Add power GPIOs on M53Menlo")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
---
arch/arm/boot/dts/imx53-m53menlo.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
index f98691ae4415..d3082b9774e4 100644
--- a/arch/arm/boot/dts/imx53-m53menlo.dts
+++ b/arch/arm/boot/dts/imx53-m53menlo.dts
@@ -388,13 +388,13 @@ MX53_PAD_LVDS0_TX3_P__LDB_LVDS0_TX3 0x80000000
pinctrl_power_button: powerbutgrp {
fsl,pins = <
- MX53_PAD_SD2_DATA2__GPIO1_13 0x1e4
+ MX53_PAD_SD2_DATA0__GPIO1_15 0x1e4
>;
};
pinctrl_power_out: poweroutgrp {
fsl,pins = <
- MX53_PAD_SD2_DATA0__GPIO1_15 0x1e4
+ MX53_PAD_SD2_DATA2__GPIO1_13 0x1e4
>;
};
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx: Swap M53Menlo pinctrl_power_button/pinctrl_power_out pins
2021-07-18 21:43 [PATCH] ARM: dts: imx: Swap M53Menlo pinctrl_power_button/pinctrl_power_out pins Marek Vasut
@ 2021-07-18 22:00 ` Fabio Estevam
2021-07-23 8:14 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2021-07-18 22:00 UTC (permalink / raw)
To: Marek Vasut
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Shawn Guo, NXP Linux Team
Hi Marek,
On Sun, Jul 18, 2021 at 6:43 PM Marek Vasut <marex@denx.de> wrote:
>
> The pinctrl_power_button/pinctrl_power_out each define single GPIO
> pinmux, except it is exactly the other one than the matching gpio-keys
> and gpio-poweroff DT nodes use for that functionality. Swap the two
> GPIOs to correct this error.
>
> Fixes: 50d29fdb765d ("ARM: dts: imx53: Add power GPIOs on M53Menlo")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: imx: Swap M53Menlo pinctrl_power_button/pinctrl_power_out pins
2021-07-18 21:43 [PATCH] ARM: dts: imx: Swap M53Menlo pinctrl_power_button/pinctrl_power_out pins Marek Vasut
2021-07-18 22:00 ` Fabio Estevam
@ 2021-07-23 8:14 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2021-07-23 8:14 UTC (permalink / raw)
To: Marek Vasut; +Cc: linux-arm-kernel, Fabio Estevam, NXP Linux Team
On Sun, Jul 18, 2021 at 11:43:02PM +0200, Marek Vasut wrote:
> The pinctrl_power_button/pinctrl_power_out each define single GPIO
> pinmux, except it is exactly the other one than the matching gpio-keys
> and gpio-poweroff DT nodes use for that functionality. Swap the two
> GPIOs to correct this error.
>
> Fixes: 50d29fdb765d ("ARM: dts: imx53: Add power GPIOs on M53Menlo")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-23 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-18 21:43 [PATCH] ARM: dts: imx: Swap M53Menlo pinctrl_power_button/pinctrl_power_out pins Marek Vasut
2021-07-18 22:00 ` Fabio Estevam
2021-07-23 8:14 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.