From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754745AbaFBNfS (ORCPT ); Mon, 2 Jun 2014 09:35:18 -0400 Received: from mail-vc0-f175.google.com ([209.85.220.175]:61560 "EHLO mail-vc0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754351AbaFBNfQ (ORCPT ); Mon, 2 Jun 2014 09:35:16 -0400 MIME-Version: 1.0 In-Reply-To: <537F082F.50501@suse.cz> References: <1399904111-23520-1-git-send-email-vbabka@suse.cz> <1400233673-11477-1-git-send-email-vbabka@suse.cz> <537F082F.50501@suse.cz> Date: Mon, 2 Jun 2014 10:35:15 -0300 Message-ID: Subject: Re: [PATCH v2] mm, compaction: properly signal and act upon lock and need_sched() contention From: Fabio Estevam To: Vlastimil Babka Cc: Shawn Guo , Kevin Hilman , Andrew Morton , Rik van Riel , Stephen Warren , Minchan Kim , Bartlomiej Zolnierkiewicz , Hugh Dickins , LKML , Michal Nazarewicz , linux-mm@kvack.org, Mel Gorman , David Rientjes , Olof Johansson , Greg Thelen , Joonsoo Kim , Christoph Lameter , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vlastimil, On Fri, May 23, 2014 at 5:34 AM, Vlastimil Babka wrote: > Really sorry, guys :/ > > -----8<----- > From: Vlastimil Babka > Date: Fri, 23 May 2014 10:18:56 +0200 > Subject: mm-compaction-properly-signal-and-act-upon-lock-and-need_sched-contention-fix2 > > Step 1: Change function name and comment between v1 and v2 so that the return > value signals the opposite thing. > Step 2: Change the call sites to reflect the opposite return value. > Step 3: ??? > Step 4: Make a complete fool of yourself. > > Signed-off-by: Vlastimil Babka > --- > mm/compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index a525cd4..5175019 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -237,13 +237,13 @@ static inline bool compact_should_abort(struct compact_control *cc) > if (need_resched()) { > if (cc->mode == MIGRATE_ASYNC) { > cc->contended = true; > - return false; > + return true; > } > > cond_resched(); > } > > - return true; > + return false; > } This patch is still not in linux-next. Could you please submit it formally? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by kanga.kvack.org (Postfix) with ESMTP id 9D09D6B0037 for ; Mon, 2 Jun 2014 09:35:16 -0400 (EDT) Received: by mail-vc0-f179.google.com with SMTP id ij19so618580vcb.38 for ; Mon, 02 Jun 2014 06:35:16 -0700 (PDT) Received: from mail-ve0-x22f.google.com (mail-ve0-x22f.google.com [2607:f8b0:400c:c01::22f]) by mx.google.com with ESMTPS id bo9si7861272vcb.86.2014.06.02.06.35.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Jun 2014 06:35:15 -0700 (PDT) Received: by mail-ve0-f175.google.com with SMTP id jw12so5179684veb.34 for ; Mon, 02 Jun 2014 06:35:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <537F082F.50501@suse.cz> References: <1399904111-23520-1-git-send-email-vbabka@suse.cz> <1400233673-11477-1-git-send-email-vbabka@suse.cz> <537F082F.50501@suse.cz> Date: Mon, 2 Jun 2014 10:35:15 -0300 Message-ID: Subject: Re: [PATCH v2] mm, compaction: properly signal and act upon lock and need_sched() contention From: Fabio Estevam Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: Shawn Guo , Kevin Hilman , Andrew Morton , Rik van Riel , Stephen Warren , Minchan Kim , Bartlomiej Zolnierkiewicz , Hugh Dickins , LKML , Michal Nazarewicz , linux-mm@kvack.org, Mel Gorman , David Rientjes , Olof Johansson , Greg Thelen , Joonsoo Kim , Christoph Lameter , linux-arm-kernel Vlastimil, On Fri, May 23, 2014 at 5:34 AM, Vlastimil Babka wrote: > Really sorry, guys :/ > > -----8<----- > From: Vlastimil Babka > Date: Fri, 23 May 2014 10:18:56 +0200 > Subject: mm-compaction-properly-signal-and-act-upon-lock-and-need_sched-contention-fix2 > > Step 1: Change function name and comment between v1 and v2 so that the return > value signals the opposite thing. > Step 2: Change the call sites to reflect the opposite return value. > Step 3: ??? > Step 4: Make a complete fool of yourself. > > Signed-off-by: Vlastimil Babka > --- > mm/compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index a525cd4..5175019 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -237,13 +237,13 @@ static inline bool compact_should_abort(struct compact_control *cc) > if (need_resched()) { > if (cc->mode == MIGRATE_ASYNC) { > cc->contended = true; > - return false; > + return true; > } > > cond_resched(); > } > > - return true; > + return false; > } This patch is still not in linux-next. Could you please submit it formally? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: festevam@gmail.com (Fabio Estevam) Date: Mon, 2 Jun 2014 10:35:15 -0300 Subject: [PATCH v2] mm, compaction: properly signal and act upon lock and need_sched() contention In-Reply-To: <537F082F.50501@suse.cz> References: <1399904111-23520-1-git-send-email-vbabka@suse.cz> <1400233673-11477-1-git-send-email-vbabka@suse.cz> <537F082F.50501@suse.cz> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Vlastimil, On Fri, May 23, 2014 at 5:34 AM, Vlastimil Babka wrote: > Really sorry, guys :/ > > -----8<----- > From: Vlastimil Babka > Date: Fri, 23 May 2014 10:18:56 +0200 > Subject: mm-compaction-properly-signal-and-act-upon-lock-and-need_sched-contention-fix2 > > Step 1: Change function name and comment between v1 and v2 so that the return > value signals the opposite thing. > Step 2: Change the call sites to reflect the opposite return value. > Step 3: ??? > Step 4: Make a complete fool of yourself. > > Signed-off-by: Vlastimil Babka > --- > mm/compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index a525cd4..5175019 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -237,13 +237,13 @@ static inline bool compact_should_abort(struct compact_control *cc) > if (need_resched()) { > if (cc->mode == MIGRATE_ASYNC) { > cc->contended = true; > - return false; > + return true; > } > > cond_resched(); > } > > - return true; > + return false; > } This patch is still not in linux-next. Could you please submit it formally?