All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] imx: mx6: Set Pfuze mode to decrease power number for DSM
Date: Wed, 10 Sep 2014 09:14:54 -0300	[thread overview]
Message-ID: <CAOMZO5BLhse9aSSAE4gVgx-S0wPcX3G2mvU5iQhF1EKQcGRLZA@mail.gmail.com> (raw)
In-Reply-To: <1410340097-19804-4-git-send-email-B37916@freescale.com>

On Wed, Sep 10, 2014 at 6:08 AM, Ye.Li <B37916@freescale.com> wrote:

> +       value = 0xc;
> +       if (pmic_reg_write(p, 0x23, value)) {
> +               printf("Set SW1AB mode error!\n");
> +               return -1;
> +       }

-1 is not a proper return code here.

You could do this instead:

ret = pmic_reg_write(p, 0x23, value)
if (ret) {
        printf("Set SW1AB mode error: %d\n", ret);
        return ret;
}

Same applies for other parts.

  reply	other threads:[~2014-09-10 12:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10  9:08 [U-Boot] [PATCH 1/4] imx: mx6slevk: Add I2C1 support Ye.Li
2014-09-10  9:08 ` [U-Boot] [PATCH 2/4] imx: mx6slevk: Add PMIC Pfuze support Ye.Li
2014-10-30 10:36   ` Stefano Babic
2014-11-04  9:24     ` Li Ye-B37916
2014-11-04  9:37       ` Li Ye-B37916
2014-11-04 14:09         ` Przemyslaw Marczak
2014-11-05  8:28           ` Li Ye-B37916
2014-11-05  9:27             ` Przemyslaw Marczak
2014-11-04 15:56   ` Przemyslaw Marczak
2014-11-05  8:33     ` Li Ye-B37916
2014-11-05  9:41       ` Przemyslaw Marczak
2014-12-22 12:25       ` Fabio Estevam
2014-09-10  9:08 ` [U-Boot] [PATCH 3/4] imx: mx6sabresd: Add clear print for pfuze200 Ye.Li
2014-09-10  9:08 ` [U-Boot] [PATCH 4/4] imx: mx6: Set Pfuze mode to decrease power number for DSM Ye.Li
2014-09-10 12:14   ` Fabio Estevam [this message]
2014-11-04 15:57   ` Przemyslaw Marczak
2014-11-05  9:34     ` Li Ye-B37916

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5BLhse9aSSAE4gVgx-S0wPcX3G2mvU5iQhF1EKQcGRLZA@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.