From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98259C433EF for ; Wed, 2 Feb 2022 17:09:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 14B3983264; Wed, 2 Feb 2022 18:09:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="aY7Fu/+F"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5CA94838EC; Wed, 2 Feb 2022 18:09:07 +0100 (CET) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E5A87838B6 for ; Wed, 2 Feb 2022 18:09:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-ej1-x62f.google.com with SMTP id o12so67475299eju.13 for ; Wed, 02 Feb 2022 09:09:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WKabFrd5ibT62liMUIRHu2c6/8WjLfQKBMPfsXoWYzA=; b=aY7Fu/+FbBOdzg/bdB2OUYOLKgc7KADbM6SFyRsgD6XzrUogWJ5um6dOAOGFVDkTym 4Sv0R3xanpyujuorMvctmW67yD94ehZbB+mLu+QkIQyvE4eMyi3FPWcRPJCptEfpa5wG TURiX2u5JrjmPC0Qi9ARa+YospQ7SzC1DbSJl0rVchuvrMltcIi7+O5j1//e4hQ6HAgc CIZkJXURvAL+ydhHVc/wFWW7un82ybO8UGjTJSUdKddFymcUi3mzixk31TnalHwLQISb zj4CG6grt5RXW0pcb08m/zPOci7N0bGI7lMtAJQsgHMOjM6U4lwa3iNgl9CduShpCx8c aV5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WKabFrd5ibT62liMUIRHu2c6/8WjLfQKBMPfsXoWYzA=; b=TS8PegDXxi5JBpFxqgN3bcEn+01teO1JNBNViGEq2qEs+tFDdfqnFhoCKjENeTwSU3 ppVkuuWZ6TuOI1+I7ARhP//Ahd43qigefv6b9gthTXMfn012ubxuhELNV01kyzy7YjXV CkL3arYTfLRZmA0//S/6wH1ApIgBjkoVUjVmV/+1U2jeXZYa5etznbCY9dCGl4+0rZzg RCrK/EaolXlzd9DOhT6N+lcTx2a0bMwr3CetwYaaQnmjKJ53SZIHwVSCRbauLm+FBShR lTpSXL3Xhc6GLKk4HuTj+HUjn7U7HrkNG/fNmhquiNV1vAcn3UGuue/sVs+5NA2R+KYV Aqmw== X-Gm-Message-State: AOAM533Sjl8wXByS6wqLCr6EAsvRQE/npGO5IuVuvlhH+FdBDCVv3g1P I2se5kxnhvwBURm5TC2KBi9UyIz/yIOhsxR/0Ow= X-Google-Smtp-Source: ABdhPJx28j4E2OdU01LnWP0HHdHl3w8LKQLe9DIJNbVt+71sDwcR4DhNOpPLWj0254AaqgC9jImeljhtLcw+BDqVzFg= X-Received: by 2002:a17:907:6091:: with SMTP id ht17mr26073817ejc.626.1643821743311; Wed, 02 Feb 2022 09:09:03 -0800 (PST) MIME-Version: 1.0 References: <20220131220831.386771-1-marcel@ziswiler.com> In-Reply-To: From: Fabio Estevam Date: Wed, 2 Feb 2022 14:08:53 -0300 Message-ID: Subject: Re: [PATCH v1] mmc: fsl_esdhc_imx: fix watermark level in dma To: Marcel Ziswiler , Tom Rini Cc: U-Boot-Denx , Michael Walle , "NXP i . MX U-Boot Team" , Jaehoon Chung , Sean Anderson , Marcel Ziswiler , Peng Fan , Stefano Babic Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Mon, Jan 31, 2022 at 10:44 PM Fabio Estevam wrote: > > Hi Marcel, > > On Mon, Jan 31, 2022 at 7:08 PM Marcel Ziswiler wrote: > > > > From: Marcel Ziswiler > > > > Seems that we need the waterlevel setting not only for PIO mode as > > without this at least the i.MX 8M Mini won't boot anymore when being > > written by such a U-Boot. Corruption has also been observed both on > > the i.MX 6 as well as i.MX 8M Mini when using ums on the eMMC. Fix > > this by setting the watermark level again regardless of whether in > > DMA or PIO mode. > > > > Fixes: 41c6a22fc296 ("mmc: fsl_esdhc_imx: simplify esdhc_setup_data()") > > Signed-off-by: Marcel Ziswiler > > This is probably the failure I saw on imx7 when I tried testing 'ums'. > > Reviewed-by: Fabio Estevam This indeed fixes the regression I was seeing with imx7s-warp: Tested-by: Fabio Estevam