From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fabio Estevam <festevam@gmail.com>
Date: Thu, 16 Apr 2020 14:33:17 -0300
Subject: [PATCH] board: add InnoComm i.MX8MM WB15EVK
In-Reply-To: <20200409215121.30099-1-mporter@konsulko.com>
References: <20200409215121.30099-1-mporter@konsulko.com>
Message-ID: <CAOMZO5BjqKHMTtWEKF=YGh4pAPjYgbL6hxHwfY-3=zEMscR2Ag@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Matt,

On Thu, Apr 9, 2020 at 6:51 PM Matt Porter <mporter@konsulko.com> wrote:

Hopefully this dts will be sent upstream.

> +/ {
> +       model = "InnoComm i.MX8MM WB15EVK";
> +       compatible = "fsl,imx8mm-wb15evk", "fsl,imx8mm";

Should be "innocomm,imx8mm-wb15evk", "fsl,imx8mm" instead, since the
board manufacturer is InnoComm.

> +&gpio1 {
> +       phy_en {
> +               gpio-hog;
> +               gpios = <10 GPIO_ACTIVE_HIGH>;
> +               output-high;
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&pinctrl_phy_en>;
> +       };

Shouldn't this be modelled as a phy-supply GPIO controlled regulator instead?

> +CONFIG_SPL_SYS_ICACHE_OFF=y
> +CONFIG_SPL_SYS_DCACHE_OFF=y

Can't we work with caches enabled by now?

> +/* USDHC */
> +#define CONFIG_FSL_USDHC

Better put it in the defconfig instead.

> +#define CONFIG_FEC_XCV_TYPE             RGMII
> +#define FEC_QUIRK_ENET_MAC

Shouldn't this be moved to a SoC header instead of each board file?

> +
> +#define IMX_FEC_BASE                    0x30BE0000

Not needed as you are using FEC DM.