All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
	Han Xu <han.xu@nxp.com>,
	linux-mtd@lists.infradead.org, David Wolfe <david.wolfe@nxp.com>
Subject: Re: [PATCH v6 1/2] mtd: fsl-quadspi: Distinguish the mtd device names
Date: Thu, 25 Jan 2018 08:20:59 -0200	[thread overview]
Message-ID: <CAOMZO5Bo4Tbo+uQADrfo2O=LmHn4oFTqN7pWwqMrrtrhkemmEg@mail.gmail.com> (raw)
In-Reply-To: <1516285721-32294-1-git-send-email-fabio.estevam@nxp.com>

Hi Boris,

On Thu, Jan 18, 2018 at 12:28 PM, Fabio Estevam <fabio.estevam@nxp.com> wrote:
> Currently on a imx6sx-sdb board, which has two SPI NOR chips connected
> to QSPI2 the following output from /proc/mtd is seen:
>
> # cat /proc/mtd
> dev:    size   erasesize  name
> mtd0: 01000000 00010000 "21e4000.qspi"
> mtd1: 01000000 00010000 "21e4000.qspi"
>
> Attempts to partition them on the kernel command line result in both
> chips with identical (and identically named) partitions, which is
> an inconvenient behavior.
>
> Assign a different mtd->name for each mtd device to avoid this problem.
>
> After this change the output from /proc/mtd becomes:
>
> # cat /proc/mtd
> dev:    size   erasesize  name
> mtd0: 01000000 00010000 "21e4000.qspi-0"
> mtd1: 01000000 00010000 "21e4000.qspi-1"
>
> In order to keep mtdparts compatibility keep the mtd->name
> unchanged when a single SPI NOR is present.
>
> Reported-by: David Wolfe <david.wolfe@nxp.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> Changes since v5:
> - Preserve the label value, if any. (Boris)

Do you plan to apply this one for 4.17?

Thanks

  parent reply	other threads:[~2018-01-25 10:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-18 14:28 [PATCH v6 1/2] mtd: fsl-quadspi: Distinguish the mtd device names Fabio Estevam
2018-01-18 14:28 ` [PATCH v6 2/2] dt-bindings: fsl-quadspi: Add the example of two SPI NOR Fabio Estevam
2018-01-18 17:24   ` Han Xu
2018-01-18 17:23 ` [PATCH v6 1/2] mtd: fsl-quadspi: Distinguish the mtd device names Han Xu
2018-01-25 10:20 ` Fabio Estevam [this message]
2018-01-25 10:33   ` Boris Brezillon
2018-01-25 10:40     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMZO5Bo4Tbo+uQADrfo2O=LmHn4oFTqN7pWwqMrrtrhkemmEg@mail.gmail.com' \
    --to=festevam@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=david.wolfe@nxp.com \
    --cc=fabio.estevam@nxp.com \
    --cc=han.xu@nxp.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.