From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Estevam Subject: Re: [PATCH] ARM: dts: imx6q-cm-fx6: add analog audio support Date: Tue, 7 Feb 2017 20:39:46 -0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christopher Spinrath Cc: Shawn Guo , Sascha Hauer , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Mark Rutland , Russell King - ARM Linux , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Igor Grinberg , Fabio Estevam , Valentin Raevsky List-Id: devicetree@vger.kernel.org On Tue, Feb 7, 2017 at 6:31 PM, wrote: > +&audmux { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_audmux>; > + status = "okay"; > + > + ssi2 { > + fsl,audmux-port = <1>; > + fsl,port-config = < > + (IMX_AUDMUX_V2_PTCR_RCLKDIR | > + IMX_AUDMUX_V2_PTCR_RCSEL(3 | 0x8) | > + IMX_AUDMUX_V2_PTCR_TCLKDIR | > + IMX_AUDMUX_V2_PTCR_TCSEL(3)) > + IMX_AUDMUX_V2_PDCR_RXDSEL(3) > + >; > + }; > + > + pins5 { Just one minor nit: maybe pins4 since you are using AUD4 pins. Or maybe 'audmux4' as pins4 is too vague ? Reviewed-by: Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: festevam@gmail.com (Fabio Estevam) Date: Tue, 7 Feb 2017 20:39:46 -0200 Subject: [PATCH] ARM: dts: imx6q-cm-fx6: add analog audio support In-Reply-To: References: Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 7, 2017 at 6:31 PM, wrote: > +&audmux { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_audmux>; > + status = "okay"; > + > + ssi2 { > + fsl,audmux-port = <1>; > + fsl,port-config = < > + (IMX_AUDMUX_V2_PTCR_RCLKDIR | > + IMX_AUDMUX_V2_PTCR_RCSEL(3 | 0x8) | > + IMX_AUDMUX_V2_PTCR_TCLKDIR | > + IMX_AUDMUX_V2_PTCR_TCSEL(3)) > + IMX_AUDMUX_V2_PDCR_RXDSEL(3) > + >; > + }; > + > + pins5 { Just one minor nit: maybe pins4 since you are using AUD4 pins. Or maybe 'audmux4' as pins4 is too vague ? Reviewed-by: Fabio Estevam