From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbdKXOot (ORCPT ); Fri, 24 Nov 2017 09:44:49 -0500 Received: from mail-ot0-f177.google.com ([74.125.82.177]:39117 "EHLO mail-ot0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752191AbdKXOoq (ORCPT ); Fri, 24 Nov 2017 09:44:46 -0500 X-Google-Smtp-Source: AGs4zMZWa/5VJGJMrE1R4AyLA3E6afEgC9s0l/dEi3gLSC0Sy8yX4wOYkAb3qD3FSNQuVWqdml/Bbu/LWOxUYyx4AH0= MIME-Version: 1.0 In-Reply-To: References: <1511348560-28505-1-git-send-email-narmstrong@baylibre.com> <1511348560-28505-5-git-send-email-narmstrong@baylibre.com> From: Fabio Estevam Date: Fri, 24 Nov 2017 12:44:45 -0200 Message-ID: Subject: Re: [PATCH v2 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support To: Neil Armstrong Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , linux-kernel , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Neil, On Fri, Nov 24, 2017 at 12:41 PM, Neil Armstrong wrote: >>> +&hdmi { >> >> No ddc-i2c-bus property? > > It's in the board dts. Yes, I saw it while reviewing the other patch. Do different boards use different I2C ports for the HDMI EDID? If not, then you could probably put it here instead. >>> +&pcie { >>> + fsl,tx-swing-full = <103>; >>> + fsl,tx-swing-low = <103>; >>> + status = "disabled"; >> >> No 'reset-gpio' property? >> > > It will be in the board dts. Same here. From mboxrd@z Thu Jan 1 00:00:00 1970 From: festevam@gmail.com (Fabio Estevam) Date: Fri, 24 Nov 2017 12:44:45 -0200 Subject: [PATCH v2 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support In-Reply-To: References: <1511348560-28505-1-git-send-email-narmstrong@baylibre.com> <1511348560-28505-5-git-send-email-narmstrong@baylibre.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Neil, On Fri, Nov 24, 2017 at 12:41 PM, Neil Armstrong wrote: >>> +&hdmi { >> >> No ddc-i2c-bus property? > > It's in the board dts. Yes, I saw it while reviewing the other patch. Do different boards use different I2C ports for the HDMI EDID? If not, then you could probably put it here instead. >>> +&pcie { >>> + fsl,tx-swing-full = <103>; >>> + fsl,tx-swing-low = <103>; >>> + status = "disabled"; >> >> No 'reset-gpio' property? >> > > It will be in the board dts. Same here.