From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <20181022054031.14027-1-peter.chen@nxp.com> <20181022054031.14027-5-peter.chen@nxp.com> <2f67fca8-5a50-641e-9e56-6a5a701a2f70@kontron.de> In-Reply-To: <2f67fca8-5a50-641e-9e56-6a5a701a2f70@kontron.de> From: Fabio Estevam Date: Mon, 22 Oct 2018 11:59:18 -0300 Message-ID: Subject: Re: [PATCH v2 4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups Content-Type: text/plain; charset="UTF-8" To: frieder.schrempf@kontron.de Cc: Peter Chen , USB list , NXP Linux Team , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Schrempf Frieder List-ID: On Mon, Oct 22, 2018 at 11:55 AM Schrempf Frieder wrote: > I think you forgot to improve this description. Maybe something like this: > > pinctrl-names: Names for optional pin modes for "default", "host" or > "device". In case of HSIC-mode "idle" and "active" pin > modes are mandatory. In this case the "idle" state needs > to pull down the data and strobe pin and the "active" > state needs to pull up the strobe pin. Correct, and the dts example is also missing. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,4/4] doc: usb: ci-hdrc-usb2: Add pinctrl properties for HSIC pin groups From: Fabio Estevam Message-Id: Date: Mon, 22 Oct 2018 11:59:18 -0300 To: frieder.schrempf@kontron.de Cc: Peter Chen , USB list , NXP Linux Team , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Schrempf Frieder List-ID: T24gTW9uLCBPY3QgMjIsIDIwMTggYXQgMTE6NTUgQU0gU2NocmVtcGYgRnJpZWRlcgo8ZnJpZWRl ci5zY2hyZW1wZkBrb250cm9uLmRlPiB3cm90ZToKCj4gSSB0aGluayB5b3UgZm9yZ290IHRvIGlt cHJvdmUgdGhpcyBkZXNjcmlwdGlvbi4gTWF5YmUgc29tZXRoaW5nIGxpa2UgdGhpczoKPgo+IHBp bmN0cmwtbmFtZXM6IE5hbWVzIGZvciBvcHRpb25hbCBwaW4gbW9kZXMgZm9yICJkZWZhdWx0Iiwg Imhvc3QiIG9yCj4gICAgICAgICAgICAgICAgICJkZXZpY2UiLiBJbiBjYXNlIG9mIEhTSUMtbW9k ZSAiaWRsZSIgYW5kICJhY3RpdmUiIHBpbgo+ICAgICAgICAgICAgICAgICBtb2RlcyBhcmUgbWFu ZGF0b3J5LiBJbiB0aGlzIGNhc2UgdGhlICJpZGxlIiBzdGF0ZSBuZWVkcwo+ICAgICAgICAgICAg ICAgICB0byBwdWxsIGRvd24gdGhlIGRhdGEgYW5kIHN0cm9iZSBwaW4gYW5kIHRoZSAiYWN0aXZl Igo+ICAgICAgICAgICAgICAgICBzdGF0ZSBuZWVkcyB0byBwdWxsIHVwIHRoZSBzdHJvYmUgcGlu LgoKQ29ycmVjdCwgYW5kIHRoZSBkdHMgZXhhbXBsZSBpcyBhbHNvIG1pc3NpbmcuCg==